Re: Review Request 48095: GEODE-1468 client/server messaging can create large objects

[Udo Kohlmeyer <uk...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48095/#review135739
-----------------------------------------------------------


Ship it!




Ship It!

- Udo Kohlmeyer


On May 31, 2016, 10:15 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48095/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 10:15 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-1468
>     https://issues.apache.org/jira/browse/GEODE-1468
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> After a Message has been sent we invoke clear() on each Part contained by the Message.  This was nulling out the "part" variable of the Part objects but if one of these "parts" was a HeapDataOutputStream it might hold a list of large buffers.  This change set alters Part to close these streams so that their buffers can be cleared.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/HeapDataOutputStream.java 20d01da880f2786a01ee4d4bd64681cd646acd31 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java a011875d4ea9aa9a14ac96e568fe6bba464bca89 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java bf90fab4999ce96adced9574678605d2bf8a903a 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/MessageJUnitTest.java 9f05aa7a0ae0d433ff9675a5fbcffc9c98ce8e7b 
> 
> Diff: https://reviews.apache.org/r/48095/diff/
> 
> 
> Testing
> -------
> 
> New test, precheckin
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>