You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/10 20:48:20 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #2172: Add LogicalPlan::SubqueryAlias

Dandandan commented on code in PR #2172:
URL: https://github.com/apache/arrow-datafusion/pull/2172#discussion_r846840390


##########
datafusion/core/src/logical_plan/builder.rs:
##########
@@ -518,6 +518,18 @@ impl LogicalPlanBuilder {
         })))
     }
 
+    /// Apply an alias
+    pub fn alias(&self, alias: &str) -> Result<Self> {

Review Comment:
   I think I prefer the approach taken in this PR, as it could handle subqueries rather than just table scans (as suggested by the name).
   
   I think this is a cleaner, more generic approach.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org