You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "pantianying (GitHub)" <gi...@apache.org> on 2019/11/22 10:53:11 UTC

[GitHub] [dubbo-go] pantianying opened pull request #258: add code to fix bug

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:

**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #258: Fix: [#259](https://github.com/apache/dubbo-go/issues/259)

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=h1) Report
> Merging [#258](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/52cce967657867c636979c0421426f54bae10e8e?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/258/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    66.24%   66.17%   -0.08%     
===========================================
  Files          108      108              
  Lines         6903     6917      +14     
===========================================
+ Hits          4573     4577       +4     
- Misses        1879     1889      +10     
  Partials       451      451
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.79% <0%> (-2.99%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=footer). Last update [52cce96...eed1410](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #258: Fix: After disconnection with ZK registry, cosumer can't listen to provider changes

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=h1) Report
> Merging [#258](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/52cce967657867c636979c0421426f54bae10e8e?src=pr&el=desc) will **decrease** coverage by `0.85%`.
> The diff coverage is `11.76%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/258/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    66.24%   65.39%   -0.86%     
===========================================
  Files          108      111       +3     
  Lines         6903     7053     +150     
===========================================
+ Hits          4573     4612      +39     
- Misses        1879     1983     +104     
- Partials       451      458       +7
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.79% <0%> (-2.99%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `62.5% <100%> (+0.79%)` | :arrow_up: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `57.86% <0%> (-15.74%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <0%> (-10.72%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `76.47% <0%> (-5.89%)` | :arrow_down: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `84.41% <0%> (-2.6%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `67.9% <0%> (-2.47%)` | :arrow_down: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `58.53% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <0%> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=footer). Last update [52cce96...b11740e](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #258: Fix: [#259](https://github.com/apache/dubbo-go/issues/259)

Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
why n==1 listener.Close()?

[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #258: Fix: [#259](https://github.com/apache/dubbo-go/issues/259)

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=h1) Report
> Merging [#258](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/52cce967657867c636979c0421426f54bae10e8e?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/258/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    66.24%   66.17%   -0.08%     
===========================================
  Files          108      108              
  Lines         6903     6917      +14     
===========================================
+ Hits          4573     4577       +4     
- Misses        1879     1889      +10     
  Partials       451      451
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.79% <0%> (-2.99%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=footer). Last update [52cce96...753e340](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #258: add code to fix bug

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=h1) Report
> Merging [#258](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/52cce967657867c636979c0421426f54bae10e8e?src=pr&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/258/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    66.24%   66.11%   -0.13%     
===========================================
  Files          108      108              
  Lines         6903     6909       +6     
===========================================
- Hits          4573     4568       -5     
- Misses        1879     1889      +10     
- Partials       451      452       +1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `57.46% <0%> (-1.32%)` | :arrow_down: |
| [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=footer). Last update [52cce96...a096134](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #258: Fix: [#259](https://github.com/apache/dubbo-go/issues/259)

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=h1) Report
> Merging [#258](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/52cce967657867c636979c0421426f54bae10e8e?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/258/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    66.24%   66.17%   -0.08%     
===========================================
  Files          108      108              
  Lines         6903     6917      +14     
===========================================
+ Hits          4573     4577       +4     
- Misses        1879     1889      +10     
  Partials       451      451
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.79% <0%> (-2.99%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=footer). Last update [52cce96...5ad1904](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #258: Fix: [#259](https://github.com/apache/dubbo-go/issues/259)

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls place this func above Subscribe

[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] vongosling commented on issue #258: Fix: [#259](https://github.com/apache/dubbo-go/issues/259)

Posted by "vongosling (GitHub)" <gi...@apache.org>.
@pantianying Do not use the topic style like "Fix: [#259](https://github.com/apache/dubbo-go/issues/259) #", Could you detail your fixing problem, getting more people to see what you're doing from the name and more people involved

[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #258: Fix: After disconnection with ZK registry, cosumer can't listen to provider changes

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=h1) Report
> Merging [#258](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4014c59dce6c60c82c48e2f8558ae92363666f5d?src=pr&el=desc) will **decrease** coverage by `1.11%`.
> The diff coverage is `11.76%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/258/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    66.38%   65.26%   -1.12%     
===========================================
  Files          111      111              
  Lines         7038     7053      +15     
===========================================
- Hits          4672     4603      -69     
- Misses        1907     1993      +86     
+ Partials       459      457       -2
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.79% <0%> (-2.99%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `62.5% <100%> (+0.79%)` | :arrow_up: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `54.71% <0%> (-16.99%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `57.86% <0%> (-15.74%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <0%> (-10.72%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `76.47% <0%> (-5.89%)` | :arrow_down: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `84.41% <0%> (-2.6%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `67.9% <0%> (-2.47%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (-1.04%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=footer). Last update [4014c59...ec0209d](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #258: add code to fix bug

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
wait := time.Duration(n * 2e8)

[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #258: Fix: [#259](https://github.com/apache/dubbo-go/issues/259)

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=h1) Report
> Merging [#258](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/52cce967657867c636979c0421426f54bae10e8e?src=pr&el=desc) will **decrease** coverage by `0.11%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/258/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    66.24%   66.12%   -0.12%     
===========================================
  Files          108      108              
  Lines         6903     6917      +14     
===========================================
+ Hits          4573     4574       +1     
- Misses        1879     1891      +12     
- Partials       451      452       +1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.79% <0%> (-2.99%)` | :arrow_down: |
| [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.79% <0%> (-1.51%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `64.45% <0%> (+0.57%)` | :arrow_up: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `47.93% <0%> (+1.03%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=footer). Last update [52cce96...753e340](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #258: Fix: [#259](https://github.com/apache/dubbo-go/issues/259)

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=h1) Report
> Merging [#258](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/52cce967657867c636979c0421426f54bae10e8e?src=pr&el=desc) will **decrease** coverage by `0.71%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/258/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
- Coverage    66.24%   65.53%   -0.72%     
===========================================
  Files          108      111       +3     
  Lines         6903     7048     +145     
===========================================
+ Hits          4573     4619      +46     
- Misses        1879     1973      +94     
- Partials       451      456       +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `56.61% <0%> (-2.17%)` | :arrow_down: |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `57.86% <0%> (-15.74%)` | :arrow_down: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <0%> (-10.72%)` | :arrow_down: |
| [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `76.47% <0%> (-5.89%)` | :arrow_down: |
| [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `67.9% <0%> (-2.47%)` | :arrow_down: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `58.53% <0%> (ø)` | :arrow_up: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.08% <0%> (ø)` | :arrow_up: |
| [registry/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL2xpc3RlbmVyLmdv) | `76.74% <0%> (ø)` | :arrow_up: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `59.25% <0%> (ø)` | :arrow_up: |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `61.78% <0%> (ø)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/258/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=footer). Last update [52cce96...aa78cd1](https://codecov.io/gh/apache/dubbo-go/pull/258?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/258 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org