You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by pgandhi999 <gi...@git.apache.org> on 2017/08/01 15:55:49 UTC

[GitHub] spark pull request #18707: [SPARK-21503][UI]: Spark UI shows incorrect task ...

Github user pgandhi999 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18707#discussion_r130648764
  
    --- Diff: core/src/test/scala/org/apache/spark/ui/StagePageSuite.scala ---
    @@ -84,6 +84,19 @@ class StagePageSuite extends SparkFunSuite with LocalSparkContext {
             jobListener.onTaskEnd(
               SparkListenerTaskEnd(0, 0, "result", Success, taskInfo, taskMetrics))
         }
    +    (3 to 4).foreach {
    --- End diff --
    
    You are right. I did try to simulate a similar unit test for Executors Tab UI, but it needs creating a SparkUI object which cannot be accessed from StagePageSuite. Hence, I am reverting my unit test for the time being. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org