You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Bertrand Delacretaz <bd...@apache.org> on 2010/06/28 14:12:47 UTC
davidgsoc2010 editor review
Hi Federico,
I had a closer look at your code from
http://davidgsoc2010.googlecode.com/svn/trunk revision 22, here are my
comments.
The main thing is that I haven't been able to test the CRUD functions
completely, could you provide an instructions page (similar to my
testing steps below, just basic information about how to do the CRUD
cycle) or screencast with the steps that you use to create, retrieve,
update and delete an entry? Would be good to have that tomorrow if you
have time to work on it.
You can write that on the public Sling wiki at
https://cwiki.apache.org/confluence/display/SLING/Index, or on your
Google code wiki, whatever's more convenient.
I'll then try again with your suggested scenario.
A few comments upfront:
1. The ckeditor javascript and other files should be provided in a
separate bundle, using Sling-Bundle-Resources as done by the
contrib/extensions/dojo bundle. This will make your bundle simpler and
dedicated to your application, and will avoid "polluting" the
repository with those source files, as they will be served from inside
the bundle.
2. Same for the iText stuff, should be a separate bundle.
3. We don't usually have utility scripts like your start.bat in our
code repository
Nothing urgent, you can fix those things after we get the CRUD part reviewed.
Here's what I tried so far:
0. Start sling using the launchpad/builder standalone jar, current
trunk, after deleting the "sling" working folder to start clean.
1. Apply enclosed patches for pom.xml and david.json - the "name"
property in the latter meant that the node was created at
"/content/Starting Point", there was no node at /content/david which
might explain your "start at /content/david does not work" problem.
2. Build and install bundle
2. Start at http://localhost:8888/content/david.html
-> rendered by HtmlRendererServlet - I would expect a CMS home page
with explanations here
3. Try http://localhost:8888/content/david.list.html
-> Menu page to create, list and search entries looks good. Should be
the default rendering of david.html IMO.
4. Use menu item to get to /content/david.new to create an entry
-> Editing page looks nice
-> Way too many menu options for my taste in the editor
-> Submit button doesn't seem to save, I get a JS dialog saying
[object XMLHttpRequest]
-> I wasn't able to save an entry
-Bertrand
Patches:
Index: pom.xml
===================================================================
--- pom.xml (revision 22)
+++ pom.xml (working copy)
@@ -67,6 +67,11 @@
</Sling-Initial-Content>
<Export-Package>sling.gsoc.david.servlet</Export-Package>
<Private-Package>sling.gsoc.david.servlet.*</Private-Package>
+ <Import-Package>
+ !org.bouncycastle.*,
+ !javax.crypto.*,
+ *
+ </Import-Package>
<Embed-Dependency>itextpdf</Embed-Dependency>
</instructions>
</configuration>
--- src/main/resources/initial-content/content/david.json (revision 22)
+++ src/main/resources/initial-content/content/david.json (working copy)
@@ -1,5 +1,5 @@
{
- "name": "Starting point",
+ "name": "david",
"primaryNodeType": "nt:unstructured",
"sling:resourceType": "david",
"jcr:primaryType": "nt:unstructured"
Re: davidgsoc2010 editor review
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi Federico,
On Fri, Jul 2, 2010 at 1:53 AM, Federico Paparoni
<fe...@gmail.com> wrote:
> ...in the url http://code.google.com/p/davidgsoc2010/wiki/SimpleInstructionsyou
> can find the simple steps you have to do....
Thanks - note that you still need the david.json patch that I supplied
earlier in this thread, AFAIK.
> The error you received is about authentication, that as you now for the
> moment isn't implemented...
Ok, for now you could just add a login link to /system/sling/login.
With this info I've been able to test the CRUD functionality, thanks!
Minor issues:
1) I would display the list of entries directly at
http://localhost:8888/content/david.home (which should be david.html
IMO) instead of using a separate page
2) /content/david.search didn't work for me, the page doesn't include
a search button - I can enter text in the search field but if I press
ENTER that does not trigger the search. Haven't looked at that code
yet.
At this point I think it would be good to start keeping track of
issues to have a clear roadmap - I suggest that you create issues
linked to https://issues.apache.org/jira/browse/SLING-1438 for this,
what do you think?
I'll review your code now and report on that in a separate email.
-Bertrand
Re: davidgsoc2010 editor review
Posted by Federico Paparoni <fe...@gmail.com>.
Hi Bertrand,
in the url http://code.google.com/p/davidgsoc2010/wiki/SimpleInstructionsyou
can find the simple steps you have to do.
The error you received is about authentication, that as you now for the
moment isn't implemented.
Cheers
Federico
2010/6/28 Bertrand Delacretaz <bd...@apache.org>
> Hi Federico,
>
> I had a closer look at your code from
> http://davidgsoc2010.googlecode.com/svn/trunk revision 22, here are my
> comments.
>
> The main thing is that I haven't been able to test the CRUD functions
> completely, could you provide an instructions page (similar to my
> testing steps below, just basic information about how to do the CRUD
> cycle) or screencast with the steps that you use to create, retrieve,
> update and delete an entry? Would be good to have that tomorrow if you
> have time to work on it.
>
> You can write that on the public Sling wiki at
> https://cwiki.apache.org/confluence/display/SLING/Index, or on your
> Google code wiki, whatever's more convenient.
>
> I'll then try again with your suggested scenario.
>
> A few comments upfront:
>
> 1. The ckeditor javascript and other files should be provided in a
> separate bundle, using Sling-Bundle-Resources as done by the
> contrib/extensions/dojo bundle. This will make your bundle simpler and
> dedicated to your application, and will avoid "polluting" the
> repository with those source files, as they will be served from inside
> the bundle.
>
> 2. Same for the iText stuff, should be a separate bundle.
>
> 3. We don't usually have utility scripts like your start.bat in our
> code repository
>
> Nothing urgent, you can fix those things after we get the CRUD part
> reviewed.
>
> Here's what I tried so far:
>
> 0. Start sling using the launchpad/builder standalone jar, current
> trunk, after deleting the "sling" working folder to start clean.
>
> 1. Apply enclosed patches for pom.xml and david.json - the "name"
> property in the latter meant that the node was created at
> "/content/Starting Point", there was no node at /content/david which
> might explain your "start at /content/david does not work" problem.
>
> 2. Build and install bundle
>
> 2. Start at http://localhost:8888/content/david.html
> -> rendered by HtmlRendererServlet - I would expect a CMS home page
> with explanations here
>
> 3. Try http://localhost:8888/content/david.list.html
> -> Menu page to create, list and search entries looks good. Should be
> the default rendering of david.html IMO.
>
> 4. Use menu item to get to /content/david.new to create an entry
> -> Editing page looks nice
> -> Way too many menu options for my taste in the editor
> -> Submit button doesn't seem to save, I get a JS dialog saying
> [object XMLHttpRequest]
> -> I wasn't able to save an entry
>
> -Bertrand
>
> Patches:
>
> Index: pom.xml
> ===================================================================
> --- pom.xml (revision 22)
> +++ pom.xml (working copy)
> @@ -67,6 +67,11 @@
> </Sling-Initial-Content>
>
> <Export-Package>sling.gsoc.david.servlet</Export-Package>
>
> <Private-Package>sling.gsoc.david.servlet.*</Private-Package>
> + <Import-Package>
> + !org.bouncycastle.*,
> + !javax.crypto.*,
> + *
> + </Import-Package>
> <Embed-Dependency>itextpdf</Embed-Dependency>
> </instructions>
> </configuration>
>
>
> --- src/main/resources/initial-content/content/david.json (revision
> 22)
> +++ src/main/resources/initial-content/content/david.json (working
> copy)
> @@ -1,5 +1,5 @@
> {
> - "name": "Starting point",
> + "name": "david",
> "primaryNodeType": "nt:unstructured",
> "sling:resourceType": "david",
> "jcr:primaryType": "nt:unstructured"
>
--
Federico Paparoni
Website http://www.javastaff.com
Blog http://doc.javastaff.com