You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/04/06 21:32:41 UTC

[GitHub] pritidesai closed pull request #860: Remove the variable clibuild

pritidesai closed pull request #860: Remove the variable clibuild
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/860
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/cmd/version.go b/cmd/version.go
old mode 100644
new mode 100755
index c0f194a5..2d4d7105
--- a/cmd/version.go
+++ b/cmd/version.go
@@ -36,9 +36,7 @@ var versionCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		wskprint.PrintlnOpenWhiskOutput(
 			// Note: no need to translate the following string
-			// TODO(#767) - Flags.CliBuild and CliVersion are not set during build
-			fmt.Sprintf("wskdeploy build-version: %s--%s",
-				utils.Flags.CliBuild,
-				utils.Flags.CliVersion))
+			// TODO(#767) - Flags.CliVersion are not set during build
+			fmt.Sprintf("wskdeploy version: %s", utils.Flags.CliVersion))
 	},
 }
diff --git a/main.go b/main.go
index 06c10caa..54a80930 100644
--- a/main.go
+++ b/main.go
@@ -29,11 +29,8 @@ func main() {
 var (
 	//Version ...The Version of the tool
 	Version = "unset"
-	//Build ...The build tags
-	Build = "unset"
 )
 
 func init() {
 	utils.Flags.CliVersion = Version
-	utils.Flags.CliBuild = Build
 }
diff --git a/utils/flags.go b/utils/flags.go
index 7d42cdef..2ff89255 100644
--- a/utils/flags.go
+++ b/utils/flags.go
@@ -29,7 +29,6 @@ type WskDeployFlags struct {
 	ApiVersion       string // OpenWhisk version
 	CfgFile          string
 	CliVersion       string
-	CliBuild         string
 	ProjectPath      string
 	DeploymentPath   string
 	ManifestPath     string
diff --git a/wski18n/i18n_resources.go b/wski18n/i18n_resources.go
old mode 100644
new mode 100755


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services