You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/23 04:54:32 UTC

[GitHub] [spark] sarutak commented on pull request #32248: [SPARK-35143][SQL][SHELL]Add default log level config for spark-sql

sarutak commented on pull request #32248:
URL: https://github.com/apache/spark/pull/32248#issuecomment-825385066


   The log level for `spark-shell` is determined [here](https://github.com/apache/spark/blob/4fcbf59079f591dc2214bd16aade340fd380f914/core/src/main/scala/org/apache/spark/internal/Logging.scala#L153).
   Users can change the the log level by `log4j.logger.org.apache.spark.repl.Main` and `log4j.properties.template` contains an example.
   
   On the other hand, the log level for `spark-sql` is determined at the same place as `spark-shell` and users can change the log level by `log4j.logger.org.apache.spark.sql.hive.thriftserver.SparkSQLCLIDriver`. But `log4j.properties.template` contains no example.
   
   So, I think it's reasonable to have an example in `log4j.properties.template` like this PR suggests.
   What do you think? @HyukjinKwon @wangyum 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org