You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Koushik Das <ko...@citrix.com> on 2012/07/31 11:09:51 UTC
Re: Review Request: Fix for CS-15631
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6229/
-----------------------------------------------------------
(Updated July 31, 2012, 9:09 a.m.)
Review request for cloudstack and Abhinandan Prateek.
Description
-------
Support for up to 16 VDIs per VM on XS 6.0 and above (16 VDIs => root + cd + 14 data volumes). Currently in CS number of data disk that can be attached to VM is hard-coded to 6. Made this setting configurable by moving it to hypervisor capabilities. Although XS 6.0 and above supports upto 16 VDIs but while testing on XS 6.0.2 found that only 13 data volumes can be attached to a VM. So for XS 6.0 and 6.0.2 max_data_volumes_limit is set to 13 currently.
Diffs
-----
api/src/com/cloud/api/ApiConstants.java e410576
api/src/com/cloud/api/commands/UpdateHypervisorCapabilitiesCmd.java 3173775
api/src/com/cloud/hypervisor/HypervisorCapabilities.java d0fcf01
api/src/com/cloud/server/ManagementService.java 8dcc398
core/src/com/cloud/hypervisor/HypervisorCapabilitiesVO.java 33cafbc
server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDao.java c7fb969
server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java 8feeba5
server/src/com/cloud/server/ManagementServerImpl.java bcdafa9
server/src/com/cloud/vm/UserVmManagerImpl.java 649e215
setup/db/create-schema.sql ae5f581
setup/db/db/schema-303to40.sql 01710b1
Diff: https://reviews.apache.org/r/6229/diff/
Testing
-------
Verified on XS 6.0.2
Thanks,
Koushik Das
Re: Review Request: Fix for CS-15631
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6229/#review9638
-----------------------------------------------------------
server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java
<https://reviews.apache.org/r/6229/#comment20539>
A comment would be useful here.
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/6229/#comment20540>
Can you please not update this param since this is a hard limit by the hypervisor ?
setup/db/create-schema.sql
<https://reviews.apache.org/r/6229/#comment20541>
Did you file a bug with XS that 13 is a limit since the users of CS might get confused why this being the limit instead of 14?
- Nitin Mehta
On July 31, 2012, 9:09 a.m., Koushik Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6229/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 9:09 a.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Support for up to 16 VDIs per VM on XS 6.0 and above (16 VDIs => root + cd + 14 data volumes). Currently in CS number of data disk that can be attached to VM is hard-coded to 6. Made this setting configurable by moving it to hypervisor capabilities. Although XS 6.0 and above supports upto 16 VDIs but while testing on XS 6.0.2 found that only 13 data volumes can be attached to a VM. So for XS 6.0 and 6.0.2 max_data_volumes_limit is set to 13 currently.
>
>
> Diffs
> -----
>
> api/src/com/cloud/api/ApiConstants.java e410576
> api/src/com/cloud/api/commands/UpdateHypervisorCapabilitiesCmd.java 3173775
> api/src/com/cloud/hypervisor/HypervisorCapabilities.java d0fcf01
> api/src/com/cloud/server/ManagementService.java 8dcc398
> core/src/com/cloud/hypervisor/HypervisorCapabilitiesVO.java 33cafbc
> server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDao.java c7fb969
> server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java 8feeba5
> server/src/com/cloud/server/ManagementServerImpl.java bcdafa9
> server/src/com/cloud/vm/UserVmManagerImpl.java 649e215
> setup/db/create-schema.sql ae5f581
> setup/db/db/schema-303to40.sql 01710b1
>
> Diff: https://reviews.apache.org/r/6229/diff/
>
>
> Testing
> -------
>
> Verified on XS 6.0.2
>
>
> Thanks,
>
> Koushik Das
>
>
Re: Review Request: Fix for CS-15631
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6229/
-----------------------------------------------------------
(Updated Aug. 1, 2012, 8:33 a.m.)
Review request for cloudstack and Abhinandan Prateek.
Changes
-------
Whitespace/tab fixes.
Fixing update script to diable safe update, perform table update and re-enable it back.
Description
-------
Support for up to 16 VDIs per VM on XS 6.0 and above (16 VDIs => root + cd + 14 data volumes). Currently in CS number of data disk that can be attached to VM is hard-coded to 6. Made this setting configurable by moving it to hypervisor capabilities. Although XS 6.0 and above supports upto 16 VDIs but while testing on XS 6.0.2 found that only 13 data volumes can be attached to a VM. So for XS 6.0 and 6.0.2 max_data_volumes_limit is set to 13 currently.
Diffs (updated)
-----
api/src/com/cloud/hypervisor/HypervisorCapabilities.java d0fcf01
core/src/com/cloud/hypervisor/HypervisorCapabilitiesVO.java 33cafbc
server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDao.java c7fb969
server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java 8feeba5
server/src/com/cloud/vm/UserVmManagerImpl.java 649e215
setup/db/create-schema.sql ae5f581
setup/db/db/schema-303to40.sql 01710b1
Diff: https://reviews.apache.org/r/6229/diff/
Testing
-------
Verified on XS 6.0.2
Thanks,
Koushik Das
Re: Review Request: Fix for CS-15631
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6229/#review9641
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On July 31, 2012, 1 p.m., Koushik Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6229/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 1 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Support for up to 16 VDIs per VM on XS 6.0 and above (16 VDIs => root + cd + 14 data volumes). Currently in CS number of data disk that can be attached to VM is hard-coded to 6. Made this setting configurable by moving it to hypervisor capabilities. Although XS 6.0 and above supports upto 16 VDIs but while testing on XS 6.0.2 found that only 13 data volumes can be attached to a VM. So for XS 6.0 and 6.0.2 max_data_volumes_limit is set to 13 currently.
>
>
> Diffs
> -----
>
> api/src/com/cloud/hypervisor/HypervisorCapabilities.java d0fcf01
> core/src/com/cloud/hypervisor/HypervisorCapabilitiesVO.java 33cafbc
> server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDao.java c7fb969
> server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java 8feeba5
> server/src/com/cloud/vm/UserVmManagerImpl.java 649e215
> setup/db/create-schema.sql ae5f581
> setup/db/db/schema-303to40.sql 01710b1
>
> Diff: https://reviews.apache.org/r/6229/diff/
>
>
> Testing
> -------
>
> Verified on XS 6.0.2
>
>
> Thanks,
>
> Koushik Das
>
>
Re: Review Request: Fix for CS-15631
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6229/
-----------------------------------------------------------
(Updated July 31, 2012, 1 p.m.)
Review request for cloudstack and Abhinandan Prateek.
Changes
-------
Did you file a bug with XS that 13 is a limit since the users of CS might get confused why this being the limit instead of 14?
>> Following up with XenServer team on this.
Description
-------
Support for up to 16 VDIs per VM on XS 6.0 and above (16 VDIs => root + cd + 14 data volumes). Currently in CS number of data disk that can be attached to VM is hard-coded to 6. Made this setting configurable by moving it to hypervisor capabilities. Although XS 6.0 and above supports upto 16 VDIs but while testing on XS 6.0.2 found that only 13 data volumes can be attached to a VM. So for XS 6.0 and 6.0.2 max_data_volumes_limit is set to 13 currently.
Diffs (updated)
-----
api/src/com/cloud/hypervisor/HypervisorCapabilities.java d0fcf01
core/src/com/cloud/hypervisor/HypervisorCapabilitiesVO.java 33cafbc
server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDao.java c7fb969
server/src/com/cloud/hypervisor/dao/HypervisorCapabilitiesDaoImpl.java 8feeba5
server/src/com/cloud/vm/UserVmManagerImpl.java 649e215
setup/db/create-schema.sql ae5f581
setup/db/db/schema-303to40.sql 01710b1
Diff: https://reviews.apache.org/r/6229/diff/
Testing
-------
Verified on XS 6.0.2
Thanks,
Koushik Das