[GitHub] [helix] narendly commented on a change in pull request #580: Fix NullPointerException in TestBatchMessage.

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #580: Fix NullPointerException in TestBatchMessage.
URL: https://github.com/apache/helix/pull/580#discussion_r345441241
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/integration/messaging/TestBatchMessage.java
 ##########
 @@ -45,13 +45,16 @@
 
 public class TestBatchMessage extends ZkTestBase {
   class TestZkChildListener implements IZkChildListener {
-    int _maxNbOfChilds = 0;
+    int _maxNumberOfChildren = 0;
 
     @Override
-    public void handleChildChange(String parentPath, List<String> currentChilds) throws Exception {
-      System.out.println(parentPath + " has " + currentChilds.size() + " messages");
-      if (currentChilds.size() > _maxNbOfChilds) {
-        _maxNbOfChilds = currentChilds.size();
+    public void handleChildChange(String parentPath, List<String> currentChildren) {
+      if (currentChildren == null) {
 
 Review comment:
   Is this an issue in production code?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org