You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2023/01/15 11:20:41 UTC

[GitHub] [camel] simon-ras opened a new pull request, #9108: CAMEL-18780: Prevent blocking sqs consumer when using message extend

simon-ras opened a new pull request, #9108:
URL: https://github.com/apache/camel/pull/9108

   # Description
   When using message extending feature together with Threads EIP, it was possible to completely block the consumer (deadlock) if the message extend executor task queue would be filled up.
   
   This could be triggered by the default threads profile where the message queue size is set to 1000 tasks.
   
   On default settings, the consumer would consume: `max queue size`+`max threads`+`consumer thread` = 1000+20+1 concurrent tasks. The extender queue size however is only 1000. The `consumer thread` is due to `CallerRuns` policy.
   
   There is no way to register that the consumer is called from a route which uses threads EIP, and thus we have two options for preventing this blocking behavior. Either increase the maxQueue size to something very high - or make it unbound.
   
   I went with the latter as I believe it to be safe as the queue will be constrained by the thread profile of the route at all times and thus cannot grow unbounded, except if the outer profile is configured without a limit.
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful subject line and body.
   
   <!--  
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   -->
   
   - [x] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
   
   <!-- 
   You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
   
   You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #9108: CAMEL-18780: Prevent blocking sqs consumer when using message extend

Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #9108:
URL: https://github.com/apache/camel/pull/9108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9108: CAMEL-18780: Prevent blocking sqs consumer when using message extend

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9108:
URL: https://github.com/apache/camel/pull/9108#issuecomment-1383123760

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9108: CAMEL-18780: Prevent blocking sqs consumer when using message extend

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9108:
URL: https://github.com/apache/camel/pull/9108#issuecomment-1383136995

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 0 | 1 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org