You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/14 19:46:06 UTC
[GitHub] [spark] MaxGekk opened a new pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
MaxGekk opened a new pull request #32176:
URL: https://github.com/apache/spark/pull/32176
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
By running the existing test suites:
```
$ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z timestamp.sql"
$ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z datetime.sql"
$ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z date.sql"
$ build/sbt "sql/testOnly *SQLQueryTestSuite -- -z interval.sql"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-819811279
**[Test build #137371 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137371/testReport)** for PR 32176 at commit [`8cab0f0`](https://github.com/apache/spark/commit/8cab0f046320d6963353ec7a88da8ab5dbcd9091).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820653164
**[Test build #137439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137439/testReport)** for PR 32176 at commit [`4d36071`](https://github.com/apache/spark/commit/4d360715e24e38d36e1629ce9f7a81cb0acb604e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820642262
**[Test build #753047131](https://github.com/MaxGekk/spark/actions/runs/753047131)** for PR 32176 at commit [`4d36071`](https://github.com/MaxGekk/spark/commit/4d360715e24e38d36e1629ce9f7a81cb0acb604e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820749930
**[Test build #137446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137446/testReport)** for PR 32176 at commit [`94a5a98`](https://github.com/apache/spark/commit/94a5a98064c0f0fbb4df7fb49b8cc981690f8313).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820414548
In this PR, I enabled parsing literals as ANSI intervals instead of the existing CalendarIntervalType. This affects many tests in fact. @cloud-fan @yaooqinn @AngersZhuuuu @HyukjinKwon @maropu @dongjoon-hyun Could you help me to review the changes, please. Maybe need to enable legacy interval in some places. This PR is still a draft - need to fix much more tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820439084
> > Do we need to change typed construct too?
>
> Yep. Need to change this too. I just started from the small change in `visitInterval` but this already leads to significant changes in tests.
Yea, after this done, we can start that part.
One thing confused me a lot. Why we not implement DayTimeInterval/YearMonthInterval first but add a CalendarInterval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820283190
**[Test build #137405 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137405/testReport)** for PR 32176 at commit [`a408ab9`](https://github.com/apache/spark/commit/a408ab91d1a40cf098a73e2c7958d3338de47bef).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614064240
##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/datetime.sql.out
##########
@@ -291,49 +291,47 @@ select timestamp '2019-01-01中文'
-- !query
select timestamp'2011-11-11 11:11:11' + interval '2' day
-- !query schema
-struct<TIMESTAMP '2011-11-11 11:11:11' + INTERVAL '2 days':timestamp>
+struct<TIMESTAMP '2011-11-11 11:11:11' + 172800000000:timestamp>
Review comment:
`Literal.toString` or/and `Literal.sql` should support new intervals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r613838550
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkMetadataOperationSuite.scala
##########
@@ -355,6 +356,8 @@ class SparkMetadataOperationSuite extends HiveThriftServer2TestBase {
val ddl = s"CREATE GLOBAL TEMP VIEW $viewName as select interval 1 day as i"
withJdbcStatement(viewName) { statement =>
+ val legacyIntervalEnabled = SQLConf.get.legacyIntervalEnabled
+ statement.execute(s"SET ${SQLConf.LEGACY_INTERVAL_ENABLED.key}=true")
Review comment:
Opened SPARK-35085 to have the same tests for ANSI intervals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614093733
##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/datetime.sql.out
##########
@@ -291,49 +291,47 @@ select timestamp '2019-01-01中文'
-- !query
select timestamp'2011-11-11 11:11:11' + interval '2' day
-- !query schema
-struct<TIMESTAMP '2011-11-11 11:11:11' + INTERVAL '2 days':timestamp>
+struct<TIMESTAMP '2011-11-11 11:11:11' + 172800000000:timestamp>
Review comment:
shall we fix it first? otherwise the changes here are hard to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820514096
**[Test build #137419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137419/testReport)** for PR 32176 at commit [`0d45567`](https://github.com/apache/spark/commit/0d4556708b740aaa83e1e1596c22da7da7fb7b03).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820284718
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137405/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820530474
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137419/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-819816071
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614097677
##########
File path: sql/core/src/test/resources/sql-tests/results/extract.sql.out
##########
@@ -7,311 +7,355 @@ CREATE TEMPORARY VIEW t AS select '2011-05-06 07:08:09.1234567' as c, interval 1
-- !query schema
struct<>
-- !query output
+org.apache.spark.sql.catalyst.parser.ParseException
+Mixing of year-month and day-time fields is not allowed. Set 'spark.sql.legacy.interval.enabled' to true to enable the legacy interval type which supports mixed fields.(line 1, pos 70)
+
+== SQL ==
+CREATE TEMPORARY VIEW t AS select '2011-05-06 07:08:09.1234567' as c, interval 10 year 20 month 30 day 40 hour 50 minute 6.7890 second as i
Review comment:
This whole test file is broken. Can we update the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820204524
**[Test build #137405 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137405/testReport)** for PR 32176 at commit [`a408ab9`](https://github.com/apache/spark/commit/a408ab91d1a40cf098a73e2c7958d3338de47bef).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614648745
##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/datetime.sql.out
##########
@@ -291,49 +291,47 @@ select timestamp '2019-01-01中文'
-- !query
select timestamp'2011-11-11 11:11:11' + interval '2' day
-- !query schema
-struct<TIMESTAMP '2011-11-11 11:11:11' + INTERVAL '2 days':timestamp>
+struct<TIMESTAMP '2011-11-11 11:11:11' + 172800000000:timestamp>
Review comment:
Merged the PR, rebased this PR and re-generated expected test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821021005
> > Do we need to change typed construct too?
>
> @AngersZhuuuu I have changed the interval's typed constructor too.
Current code has been changed a lot, I think it can be separated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614061179
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -2502,12 +2503,17 @@ case class Flatten(child: Expression) extends UnaryExpression with NullIntoleran
[1,2,3,4,5]
> SELECT _FUNC_(5, 1);
[5,4,3,2,1]
+ > SET spark.sql.legacy.interval.enabled=true;
+ spark.sql.legacy.interval.enabled true
Review comment:
Created JIRA SPARK-35088 for ANSI intervals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820332515
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137406/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #32176:
URL: https://github.com/apache/spark/pull/32176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820867952
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137446/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821005152
> Do we need to change typed construct too?
@AngersZhuuuu I have changed the interval's typed constructor too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614094953
##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out
##########
@@ -13,9 +13,15 @@ struct<multiplydtinterval(subtracttimestamps(TIMESTAMP '2019-10-15 10:11:12.0010
-- !query
Review comment:
shall we run `interval.sql` one more time with legacy config enabled? by using `--IMPORT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820239577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614061798
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -2410,17 +2411,22 @@ object DatePart {
224
> SELECT _FUNC_('SECONDS', timestamp'2019-10-01 00:00:01.000001');
1.000001
+ > SET spark.sql.legacy.interval.enabled=true;
+ spark.sql.legacy.interval.enabled true
Review comment:
Created SPARK-35091 to support ANSI intervals by `date_part()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820204524
**[Test build #137405 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137405/testReport)** for PR 32176 at commit [`a408ab9`](https://github.com/apache/spark/commit/a408ab91d1a40cf098a73e2c7958d3338de47bef).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-819865913
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41949/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820203760
**[Test build #751205192](https://github.com/MaxGekk/spark/actions/runs/751205192)** for PR 32176 at commit [`a408ab9`](https://github.com/MaxGekk/spark/commit/a408ab91d1a40cf098a73e2c7958d3338de47bef).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614096789
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2306,12 +2307,24 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
}
/**
- * Create a [[CalendarInterval]] literal expression. Two syntaxes are supported:
+ * Create a [[CalendarInterval]] or ANSI interval literal expression.
+ * Two syntaxes are supported:
* - multiple unit value pairs, for instance: interval 2 months 2 days.
* - from-to unit, for instance: interval '1-2' year to month.
*/
override def visitInterval(ctx: IntervalContext): Literal = withOrigin(ctx) {
- Literal(parseIntervalLiteral(ctx), CalendarIntervalType)
+ val parsedInterval = parseIntervalLiteral(ctx)
+ if (SQLConf.get.legacyIntervalEnabled) {
Review comment:
nit: `conf. legacyIntervalEnabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820497120
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41995/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820412310
**[Test build #752131577](https://github.com/MaxGekk/spark/actions/runs/752131577)** for PR 32176 at commit [`0d45567`](https://github.com/MaxGekk/spark/commit/0d4556708b740aaa83e1e1596c22da7da7fb7b03).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614303863
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
##########
@@ -47,6 +48,10 @@ abstract class StreamingJoinSuite
StateStore.stop()
}
+ override protected def sparkConf = super.sparkConf
+ // TODO(SPARK-35095): Use ANSI intervals in streaming join tests
Review comment:
For some reasons, `CalendarInterval` is used in the streaming code. For instance at
https://github.com/apache/spark/blob/0945baf90660a101ae0f86a39d4c91ca74ae5ee3/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala#L89-L91
Need to revise the code. The streaming tests fails on new ANSI intervals at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614061798
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -2410,17 +2411,22 @@ object DatePart {
224
> SELECT _FUNC_('SECONDS', timestamp'2019-10-01 00:00:01.000001');
1.000001
+ > SET spark.sql.legacy.interval.enabled=true;
+ spark.sql.legacy.interval.enabled true
Review comment:
SPARK-35090 for ANSI intervals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820772683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821110016
This PR has been already big enough. I think of to split it to smaller PRs. This should help to review changes. First of all, I would like to support only parsing of interval literals in ANSI style to ANSI intervals like:
- INTERVAL '1-1' YEAR TO MONTH -> YearMonthIntervalType
- INTERVAL '1 10:11:12' DAY TO SECOND -> DayTimeIntervalType
and don't touch typed literal expressions and interval literals in Postgres style (multi units intervals).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614100082
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala
##########
@@ -367,4 +368,10 @@ object QueryParsingErrors {
new ParseException("LOCAL is supported only with file: scheme", ctx)
}
+ def mixedIntervalError(ctx: IntervalContext): Throwable = {
+ new ParseException(
+ "Mixing of year-month and day-time fields is not allowed. " +
Review comment:
Does ANSI allow mixing daytime interval with same unit e.g. `day` and `day`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821088570
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137476/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821002923
**[Test build #754899039](https://github.com/MaxGekk/spark/actions/runs/754899039)** for PR 32176 at commit [`de06515`](https://github.com/MaxGekk/spark/commit/de065155c2ba023655b94f2ed9f9cf7749ac856f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821108423
**[Test build #755434573](https://github.com/MaxGekk/spark/actions/runs/755434573)** for PR 32176 at commit [`7668405`](https://github.com/MaxGekk/spark/commit/7668405ebd902cea698b76c373d0c06b1e759426).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820239619
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41981/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821118454
**[Test build #137487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137487/testReport)** for PR 32176 at commit [`7668405`](https://github.com/apache/spark/commit/7668405ebd902cea698b76c373d0c06b1e759426).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820331741
**[Test build #137406 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137406/testReport)** for PR 32176 at commit [`e4a4776`](https://github.com/apache/spark/commit/e4a4776aa3783ca273cf3d348fc41a52a42bc7bb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class PandasOnSparkFrameMethods(object):`
* `class PandasOnSparkSeriesMethods(object):`
* `class PandasOnSparkPlotAccessor(PandasObject):`
* `class PandasOnSparkBarPlot(PandasBarPlot, TopNPlotBase):`
* `class PandasOnSparkBoxPlot(PandasBoxPlot, BoxPlotBase):`
* `class PandasOnSparkHistPlot(PandasHistPlot, HistogramPlotBase):`
* `class PandasOnSparkPiePlot(PandasPiePlot, TopNPlotBase):`
* `class PandasOnSparkAreaPlot(PandasAreaPlot, SampledPlotBase):`
* `class PandasOnSparkLinePlot(PandasLinePlot, SampledPlotBase):`
* `class PandasOnSparkBarhPlot(PandasBarhPlot, TopNPlotBase):`
* `class PandasOnSparkScatterPlot(PandasScatterPlot, TopNPlotBase):`
* `class PandasOnSparkKdePlot(PandasKdePlot, KdePlotBase):`
* `class PandasOnSparkUsageLogger(object):`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820209002
**[Test build #137406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137406/testReport)** for PR 32176 at commit [`e4a4776`](https://github.com/apache/spark/commit/e4a4776aa3783ca273cf3d348fc41a52a42bc7bb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821022576
**[Test build #137476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137476/testReport)** for PR 32176 at commit [`de06515`](https://github.com/apache/spark/commit/de065155c2ba023655b94f2ed9f9cf7749ac856f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614062378
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -2475,17 +2482,22 @@ case class DatePart(field: Expression, source: Expression, child: Expression)
224
> SELECT _FUNC_(SECONDS FROM timestamp'2019-10-01 00:00:01.000001');
1.000001
+ > SET spark.sql.legacy.interval.enabled=true;
Review comment:
Created SPARK-35091 to support ANSI intervals by `date_part()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820679052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820241333
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41983/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-819787760
**[Test build #137371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137371/testReport)** for PR 32176 at commit [`8cab0f0`](https://github.com/apache/spark/commit/8cab0f046320d6963353ec7a88da8ab5dbcd9091).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614101981
##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out
##########
@@ -106,9 +112,15 @@ struct<(- INTERVAL '-1 months 1 days -1 seconds'):interval>
-- !query
select -interval -1 month 1 day -1 second
-- !query schema
-struct<(- INTERVAL '-1 months 1 days -1 seconds'):interval>
Review comment:
Is multi-value-unit interval itself non-ANSI, so why its result shall be an ANSI interval?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820419793
Do we need to change typed construct too? current 'interval' xx will be constructed as CalendarInterval, according to your PR, I think we need to change this logic too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821056640
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42052/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-819817883
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41949/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820867952
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137446/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821088570
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137476/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-819841199
**[Test build #749563302](https://github.com/MaxGekk/spark/actions/runs/749563302)** for PR 32176 at commit [`8cab0f0`](https://github.com/MaxGekk/spark/commit/8cab0f046320d6963353ec7a88da8ab5dbcd9091).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821148168
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42062/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614347285
##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/datetime.sql.out
##########
@@ -291,49 +291,47 @@ select timestamp '2019-01-01中文'
-- !query
select timestamp'2011-11-11 11:11:11' + interval '2' day
-- !query schema
-struct<TIMESTAMP '2011-11-11 11:11:11' + INTERVAL '2 days':timestamp>
+struct<TIMESTAMP '2011-11-11 11:11:11' + 172800000000:timestamp>
Review comment:
Here is the PR for this: https://github.com/apache/spark/pull/32196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820497120
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41995/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820241333
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41983/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820769113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821022576
**[Test build #137476 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137476/testReport)** for PR 32176 at commit [`de06515`](https://github.com/apache/spark/commit/de065155c2ba023655b94f2ed9f9cf7749ac856f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614097085
##########
File path: sql/core/src/test/resources/sql-tests/results/cast.sql.out
##########
@@ -286,9 +286,15 @@ struct<CAST(interval 3 month 1 hour AS INTERVAL):interval>
-- !query
SELECT CAST(interval 3 month 1 hour AS string)
-- !query schema
-struct<CAST(INTERVAL '3 months 1 hours' AS STRING):string>
Review comment:
The intention of this test is not to check mixed fields. How about we update the test to use year-month and day-time interval literals?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820431983
**[Test build #137419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137419/testReport)** for PR 32176 at commit [`0d45567`](https://github.com/apache/spark/commit/0d4556708b740aaa83e1e1596c22da7da7fb7b03).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614096789
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2306,12 +2307,24 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
}
/**
- * Create a [[CalendarInterval]] literal expression. Two syntaxes are supported:
+ * Create a [[CalendarInterval]] or ANSI interval literal expression.
+ * Two syntaxes are supported:
* - multiple unit value pairs, for instance: interval 2 months 2 days.
* - from-to unit, for instance: interval '1-2' year to month.
*/
override def visitInterval(ctx: IntervalContext): Literal = withOrigin(ctx) {
- Literal(parseIntervalLiteral(ctx), CalendarIntervalType)
+ val parsedInterval = parseIntervalLiteral(ctx)
+ if (SQLConf.get.legacyIntervalEnabled) {
Review comment:
nit: `conf.legacyIntervalEnabled`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821559803
Please, review https://github.com/apache/spark/pull/32209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820749930
**[Test build #137446 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137446/testReport)** for PR 32176 at commit [`94a5a98`](https://github.com/apache/spark/commit/94a5a98064c0f0fbb4df7fb49b8cc981690f8313).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820466088
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41995/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r613837850
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala
##########
@@ -362,11 +362,13 @@ class SparkThriftServerProtocolVersionsSuite extends HiveThriftServer2TestBase {
}
test(s"$version get interval type") {
- testExecuteStatementWithProtocolVersion(version, "SELECT interval '1' year '2' day") { rs =>
+ testExecuteStatementWithProtocolVersion(
+ version,
+ "SELECT CAST('1 year 2 day' AS INTERVAL) AS icol") { rs =>
Review comment:
I wasn't able to set the config in the test. So, have to use the Cast expression to get the legacy interval column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r613839136
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -664,9 +664,12 @@ class HiveThriftBinaryServerSuite extends HiveThriftServer2Test {
test("Support interval type") {
withJdbcStatement() { statement =>
+ val legacyIntervalEnabled = SQLConf.get.legacyIntervalEnabled
+ statement.execute(s"SET ${SQLConf.LEGACY_INTERVAL_ENABLED.key}=true")
Review comment:
Opened SPARK-35086 for ANSI intervals
##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##########
@@ -683,6 +686,8 @@ class HiveThriftBinaryServerSuite extends HiveThriftServer2Test {
val ddl1 = s"CREATE GLOBAL TEMP VIEW $viewName1 AS SELECT INTERVAL 1 DAY AS i"
val ddl2 = s"CREATE TEMP VIEW $viewName2 as select * from global_temp.$viewName1"
withJdbcStatement(viewName1, viewName2) { statement =>
+ val legacyIntervalEnabled = SQLConf.get.legacyIntervalEnabled
+ statement.execute(s"SET ${SQLConf.LEGACY_INTERVAL_ENABLED.key}=true")
Review comment:
Opened SPARK-35086 for ANSI intervals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820424044
> Do we need to change typed construct too?
Yep. Need to change this too. I just started from the small change in `visitInterval` but this already leads to significant changes in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820685925
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42014/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820685925
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42014/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820761873
**[Test build #137439 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137439/testReport)** for PR 32176 at commit [`4d36071`](https://github.com/apache/spark/commit/4d360715e24e38d36e1629ce9f7a81cb0acb604e).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821188376
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137487/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820284718
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137405/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820653164
**[Test build #137439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137439/testReport)** for PR 32176 at commit [`4d36071`](https://github.com/apache/spark/commit/4d360715e24e38d36e1629ce9f7a81cb0acb604e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821148168
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42062/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-819816071
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137371/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821055665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821144796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821177001
**[Test build #137487 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137487/testReport)** for PR 32176 at commit [`7668405`](https://github.com/apache/spark/commit/7668405ebd902cea698b76c373d0c06b1e759426).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820209002
**[Test build #137406 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137406/testReport)** for PR 32176 at commit [`e4a4776`](https://github.com/apache/spark/commit/e4a4776aa3783ca273cf3d348fc41a52a42bc7bb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820241299
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41983/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820431983
**[Test build #137419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137419/testReport)** for PR 32176 at commit [`0d45567`](https://github.com/apache/spark/commit/0d4556708b740aaa83e1e1596c22da7da7fb7b03).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821118454
**[Test build #137487 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137487/testReport)** for PR 32176 at commit [`7668405`](https://github.com/apache/spark/commit/7668405ebd902cea698b76c373d0c06b1e759426).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614098232
##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/datetime.sql.out
##########
@@ -291,49 +291,47 @@ select timestamp '2019-01-01中文'
-- !query
select timestamp'2011-11-11 11:11:11' + interval '2' day
-- !query schema
-struct<TIMESTAMP '2011-11-11 11:11:11' + INTERVAL '2 days':timestamp>
+struct<TIMESTAMP '2011-11-11 11:11:11' + 172800000000:timestamp>
Review comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r614258155
##########
File path: sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out
##########
@@ -106,9 +112,15 @@ struct<(- INTERVAL '-1 months 1 days -1 seconds'):interval>
-- !query
select -interval -1 month 1 day -1 second
-- !query schema
-struct<(- INTERVAL '-1 months 1 days -1 seconds'):interval>
Review comment:
In the future (I hope in the near future), we will get rid off `CalendarIntervalType`. If we are going to support multi-value-unit interval, we should be able to parse them to ANSI intervals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820739127
**[Test build #753477078](https://github.com/MaxGekk/spark/actions/runs/753477078)** for PR 32176 at commit [`94a5a98`](https://github.com/MaxGekk/spark/commit/94a5a98064c0f0fbb4df7fb49b8cc981690f8313).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820772683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821056640
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42052/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820856496
**[Test build #137446 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137446/testReport)** for PR 32176 at commit [`94a5a98`](https://github.com/apache/spark/commit/94a5a98064c0f0fbb4df7fb49b8cc981690f8313).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` case class DummyLeafNode() extends LeafNode `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821188376
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137487/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820208300
**[Test build #751221896](https://github.com/MaxGekk/spark/actions/runs/751221896)** for PR 32176 at commit [`e4a4776`](https://github.com/MaxGekk/spark/commit/e4a4776aa3783ca273cf3d348fc41a52a42bc7bb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-819787760
**[Test build #137371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137371/testReport)** for PR 32176 at commit [`8cab0f0`](https://github.com/apache/spark/commit/8cab0f046320d6963353ec7a88da8ab5dbcd9091).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820530474
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137419/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-821074366
**[Test build #137476 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137476/testReport)** for PR 32176 at commit [`de06515`](https://github.com/apache/spark/commit/de065155c2ba023655b94f2ed9f9cf7749ac856f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-819865913
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41949/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820239619
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41981/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820497092
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41995/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-819836637
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41949/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32176:
URL: https://github.com/apache/spark/pull/32176#issuecomment-820332515
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137406/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org