You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Jiashu-Hu (via GitHub)" <gi...@apache.org> on 2025/03/31 22:58:33 UTC
[PR] update note [datafusion]
Jiashu-Hu opened a new pull request, #15515:
URL: https://github.com/apache/datafusion/pull/15515
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- [Closes #15464](https://github.com/apache/datafusion/issues/15464).
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
The Decimal support in DataFusion was marked as complete in [Issue #3523](https://github.com/apache/datafusion/issues/3523) on November 21, 2024. However, the user guide documentation (`docs/source/user-guide/sql/data_types.md`) still labels it as "experimental," which is outdated and misleading. This PR updates the documentation to reflect the current status, improving user understanding and trust in the Decimal functionality.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Updated the `Numeric Types` section in `docs/source/user-guide/sql/data_types.md` to remove the "experimental" label for `DECIMAL(precision, scale)`.
- Replaced the note with: "Decimal support has been fully implemented“
- Retained the link to #3523 for historical context.
## Are these changes tested?
No tests are included in this PR because it only modifies documentation
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
Yes, this PR updates the user-facing documentation at `https://datafusion.apache.org/user-guide/sql/data_types.html`. It clarifies that Decimal support is fully implemented, removing the outdated "experimental" label. No code or API changes are involved.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update user guide to note decimal is not experimental anymore [datafusion]
Posted by "Jiashu-Hu (via GitHub)" <gi...@apache.org>.
Jiashu-Hu commented on PR #15515:
URL: https://github.com/apache/datafusion/pull/15515#issuecomment-2769972669
> Thanks @Jiashu-Hu
>
> I don't think we even need to note that Decimal is complete (it is implied by its presence on this table)
>
> Would you be willing to remove the entire `Notes` column?
Thank you for your review! I have removed the item as you suggested and committed the latest version.
It appears that the shutdown of "GitHub Cache Storage" is causing the CI to fail. I believe we may need to update the `sccache` configuration to get it running again.
<img width="721" alt="image" src="https://github.com/user-attachments/assets/fee178fd-69d7-4cdb-a016-287bdeeddc58" />
official documentation: https://gh.io/gha-cache-sunset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update user guide to note decimal is not experimental anymore [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #15515:
URL: https://github.com/apache/datafusion/pull/15515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update user guide to note decimal is not experimental anymore [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #15515:
URL: https://github.com/apache/datafusion/pull/15515#issuecomment-2770283801
@Omega359 fixed this in the following PR I believe:
- https://github.com/apache/datafusion/pull/15536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org