You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2020/03/01 00:58:14 UTC
[GitHub] [maven-doxia] minfrin opened a new pull request #19: [DOXIA-607]
Add support for Xhtml5 keygen tag
minfrin opened a new pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19
This will allow maven generated documentation to include a demo of the keygen tag, as with other form elements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-doxia] michael-o commented on a change in pull request #19:
[DOXIA-607] Add support for Xhtml5 keygen tag
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#discussion_r386105109
##########
File path: doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java
##########
@@ -473,6 +473,17 @@ public String toString()
/** Xhtml tag for <code>kbd</code>. */
Tag KBD = Tag.KBD;
+ /** Html5 tag for <code>keygen</code>. */
Review comment:
It is actually HTML5. See https://html.spec.whatwg.org/multipage/introduction.html#is-this-html5?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-doxia] elharo commented on a change in pull request #19:
[DOXIA-607] Add support for Xhtml5 keygen tag
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#discussion_r386104912
##########
File path: doxia-core/src/main/java/org/apache/maven/doxia/markup/HtmlMarkup.java
##########
@@ -473,6 +473,17 @@ public String toString()
/** Xhtml tag for <code>kbd</code>. */
Tag KBD = Tag.KBD;
+ /** Html5 tag for <code>keygen</code>. */
Review comment:
Html5 --> HTML 5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-doxia] minfrin commented on issue #19: [DOXIA-607] Add
support for Xhtml5 keygen tag
Posted by GitBox <gi...@apache.org>.
minfrin commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593088806
The tag is a formal part of the html5 spec as follows: https://www.w3.org/TR/2014/REC-html5-20141028/single-page.html#the-keygen-element
The need to both document and provide examples of the tag in use is in an attempt to bring the tag up to date with respect to current crypto standards. Not being able to include the tag in doxia generated documentation is making our lives hard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-doxia] michael-o commented on issue #19: [DOXIA-607] Add
support for Xhtml5 keygen tag
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593093142
Surprinsingly, the most recent version does not mention a deprecation: https://html.spec.whatwg.org/#keygen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-doxia] asfgit closed pull request #19: [DOXIA-607] Add
support for Xhtml5 keygen tag
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-doxia] michael-o commented on issue #19: [DOXIA-607] Add
support for Xhtml5 keygen tag
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593087315
Mozilla says this is obsolete: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/keygen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-doxia] michael-o commented on issue #19: [DOXIA-607] Add
support for Xhtml5 keygen tag
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #19: [DOXIA-607] Add support for Xhtml5 keygen tag
URL: https://github.com/apache/maven-doxia/pull/19#issuecomment-593093527
Branch pushed, awaiting tests...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org