[jira] [Commented] (MAPREDUCE-5708) Duplicate String.format in getSpillFileForWrite

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862379#comment-13862379 ] 

Hadoop QA commented on MAPREDUCE-5708:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12621475/0001-Removed-duplicate-String.format.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4302//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4302//console

This message is automatically generated.

> Duplicate String.format in getSpillFileForWrite
> -----------------------------------------------
>
>                 Key: MAPREDUCE-5708
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Konstantin Weitz
>            Priority: Minor
>         Attachments: 0001-Removed-duplicate-String.format.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The code responsible for formatting the spill file name (namely _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does not only affect performance, but leads to the weird requirement that task attempt ids cannot contain _%_ characters (because these would be interpreted as format specifiers in the outside _String.format_ call).
> I assume this was done by mistake, as it could only be useful if task attempt ids contained _%n_.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)