You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/02 02:52:24 UTC

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15301: [improve][tx] enhance validation when updating transaction topic

Technoboy- commented on code in PR #15301:
URL: https://github.com/apache/pulsar/pull/15301#discussion_r862566175


##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarClusterMetadataSetup.java:
##########
@@ -370,7 +373,7 @@ static void createPartitionedTopic(MetadataStore configStore, TopicName topicNam
             PartitionedTopicMetadata existsMeta = getResult.get();
 
             // Only update metadata if the partitions should be modified
-            if (existsMeta.partitions < numPartitions) {
+            if (existsMeta.partitions < numPartitions && force) {

Review Comment:
   if (force) {
     ....
   } else if (existsMeta.partitions < numPartitions) {
    ...
   }
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org