[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11548: [BEAM-9136] Introduce no-licenses tag

[GitBox <gi...@apache.org>]

Hannah-Jiang commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416735375



##########
File path: sdks/java/container/build.gradle
##########
@@ -101,16 +84,44 @@ docker {
                   project.rootProject["docker-tag"] : project.sdk_version)
   dockerfile project.file("./${dockerfileName}")
   files "./build/"
+  buildArgs(['pull_licenses': !project.rootProject.hasProperty(["no-licenses"])])

Review comment:
       Currently, there are three pull licenses options for Java.
   when docker-pull-licenses is set, licenses are pulled.
   when no-licenses is set, all license pulling related tasks are skipped.
   when no tag is passed, which is default mode, license urls are checked.
   
   With Python, there are two options available.
   with no-licenses tag, license pulling is skipped.
   when no tag is passed, which is default, licenses are pulled.
   
   I agree above settings are confuse, and would like to simplify it and make it consistent between docker images.
   
   So, we will have only one tag, which is docker-pull-licenses.
   when docker-pull-licenses = 1 or true, licenses are pulled.
   when docker-pull-licenses = 0 or false, license related tasks are skipped.
   when docker-pull-licenses = check, license urls are checked.
   Default mode is docker-pull-licenses = check both for Java and Python.
   
   We need to update the script that pull licenses for Python to support checking urls.
   
   Does this sound good?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org