You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/03/04 08:33:47 UTC
[GitHub] [carbondata] jackylk opened a new pull request #3655:
[CARBONDATA-3735] Avoid listing all tables in metastore
jackylk opened a new pull request #3655: [CARBONDATA-3735] Avoid listing all tables in metastore
URL: https://github.com/apache/carbondata/pull/3655
### Why is this PR needed?
In CarbonCreateDataSourceTableCommand.scala, RegisterIndexTableCommand.scala, carbon is trying to list all tables in a database.
It will be slow if there are many tables in the db, thus should be avoided.
### What changes were proposed in this PR?
This PR uses catalog tableExists API instead of listing all tables
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3655:
[CARBONDATA-3735] Avoid listing all tables in metastore
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on issue #3655: [CARBONDATA-3735] Avoid listing all tables in metastore
URL: https://github.com/apache/carbondata/pull/3655#issuecomment-595061878
LGTM
would have handled in #3631 itself
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] niuge01 commented on issue #3655: [CARBONDATA-3735]
Avoid listing all tables in metastore
Posted by GitBox <gi...@apache.org>.
niuge01 commented on issue #3655: [CARBONDATA-3735] Avoid listing all tables in metastore
URL: https://github.com/apache/carbondata/pull/3655#issuecomment-595025748
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3655:
[CARBONDATA-3735] Avoid listing all tables in metastore
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3655: [CARBONDATA-3735] Avoid listing all tables in metastore
URL: https://github.com/apache/carbondata/pull/3655#issuecomment-594432085
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2310/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] asfgit closed pull request #3655: [CARBONDATA-3735]
Avoid listing all tables in metastore
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3655: [CARBONDATA-3735] Avoid listing all tables in metastore
URL: https://github.com/apache/carbondata/pull/3655
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3655:
[CARBONDATA-3735] Avoid listing all tables in metastore
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3655: [CARBONDATA-3735] Avoid listing all tables in metastore
URL: https://github.com/apache/carbondata/pull/3655#issuecomment-594434817
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/603/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services