You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/10 15:10:14 UTC
[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #4972: wqueue: update wqueue to support using wqueue before wqueue start
GUIDINGLI opened a new pull request #4972:
URL: https://github.com/apache/incubator-nuttx/pull/4972
## Summary
wqueue: update wqueue to support using wqueue before wqueue start
## Impact
wqueue
## Testing
VELA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4972: wqueue: update wqueue to support using wqueue before wqueue start
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4972:
URL: https://github.com/apache/incubator-nuttx/pull/4972#discussion_r767508734
##########
File path: include/nuttx/semaphore.h
##########
@@ -36,6 +36,21 @@
* Pre-processor Definitions
****************************************************************************/
+/* Initializers */
+
+#ifdef CONFIG_PRIORITY_INHERITANCE
+# if CONFIG_SEM_PREALLOCHOLDERS > 0
+# define NXSEM_INITIALIZER(c, f) \
+ {(c), (f), NULL} /* semcount, flags, hhead */
+# else
+# define NXSEM_INITIALIZER(c, f) \
+ {(c), (f), {SEMHOLDER_INITIALIZER, SEMHOLDER_INITIALIZER}} /* semcount, flags, holder[2] */
+# endif
+#else
+# define NXSEM_INITIALIZER(c, f) \
Review comment:
let's define:
```
SEM_INITIALIZER(c) NXSEM_INITIALIZER(c, 0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4972: wqueue: update wqueue to support using wqueue before wqueue start
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4972:
URL: https://github.com/apache/incubator-nuttx/pull/4972#discussion_r767518853
##########
File path: include/nuttx/semaphore.h
##########
@@ -36,6 +36,21 @@
* Pre-processor Definitions
****************************************************************************/
+/* Initializers */
+
+#ifdef CONFIG_PRIORITY_INHERITANCE
+# if CONFIG_SEM_PREALLOCHOLDERS > 0
+# define NXSEM_INITIALIZER(c, f) \
+ {(c), (f), NULL} /* semcount, flags, hhead */
Review comment:
align with the comment at line 47 and 51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4972: wqueue: update wqueue to support using wqueue before wqueue start
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #4972:
URL: https://github.com/apache/incubator-nuttx/pull/4972#issuecomment-991229445
@xiaoxiang781216 @GUIDINGLI how is the work queue used before starting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4972: wqueue: update wqueue to support using wqueue before wqueue start
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #4972:
URL: https://github.com/apache/incubator-nuttx/pull/4972#issuecomment-991229445
@xiaoxiang781216 @GUIDINGLI how is the work queue used before starting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4972: wqueue: update wqueue to support using wqueue before wqueue start
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4972:
URL: https://github.com/apache/incubator-nuttx/pull/4972#issuecomment-991476646
> @xiaoxiang781216 @GUIDINGLI how is the work queue used before starting?
up_initialize and board_early_initialize get called before nx_workqueues:
https://github.com/apache/incubator-nuttx/blob/master/sched/init/nx_start.c#L682-L699
Some driver initialize in up_initialize or board_early_initialize may schedule work to the worker thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #4972: wqueue: update wqueue to support using wqueue before wqueue start
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #4972:
URL: https://github.com/apache/incubator-nuttx/pull/4972#issuecomment-991917579
Does it matter that `nxsem_set_protocol(&wqueue->sem, SEM_PRIO_NONE);` is still done in `work_thread_create()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #4972: wqueue: update wqueue to support using wqueue before wqueue start
Posted by GitBox <gi...@apache.org>.
GUIDINGLI commented on pull request #4972:
URL: https://github.com/apache/incubator-nuttx/pull/4972#issuecomment-992208788
> Does it matter that `nxsem_set_protocol(&wqueue->sem, SEM_PRIO_NONE);` is still done in `work_thread_create()`?
add new MARCO `NXSEM_INITIALIZER`, to handle this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4972: wqueue: update wqueue to support using wqueue before wqueue start
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4972:
URL: https://github.com/apache/incubator-nuttx/pull/4972#issuecomment-991476646
> @xiaoxiang781216 @GUIDINGLI how is the work queue used before starting?
up_initialize and board_early_initialize get called before nx_workqueues:
https://github.com/apache/incubator-nuttx/blob/master/sched/init/nx_start.c#L682-L699
Some driver initialize in up_initialize or board_early_initialize may schedule work to the worker thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4972: wqueue: update wqueue to support using wqueue before wqueue start
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4972:
URL: https://github.com/apache/incubator-nuttx/pull/4972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org