You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/06 09:28:38 UTC
[GitHub] [airflow] ashb opened a new pull request, #24865: Fix exception in mini task scheduler.
ashb opened a new pull request, #24865:
URL: https://github.com/apache/airflow/pull/24865
I introduced a bug in 2.3.0 as part of the dynamic task mapping work
that frequently made the mini scheduler fail for tasks involving
XComArgs.
The fix is to alter the logic in BaseOperator's deepcopy to not set the
`__instantiated` flag until all the other attributes are copied.
For background the `__instantiated` flag is use so that when you do
`task.some_attr = an_xcom_arg` the relationships are set appropriately,
but since we are copying all the existing attributes we don't need to do
that, as the relationships will already be set!
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #24865: Fix exception in mini task scheduler.
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #24865:
URL: https://github.com/apache/airflow/pull/24865#issuecomment-1176031353
Looks like a random failure of mysql?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #24865: Fix exception in mini task scheduler.
Posted by GitBox <gi...@apache.org>.
ashb merged PR #24865:
URL: https://github.com/apache/airflow/pull/24865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #24865: Fix exception in mini task scheduler.
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #24865:
URL: https://github.com/apache/airflow/pull/24865#issuecomment-1176034224
Hmm since this is also related to copy behaviorr I kind of wonder if it is actually also the related to that other issue on MappedOperator. But we should be good now anyway after fixing them both now (there’s not a third kind of operator).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org