You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "durgaprasadml (via GitHub)" <gi...@apache.org> on 2026/07/20 16:55:13 UTC
[PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
durgaprasadml opened a new pull request, #42248:
URL: https://github.com/apache/superset/pull/42248
## Description
```markdown
### SUMMARY
Fixes the server pagination page-size selector when the configured **Server Page Length** is greater than the total number of rows.
Previously, the configured page size was filtered out whenever it exceeded the result row count. As a consequence, the selector could incorrectly fall back to `0`, display invalid page-size options, and prevent users from switching back to the configured page size without refreshing the page.
This change:
- Preserves the configured server page size even when it exceeds the current row count.
- Prevents the page-size selector from falling back to an invalid `0` value when no exact match exists.
- Selects the nearest valid page-size option if the configured value is unavailable.
- Adds a regression test covering the scenario where `serverPageLength > rowCount`.
Fixes #42243
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TESTING INSTRUCTIONS
1. Create a standard **Table** chart.
2. Set **Row limit** to `10000`.
3. Enable **Server pagination**.
4. Set **Server Page Length** to `20`.
5. Use a dataset returning **12 rows**.
6. Verify that:
- The page-size selector initially displays **20**.
- The dropdown contains **10** and **20**.
- The dropdown does **not** contain **0**.
7. Change the page size to **10**.
8. Verify that **20** remains available and can be selected again.
9. Verify that server pagination behaves normally for datasets where the row count is greater than the configured page size.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #42243
- [ ] Required feature flags
- [x] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5243941938
Thanks for cleaning those up, @durgaprasadml! One thing left before this is ready to merge: Codeant's thread on `DataTable.tsx` is still open, and it looks valid, the fallback branch can bump the displayed page size without updating what actually gets sent to the server. Worth fixing before we merge this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5034599615
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 034cc5525aae2eea7f595363b4d6a858805bcd50 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a5f726af0829c00089164ef |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-42248--superset-docs-preview.netlify.app](https://deploy-preview-42248--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#FctbCoAgEEDRvcx3kpnZYwctY6qxhFIxiR609-zvcOE-4IPbfIQOIIMhoB2XZG3OPOKwEtspHBSYx9lYjMbZnymbm5gUQpZpm8iv7uqnNCqsdC0Uat6IduScN22hJGl4Pw) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-42248--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #42248:
URL: https://github.com/apache/superset/pull/42248#discussion_r3997103903
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx:
##########
@@ -461,11 +461,20 @@ export default typedMemo(function DataTable<D extends object>({
resultPageCount = 0;
}
resultCurrentPageSize = serverPageSize;
- const foundPageSizeIndex = pageSizeOptions.findIndex(
- ([option]) => option >= resultCurrentPageSize,
+ const exactMatch = pageSizeOptions.some(
+ ([option]) => option === resultCurrentPageSize,
);
- if (foundPageSizeIndex === -1) {
- resultCurrentPageSize = 0;
+ if (!exactMatch) {
+ const nearestOption = pageSizeOptions.find(
+ ([option]) => option >= resultCurrentPageSize,
+ );
+ if (nearestOption) {
+ resultCurrentPageSize = nearestOption[0];
+ } else if (pageSizeOptions.length > 0) {
+ resultCurrentPageSize = pageSizeOptions[pageSizeOptions.length - 1][0];
+ } else {
+ resultCurrentPageSize = 0;
Review Comment:
This is fixed by b966441 ("fix(plugin-chart-table): keep fallback page size in sync with server callback"). Both `resultPageCount` (line 478) and `resultOnPageChange` (line 483-484) now consistently use `resultCurrentPageSize`, the fallback-adjusted value, so the selector and server pagination/page-count no longer desync. Confirmed at current head. Resolving.
##########
superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx:
##########
@@ -2482,6 +2482,47 @@ describe('plugin-chart-table', () => {
);
expect(screen.queryByText('Search by')).toBeInTheDocument();
});
+
+ test('dropdown preserves serverPageLength if larger than rowCount and avoids invalid 0 (#42243)', async () => {
+ const props = transformProps({
+ ...testData.basic,
+ formData: {
+ ...testData.basic.formData,
+ server_pagination: true,
+ },
+ });
+ props.serverPagination = true;
+ props.serverPageLength = 20;
+ props.rowCount = 12;
+ props.data = Array.from({ length: 12 }, (_, i) => ({
+ name: `Row ${i}`,
+ })) as any;
+
+ const { container } = render(
+ <ProviderWrapper>
+ <TableChart {...props} sticky={false} />
+ </ProviderWrapper>,
+ );
+
+ // Initial page size selector text
+ const pageSizeSelector = container.querySelector('.dt-select-page-size');
+ expect(pageSizeSelector).toHaveTextContent('20');
+
+ // Open dropdown to check options
+ const selectTrigger = container.querySelector('.ant-select-selector');
+ if (selectTrigger) {
+ fireEvent.mouseDown(selectTrigger);
+
+ await waitFor(() => {
+ const options = screen.getAllByRole('option');
+ const optionTexts = options.map(opt => opt.textContent);
+ expect(optionTexts).toContain('10');
+ expect(optionTexts).toContain('20');
+ expect(optionTexts).not.toContain('0');
+ expect(optionTexts).not.toContain('All');
+ });
+ }
Review Comment:
Fixed in c469e4b ("fix(table): use accessible combobox query for page size selector (#42243)"). The test now does `screen.getByRole('combobox', { name: 'Show entries per page' })`, which throws if the selector isn't found, plus an explicit `expect(selectTrigger).toBeInTheDocument()`. No more `if (selectTrigger)` guard. Confirmed at current head. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5027021159
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5024844087
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "durgaprasadml (via GitHub)" <gi...@apache.org>.
durgaprasadml commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5220218262
Hi @rusackas, thanks for taking another look and for the detailed feedback.
Good catch on both points.
* I've removed the unrelated `cellBarStyles`/`arrowStyles` formatting changes so this PR is now scoped strictly to the server pagination fix.
* I've also updated the regression test to assert that `selectTrigger` exists before interacting with it, so the test will fail if the selector is ever missing instead of silently skipping the assertions.
I've pushed the changes and resolved the merge conflict as well. Thanks again for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5406657076
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5611200801
Pushed a fix for the DataTable.tsx desync Codeant flagged, resultOnPageChange and resultPageCount now use the fallback-adjusted page size instead of the raw one. Only thing left, @durgaprasadml: this has conflicts with master now in TableChart.tsx and its test, so it can't merge until it's rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5648781664
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #42248:
URL: https://github.com/apache/superset/pull/42248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #42248:
URL: https://github.com/apache/superset/pull/42248#discussion_r3616053823
##########
superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx:
##########
@@ -2482,6 +2482,47 @@ describe('plugin-chart-table', () => {
);
expect(screen.queryByText('Search by')).toBeInTheDocument();
});
+
+ test('dropdown preserves serverPageLength if larger than rowCount and avoids invalid 0 (#42243)', async () => {
+ const props = transformProps({
+ ...testData.basic,
+ formData: {
+ ...testData.basic.formData,
+ server_pagination: true,
+ },
+ });
+ props.serverPagination = true;
+ props.serverPageLength = 20;
+ props.rowCount = 12;
+ props.data = Array.from({ length: 12 }, (_, i) => ({
+ name: `Row ${i}`,
+ })) as any;
+
+ const { container } = render(
+ <ProviderWrapper>
+ <TableChart {...props} sticky={false} />
+ </ProviderWrapper>,
+ );
+
+ // Initial page size selector text
+ const pageSizeSelector = container.querySelector('.dt-select-page-size');
+ expect(pageSizeSelector).toHaveTextContent('20');
+
+ // Open dropdown to check options
+ const selectTrigger = container.querySelector('.ant-select-selector');
+ if (selectTrigger) {
+ fireEvent.mouseDown(selectTrigger);
+
+ await waitFor(() => {
+ const options = screen.getAllByRole('option');
+ const optionTexts = options.map(opt => opt.textContent);
+ expect(optionTexts).toContain('10');
+ expect(optionTexts).toContain('20');
+ expect(optionTexts).not.toContain('0');
+ expect(optionTexts).not.toContain('All');
+ });
+ }
Review Comment:
**Suggestion:** The assertions that validate dropdown options are wrapped in a conditional, so if the selector is not found the test silently skips all critical checks and still passes. Remove the conditional and assert the trigger exists before interacting so regression failures are not masked. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Regression test may pass without verifying dropdown existence.
- ⚠️ Future server pagination bugs less likely to be caught.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Open `superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx` and locate
the regression test added at lines 2486–2525 for issue #42243, which renders `TableChart`
and then queries `container.querySelector('.ant-select-selector')` into `selectTrigger`
(line 2512).
2. Observe that all assertions validating the dropdown options (lines 2517–2523) are
wrapped inside `if (selectTrigger) { ... }` (lines 2513–2524), so they execute only when
`selectTrigger` is non-null.
3. Consider a regression in `DataTable` or `TableChart` where the page-size dropdown is
not rendered or its structure changes such that `.ant-select-selector` no longer exists in
the DOM; in that situation, `container.querySelector('.ant-select-selector')` returns
`null` at line 2512.
4. Run the test suite: because `selectTrigger` is `null`, the `if (selectTrigger)` guard
prevents `fireEvent.mouseDown` and all `expect` calls from running, meaning Jest reports
the test as passing even though the dropdown is missing and the regression this test
intends to catch is not detected.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4be391c0f0584dcb8e4b8668ec4e2504&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4be391c0f0584dcb8e4b8668ec4e2504&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx
**Line:** 2512:2524
**Comment:**
*Logic Error: The assertions that validate dropdown options are wrapped in a conditional, so if the selector is not found the test silently skips all critical checks and still passes. Remove the conditional and assert the trigger exists before interacting so regression failures are not masked.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42248&comment_hash=61adf943343f3874cf2002c0237de7d6735702bd8c55ddf499ca07029fdba9cc&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42248&comment_hash=61adf943343f3874cf2002c0237de7d6735702bd8c55ddf499ca07029fdba9cc&reaction=dislike'>👎</a>
##########
superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx:
##########
@@ -461,11 +461,20 @@ export default typedMemo(function DataTable<D extends object>({
resultPageCount = 0;
}
resultCurrentPageSize = serverPageSize;
- const foundPageSizeIndex = pageSizeOptions.findIndex(
- ([option]) => option >= resultCurrentPageSize,
+ const exactMatch = pageSizeOptions.some(
+ ([option]) => option === resultCurrentPageSize,
);
- if (foundPageSizeIndex === -1) {
- resultCurrentPageSize = 0;
+ if (!exactMatch) {
+ const nearestOption = pageSizeOptions.find(
+ ([option]) => option >= resultCurrentPageSize,
+ );
+ if (nearestOption) {
+ resultCurrentPageSize = nearestOption[0];
+ } else if (pageSizeOptions.length > 0) {
+ resultCurrentPageSize = pageSizeOptions[pageSizeOptions.length - 1][0];
+ } else {
+ resultCurrentPageSize = 0;
Review Comment:
**Suggestion:** When fallback logic changes the selected page-size value, only the displayed selector value is updated; the server pagination calculations and page-change callback still use the original server page size. This can desynchronize what users see from what the backend pagination actually uses. Keep the effective page size consistent across display, page count calculation, and server callback inputs. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Page-size selector label inconsistent with actual server page size.
- ⚠️ Server pagination callbacks receive different size than UI shows.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Render the DataTable component from
`superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx` with
`serverPagination` enabled and `serverPaginationData?.pageSize` set to a value that is not
present in `pageSizeOptions` (e.g. 15) while `pageSizeOptions` only contains other values
(lines 458–459 and 467–476).
2. During rendering, at lines 458–459, `serverPageSize` is set from
`serverPaginationData?.pageSize` (e.g. 15) and `resultPageCount` is computed using this
`serverPageSize`, so page-count logic is based on 15 rows per page.
3. At lines 463–476, `resultCurrentPageSize` is initially set to `serverPageSize`, but
because `exactMatch` is false (line 464–466), the fallback block (lines 467–476) runs and
updates only `resultCurrentPageSize` to a different option from `pageSizeOptions` (e.g.
20), while `serverPageSize` and `resultPageCount` remain based on the original 15.
4. Later in the same file (outside this diff), the pagination UI uses
`resultCurrentPageSize` for the page-size selector while `resultOnPageChange` (line
480–481) still calls `onServerPaginationChange(pageNumber, serverPageSize)`, so the user
sees one page-size value in the selector (e.g. 20) but the server callback and page-count
calculations still operate with the original size (e.g. 15).
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b3ed0ffefe6348ecacbc888ecc570575&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b3ed0ffefe6348ecacbc888ecc570575&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx
**Line:** 467:476
**Comment:**
*Logic Error: When fallback logic changes the selected page-size value, only the displayed selector value is updated; the server pagination calculations and page-change callback still use the original server page size. This can desynchronize what users see from what the backend pagination actually uses. Keep the effective page size consistent across display, page count calculation, and server callback inputs.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42248&comment_hash=a197a4c018a759f1afc37c72d292a4fb8432a7cc23e2ef65afe00cf634612c7a&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42248&comment_hash=a197a4c018a759f1afc37c72d292a4fb8432a7cc23e2ef65afe00cf634612c7a&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5025016197
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/42248?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `61.90476%` with `8 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.22%. Comparing base ([`f03a66d`](https://app.codecov.io/gh/apache/superset/commit/f03a66db9c9d2ea2a20e48a8c3eb4298a58d00b1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5b11819`](https://app.codecov.io/gh/apache/superset/commit/5b118192c648e2c34a41fb34be9226624fd1ae91?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/42248?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ins/plugin-chart-table/src/DataTable/DataTable.tsx](https://app.codecov.io/gh/apache/superset/pull/42248?src=pr&el=tree&filepath=superset-frontend%2Fplugins%2Fplugin-chart-table%2Fsrc%2FDataTable%2FDataTable.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL0RhdGFUYWJsZS9EYXRhVGFibGUudHN4) | 27.27% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/42248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #42248 +/- ##
==========================================
- Coverage 65.22% 65.22% -0.01%
==========================================
Files 2768 2768
Lines 156122 156144 +22
Branches 35730 35740 +10
==========================================
+ Hits 101828 101839 +11
- Misses 52329 52340 +11
Partials 1965 1965
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/42248/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/42248/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.88% <61.90%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/42248?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5221520860
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5448114318
BTW, if you want a hand getting this across the finish line, I'm happy to push some commits here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5401657301
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5420334846
Thanks for pushing those updates, @durgaprasadml! Looks like Codeant's `DataTable.tsx` thread is still the one open item though, still needs fixing before this is mergeable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5594417709
Still not addressed: the fallback-desync bug in DataTable.tsx I flagged twice (Aug 10, Aug 26) — resultOnPageChange still fires onServerPaginationChange with the raw, possibly-mismatched page size instead of the fallback-adjusted one. I offered on Aug 28 to push some commits myself and never heard back, so I'll see if I can get this across the finish line...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5602989271
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5036453936
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): preserve configured server page size when row count is smaller (#42243) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #42248:
URL: https://github.com/apache/superset/pull/42248#issuecomment-5107840290
Thanks @durgaprasadml, the pagination fix itself looks right and matches the repro in #42243.
Couple of things to look into...
The `cellBarStyles`/`arrowStyles` css`` reformatting around `TableChart.tsx:1188-1200` isn't part of the page-size fix and isn't mentioned in the description. Any reason it's riding along in this PR? I'd rather keep this one scoped to the pagination bug.
Also, the new test wraps its assertions in `if (selectTrigger) { ... }` (`TableChart.test.tsx`), so if that selector ever goes missing the regression check just silently no-ops instead of failing. Worth asserting `selectTrigger` exists before the `waitFor`, otherwise the test can pass without actually checking anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org