You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/11 17:20:35 UTC

[GitHub] [skywalking] mrproliu opened a new pull request #6176: [WIP] Adopt Zabbix protocol

mrproliu opened a new pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176


   ### Adopt Zabbix protocol
   - [ ] Update the documentation to include this new feature.
   - [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
   - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #6118 
   - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (1ed1a79) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `14.58%`.
   > The diff coverage is `35.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     55.97%   41.39%   -14.59%     
   + Complexity     3901     2465     -1436     
   =============================================
     Files           973      812      -161     
     Lines         24216    20099     -4117     
     Branches       2394     1921      -473     
   =============================================
   - Hits          13556     8319     -5237     
   - Misses         9464    11127     +1663     
   + Partials       1196      653      -543     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [422 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r571608863



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java
##########
@@ -284,6 +289,11 @@ public void prepare() throws ServiceNotProvidedException, ModuleStartException {
         TopNStreamProcessor.getInstance().setTopNWorkerReportCycle(moduleConfig.getTopNReportPeriod());
         apdexThresholdConfig = new ApdexThresholdConfig(this);
         ApdexMetrics.setDICT(apdexThresholdConfig);
+
+        // TCP manager
+        tcpServerManager = new TCPServerManager(moduleConfig.getTcpHost(),
+            moduleConfig.getTcpBossGroupThreadCount(), moduleConfig.getTcpWorkerGroupThreadCount());
+        this.registerServiceImplementation(TCPBinderRegister.class, new TCPBinderRegisterImpl(tcpServerManager));

Review comment:
       > because I need to share the TCP connect
   
   I don't agree, what case you could share 2 kinds of TCP protocol with one server?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c4737cc) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `4.93%`.
   > The diff coverage is `35.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   51.04%   -4.94%     
   + Complexity     3901     3626     -275     
   ============================================
     Files           973      980       +7     
     Lines         24216    24232      +16     
     Branches       2394     2378      -16     
   ============================================
   - Hits          13556    12370    -1186     
   - Misses         9464    10830    +1366     
   + Partials       1196     1032     -164     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [166 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (287e6c6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `9.95%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   46.88%   -9.96%     
   + Complexity     3911     2777    -1134     
   ============================================
     Files           962      826     -136     
     Lines         23957    20588    -3369     
     Branches       2362     1959     -403     
   ============================================
   - Hits          13616     9652    -3964     
   - Misses         9149    10217    +1068     
   + Partials       1192      719     -473     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [322 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (287e6c6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `8.10%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   48.72%   -8.11%     
   + Complexity     3911     2847    -1064     
   ============================================
     Files           962      826     -136     
     Lines         23957    20598    -3359     
     Branches       2362     1960     -402     
   ============================================
   - Hits          13616    10037    -3579     
   - Misses         9149     9808     +659     
   + Partials       1192      753     -439     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [303 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (da8ec05) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `4.10%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   48.73%   -4.11%     
   + Complexity     3793     3544     -249     
   ============================================
     Files          1732      964     -768     
     Lines         36915    23883   -13032     
     Branches       4071     2310    -1761     
   ============================================
   - Hits          19504    11639    -7865     
   + Misses        16434    11238    -5196     
   - Partials        977     1006      +29     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1271 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (4cd8bf0) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `7.77%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   49.06%   -7.78%     
   + Complexity     3911     3546     -365     
   ============================================
     Files           962      976      +14     
     Lines         23957    24160     +203     
     Branches       2362     2376      +14     
   ============================================
   - Hits          13616    11854    -1762     
   - Misses         9149    11268    +2119     
   + Partials       1192     1038     -154     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [162 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...4cd8bf0](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c434154) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `1.29%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   55.53%   -1.30%     
   + Complexity     3911     3897      -14     
   ============================================
     Files           962      977      +15     
     Lines         23957    24260     +303     
     Branches       2362     2384      +22     
   ============================================
   - Hits          13616    13474     -142     
   - Misses         9149     9608     +459     
   + Partials       1192     1178      -14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [41 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (30a8312) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `11.19%`.
   > The diff coverage is `41.99%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     55.97%   44.78%   -11.20%     
   + Complexity     3901     2726     -1175     
   =============================================
     Files           973      830      -143     
     Lines         24216    20633     -3583     
     Branches       2394     1976      -418     
   =============================================
   - Hits          13556     9240     -4316     
   - Misses         9464    10667     +1203     
   + Partials       1196      726      -470     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [369 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c434154) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `2.22%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   54.60%   -2.23%     
   + Complexity     3911     3855      -56     
   ============================================
     Files           962      977      +15     
     Lines         23957    24247     +290     
     Branches       2362     2384      +22     
   ============================================
   - Hits          13616    13241     -375     
   - Misses         9149     9842     +693     
   + Partials       1192     1164      -28     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (60ca798) into [master](https://codecov.io/gh/apache/skywalking/commit/56c264d1fa640115197ed19bb8a68388c6fa3b95?el=desc) (56c264d) will **decrease** coverage by `3.46%`.
   > The diff coverage is `35.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     48.89%   45.42%   -3.47%     
   + Complexity     3495     2727     -768     
   ============================================
     Files           960      814     -146     
     Lines         23829    20230    -3599     
     Branches       2320     1908     -412     
   ============================================
   - Hits          11650     9189    -2461     
   + Misses        11155    10335     -820     
   + Partials       1024      706     -318     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.19% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [56c264d...60ca798](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (12d65b8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `7.73%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   49.10%   -7.74%     
   + Complexity     3911     2842    -1069     
   ============================================
     Files           962      808     -154     
     Lines         23957    20074    -3883     
     Branches       2362     1906     -456     
   ============================================
   - Hits          13616     9857    -3759     
   - Misses         9149     9447     +298     
   + Partials       1192      770     -422     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [297 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...12d65b8](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `7.15%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   49.67%   -7.16%     
   + Complexity     3911     2899    -1012     
   ============================================
     Files           962      825     -137     
     Lines         23957    20592    -3365     
     Branches       2362     1957     -405     
   ============================================
   - Hits          13616    10230    -3386     
   - Misses         9149     9556     +407     
   + Partials       1192      806     -386     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [289 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `7.05%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   49.78%   -7.06%     
   + Complexity     3911     3584     -327     
   ============================================
     Files           962      976      +14     
     Lines         23957    24189     +232     
     Branches       2362     2362              
   ============================================
   - Hits          13616    12042    -1574     
   - Misses         9149    11101    +1952     
   + Partials       1192     1046     -146     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [135 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `15.59%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   41.24%   -15.60%     
   + Complexity     3911     2484     -1427     
   =============================================
     Files           962      826      -136     
     Lines         23957    20541     -3416     
     Branches       2362     1971      -391     
   =============================================
   - Hits          13616     8472     -5144     
   - Misses         9149    11449     +2300     
   + Partials       1192      620      -572     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [360 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (663a646) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `11.40%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     55.97%   44.57%   -11.41%     
   + Complexity     3901     2727     -1174     
   =============================================
     Files           973      829      -144     
     Lines         24216    20620     -3596     
     Branches       2394     1973      -421     
   =============================================
   - Hits          13556     9191     -4365     
   - Misses         9464    10699     +1235     
   + Partials       1196      730      -466     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.56%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [360 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (da8ec05) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `4.09%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   48.73%   -4.10%     
   + Complexity     3793     3547     -246     
   ============================================
     Files          1732      964     -768     
     Lines         36915    23892   -13023     
     Branches       4071     2325    -1746     
   ============================================
   - Hits          19504    11644    -7860     
   + Misses        16434    11242    -5192     
   - Partials        977     1006      +29     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1267 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (cfe3021) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `8.96%`.
   > The diff coverage is `68.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   43.87%   -8.97%     
   + Complexity     3793     2358    -1435     
   ============================================
     Files          1732     1737       +5     
     Lines         36915    36891      -24     
     Branches       4071     4253     +182     
   ============================================
   - Hits          19504    16185    -3319     
   - Misses        16434    19708    +3274     
   - Partials        977      998      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.19% <ø> (+3.33%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `42.72% <42.72%> (ø)` | `6.00 <6.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `50.00% <50.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `52.94% <52.94%> (ø)` | `3.00 <3.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `62.50% <62.50%> (ø)` | `7.00 <7.00> (?)` | |
   | [...ap/server/library/server/tcp/TCPServerManager.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJNYW5hZ2VyLmphdmE=) | `74.35% <74.35%> (ø)` | `5.00 <5.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `80.00% <80.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `81.25% <81.25%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.88% <88.88%> (ø)` | `8.00 <8.00> (?)` | |
   | ... and [338 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...7150798](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c4737cc) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `4.97%`.
   > The diff coverage is `35.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   51.00%   -4.98%     
   + Complexity     3901     3625     -276     
   ============================================
     Files           973      980       +7     
     Lines         24216    24232      +16     
     Branches       2394     2378      -16     
   ============================================
   - Hits          13556    12359    -1197     
   - Misses         9464    10842    +1378     
   + Partials       1196     1031     -165     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [167 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c4737cc) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `5.01%`.
   > The diff coverage is `35.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   50.96%   -5.02%     
   + Complexity     3901     3621     -280     
   ============================================
     Files           973      980       +7     
     Lines         24216    24232      +16     
     Branches       2394     2378      -16     
   ============================================
   - Hits          13556    12349    -1207     
   - Misses         9464    10853    +1389     
   + Partials       1196     1030     -166     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [173 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `10.98%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.84%   -10.99%     
   + Complexity     3911     2742     -1169     
   =============================================
     Files           962      825      -137     
     Lines         23957    20556     -3401     
     Branches       2362     1956      -406     
   =============================================
   - Hits          13616     9424     -4192     
   - Misses         9149    10381     +1232     
   + Partials       1192      751      -441     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [319 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (287e6c6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `7.45%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   49.37%   -7.46%     
   + Complexity     3911     2874    -1037     
   ============================================
     Files           962      826     -136     
     Lines         23957    20611    -3346     
     Branches       2362     1960     -402     
   ============================================
   - Hits          13616    10177    -3439     
   - Misses         9149     9661     +512     
   + Partials       1192      773     -419     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [293 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (ecac220) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.41%`.
   > The diff coverage is `77.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.41%   -6.42%     
   + Complexity     3911     3607     -304     
   ============================================
     Files           962      975      +13     
     Lines         23957    24167     +210     
     Branches       2362     2361       -1     
   ============================================
   - Hits          13616    12185    -1431     
   - Misses         9149    10942    +1793     
   + Partials       1192     1040     -152     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `92.00% <92.00%> (ø)` | `4.00 <4.00> (?)` | |
   | ... and [160 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...93aa01d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (08876d9) into [master](https://codecov.io/gh/apache/skywalking/commit/e138d29778fb458a6fad5f3fd82121c7bba3cc95?el=desc) (e138d29) will **decrease** coverage by `20.02%`.
   > The diff coverage is `38.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     52.54%   32.51%   -20.03%     
   + Complexity     3793     2402     -1391     
   =============================================
     Files          1748      945      -803     
     Lines         37066    23078    -13988     
     Branches       4102     2215     -1887     
   =============================================
   - Hits          19475     7503    -11972     
   + Misses        16620    14899     -1721     
   + Partials        971      676      -295     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `12.91% <ø> (-39.94%)` | `12.00 <0.00> (-50.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `92.85% <ø> (+66.93%)` | `3.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1404 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8c51043...0437d1d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (da8ec05) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `1.95%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   50.88%   -1.96%     
   + Complexity     3793     3628     -165     
   ============================================
     Files          1732      964     -768     
     Lines         36915    23902   -13013     
     Branches       4071     2326    -1745     
   ============================================
   - Hits          19504    12162    -7342     
   + Misses        16434    10659    -5775     
   - Partials        977     1081     +104     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1263 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (287e6c6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `5.53%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   51.30%   -5.54%     
   + Complexity     3911     3001     -910     
   ============================================
     Files           962      826     -136     
     Lines         23957    20640    -3317     
     Branches       2362     1978     -384     
   ============================================
   - Hits          13616    10589    -3027     
   - Misses         9149     9216      +67     
   + Partials       1192      835     -357     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [256 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c89b4e6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `22.50%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   34.33%   -22.51%     
   + Complexity     3911     2063     -1848     
   =============================================
     Files           962      806      -156     
     Lines         23957    19805     -4152     
     Branches       2362     1863      -499     
   =============================================
   - Hits          13616     6800     -6816     
   - Misses         9149    12492     +3343     
   + Partials       1192      513      -679     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [456 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...93aa01d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (0c87938) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `19.22%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   37.61%   -19.23%     
   + Complexity     3911     2330     -1581     
   =============================================
     Files           962      825      -137     
     Lines         23957    20524     -3433     
     Branches       2362     1955      -407     
   =============================================
   - Hits          13616     7720     -5896     
   - Misses         9149    12224     +3075     
   + Partials       1192      580      -612     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [402 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.25%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.57%   -3.26%     
   + Complexity     3911     3775     -136     
   ============================================
     Files           962      976      +14     
     Lines         23957    24177     +220     
     Branches       2362     2376      +14     
   ============================================
   - Hits          13616    12954     -662     
   - Misses         9149    10095     +946     
   + Partials       1192     1128      -64     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [88 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (98e429d) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `4.36%`.
   > The diff coverage is `48.68%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     53.20%   48.83%   -4.37%     
   + Complexity     3900     3569     -331     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24242   -13090     
     Branches       4149     2364    -1785     
   ============================================
   - Hits          19861    11839    -8022     
   + Misses        16489    11362    -5127     
   - Partials        982     1041      +59     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1372 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `11.45%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.38%   -11.46%     
   + Complexity     3911     2681     -1230     
   =============================================
     Files           962      826      -136     
     Lines         23957    20551     -3406     
     Branches       2362     1972      -390     
   =============================================
   - Hits          13616     9327     -4289     
   - Misses         9149    10522     +1373     
   + Partials       1192      702      -490     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [327 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (98e429d) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **increase** coverage by `1.13%`.
   > The diff coverage is `80.43%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     53.20%   54.33%   +1.13%     
   + Complexity     3900     3851      -49     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24319   -13013     
     Branches       4149     2386    -1763     
   ============================================
   - Hits          19861    13213    -6648     
   + Misses        16489     9914    -6575     
   - Partials        982     1192     +210     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
   | ... and [1348 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `15.34%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   41.49%   -15.35%     
   + Complexity     3911     2492     -1419     
   =============================================
     Files           962      826      -136     
     Lines         23957    20541     -3416     
     Branches       2362     1971      -391     
   =============================================
   - Hits          13616     8523     -5093     
   - Misses         9149    11397     +2248     
   + Partials       1192      621      -571     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [358 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.05%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.78%   -3.06%     
   + Complexity     3911     3783     -128     
   ============================================
     Files           962      976      +14     
     Lines         23957    24177     +220     
     Branches       2362     2376      +14     
   ============================================
   - Hits          13616    13003     -613     
   - Misses         9149    10029     +880     
   + Partials       1192     1145      -47     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [84 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b17f32a) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `18.08%`.
   > The diff coverage is `35.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     52.83%   34.75%   -18.09%     
   + Complexity     3793     2047     -1746     
   =============================================
     Files          1732      796      -936     
     Lines         36915    19671    -17244     
     Branches       4071     1853     -2218     
   =============================================
   - Hits          19504     6836    -12668     
   + Misses        16434    12311     -4123     
   + Partials        977      524      -453     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1405 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...0cc358d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (08876d9) into [master](https://codecov.io/gh/apache/skywalking/commit/e138d29778fb458a6fad5f3fd82121c7bba3cc95?el=desc) (e138d29) will **decrease** coverage by `5.89%`.
   > The diff coverage is `38.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.54%   46.65%   -5.90%     
   + Complexity     3793     3358     -435     
   ============================================
     Files          1748      963     -785     
     Lines         37066    23822   -13244     
     Branches       4102     2318    -1784     
   ============================================
   - Hits          19475    11113    -8362     
   + Misses        16620    11746    -4874     
   + Partials        971      963       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `92.85% <ø> (+66.93%)` | `3.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8c51043...0437d1d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (3b30413) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `21.53%`.
   > The diff coverage is `27.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   35.30%   -21.54%     
   + Complexity     3911     2137     -1774     
   =============================================
     Files           962      807      -155     
     Lines         23957    19973     -3984     
     Branches       2362     1909      -453     
   =============================================
   - Hits          13616     7051     -6565     
   - Misses         9149    12390     +3241     
   + Partials       1192      532      -660     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [441 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...6e44b52](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.35%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.48%   -6.36%     
   + Complexity     3911     3612     -299     
   ============================================
     Files           962      976      +14     
     Lines         23957    24200     +243     
     Branches       2362     2379      +17     
   ============================================
   - Hits          13616    12217    -1399     
   - Misses         9149    10896    +1747     
   + Partials       1192     1087     -105     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [117 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.59%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.23%   -3.60%     
   + Complexity     3911     3721     -190     
   ============================================
     Files           962      975      +13     
     Lines         23957    24167     +210     
     Branches       2362     2359       -3     
   ============================================
   - Hits          13616    12866     -750     
   - Misses         9149    10163    +1014     
   + Partials       1192     1138      -54     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [116 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (bd822db) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `19.85%`.
   > The diff coverage is `72.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     53.20%   33.34%   -19.86%     
   + Complexity     3900     2055     -1845     
   =============================================
     Files          1751      811      -940     
     Lines         37332    20025    -17307     
     Branches       4149     1896     -2253     
   =============================================
   - Hits          19861     6678    -13183     
   + Misses        16489    12862     -3627     
   + Partials        982      485      -497     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.06% <0.00%> (-61.61%)` | `2.00 <0.00> (-7.00)` | |
   | ... and [1520 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `4.86%`.
   > The diff coverage is `68.30%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   51.96%   -4.87%     
   + Complexity     3911     3749     -162     
   ============================================
     Files           962     1766     +804     
     Lines         23957    37665   +13708     
     Branches       2362     4176    +1814     
   ============================================
   + Hits          13616    19573    +5957     
   - Misses         9149    17106    +7957     
   + Partials       1192      986     -206     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.66% <ø> (+4.03%)` | `66.00 <0.00> (+4.00)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `42.20% <42.20%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `50.00% <50.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `80.00% <80.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `81.25% <81.25%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `90.69% <90.69%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/receiver/zabbix/module/ZabbixReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9tb2R1bGUvWmFiYml4UmVjZWl2ZXJNb2R1bGUuamF2YQ==) | `100.00% <100.00%> (ø)` | `2.00 <2.00> (?)` | |
   | ... and [1262 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (49242fd) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `18.04%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   38.79%   -18.05%     
   + Complexity     3911     2817     -1094     
   =============================================
     Files           962      958        -4     
     Lines         23957    23418      -539     
     Branches       2362     2268       -94     
   =============================================
   - Hits          13616     9085     -4531     
   - Misses         9149    13576     +4427     
   + Partials       1192      757      -435     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [283 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (287e6c6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `8.52%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   48.31%   -8.53%     
   + Complexity     3911     2829    -1082     
   ============================================
     Files           962      826     -136     
     Lines         23957    20598    -3359     
     Branches       2362     1960     -402     
   ============================================
   - Hits          13616     9951    -3665     
   - Misses         9149     9892     +743     
   + Partials       1192      755     -437     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [308 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (30a8312) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `11.44%`.
   > The diff coverage is `41.74%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     55.97%   44.53%   -11.45%     
   + Complexity     3901     2716     -1185     
   =============================================
     Files           973      830      -143     
     Lines         24216    20633     -3583     
     Branches       2394     1976      -418     
   =============================================
   - Hits          13556     9189     -4367     
   - Misses         9464    10718     +1254     
   + Partials       1196      726      -470     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [372 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r568289395



##########
File path: docs/en/setup/backend/backend-zabbix.md
##########
@@ -0,0 +1,67 @@
+# Zabbix Receiver
+Zabbix receiver is accepting the metrics of [Zabbix Agent Active Checks protocol](https://www.zabbix.com/documentation/current/manual/appendix/items/activepassive#active_checks) fromat into the [Meter System](./../../concepts-and-designs/meter.md).
+
+## Module define
+```yaml
+receiver-zabbix:
+  selector: ${SW_RECEIVER_METER:default}
+  default:
+    # Export tcp port, Zabbix agent could connected and transport data
+    port: 13800
+    # Enable config when receive agent request
+    activeFiles: agent.yaml

Review comment:
       Please take a reference of OTEL rules, I remember it uses file name without `.yaml`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (0c87938) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `13.19%`.
   > The diff coverage is `77.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   43.63%   -13.20%     
   + Complexity     3911     2649     -1262     
   =============================================
     Files           962      825      -137     
     Lines         23957    20575     -3382     
     Branches       2362     1958      -404     
   =============================================
   - Hits          13616     8978     -4638     
   - Misses         9149    10927     +1778     
   + Partials       1192      670      -522     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `92.00% <92.00%> (ø)` | `4.00 <4.00> (?)` | |
   | ... and [336 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (0b1d8c5) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `13.91%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   42.91%   -13.92%     
   + Complexity     3911     3182      -729     
   =============================================
     Files           962      976       +14     
     Lines         23957    24117      +160     
     Branches       2362     2356        -6     
   =============================================
   - Hits          13616    10351     -3265     
   - Misses         9149    12891     +3742     
   + Partials       1192      875      -317     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [247 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...12d65b8](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (3b30413) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `15.74%`.
   > The diff coverage is `27.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   41.08%   -15.75%     
   + Complexity     3911     3000      -911     
   =============================================
     Files           962      957        -5     
     Lines         23957    23577      -380     
     Branches       2362     2316       -46     
   =============================================
   - Hits          13616     9687     -3929     
   - Misses         9149    13041     +3892     
   + Partials       1192      849      -343     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [263 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...763bc45](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c434154) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `2.42%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   54.41%   -2.43%     
   + Complexity     3911     3842      -69     
   ============================================
     Files           962      977      +15     
     Lines         23957    24247     +290     
     Branches       2362     2384      +22     
   ============================================
   - Hits          13616    13194     -422     
   - Misses         9149     9890     +741     
   + Partials       1192     1163      -29     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [60 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b425d99) into [master](https://codecov.io/gh/apache/skywalking/commit/ba6d49ad917bf698d6179ebc90a3a0703e74a4b1?el=desc) (ba6d49a) will **increase** coverage by `6.17%`.
   > The diff coverage is `77.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     49.66%   55.83%   +6.17%     
   - Complexity     3558     3912     +354     
   ============================================
     Files          1752      981     -771     
     Lines         37357    24347   -13010     
     Branches       4146     2388    -1758     
   ============================================
   - Hits          18554    13595    -4959     
   + Misses        17830     9564    -8266     
   - Partials        973     1188     +215     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [1281 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...b425d99](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (0cc358d) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `22.09%`.
   > The diff coverage is `35.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     52.83%   30.73%   -22.10%     
   + Complexity     3793     1820     -1973     
   =============================================
     Files          1732      796      -936     
     Lines         36915    19502    -17413     
     Branches       4071     1807     -2264     
   =============================================
   - Hits          19504     5994    -13510     
   + Misses        16434    13077     -3357     
   + Partials        977      431      -546     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `12.91% <ø> (-39.94%)` | `12.00 <0.00> (-50.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1434 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...0cc358d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (1ed1a79) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **increase** coverage by `1.54%`.
   > The diff coverage is `80.35%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     53.20%   54.74%   +1.54%     
   + Complexity     3900     3831      -69     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24318   -13014     
     Branches       4149     2386    -1763     
   ============================================
   - Hits          19861    13313    -6548     
   + Misses        16489     9883    -6606     
   - Partials        982     1122     +140     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `63.78% <ø> (+0.86%)` | `30.00 <0.00> (+1.00)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | ... and [1343 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] mrproliu commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r571591107



##########
File path: oap-server/server-bootstrap/src/main/resources/ui-initialized-templates/zabbix.yml
##########
@@ -0,0 +1,157 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# UI templates initialized file includes the default template when the SkyWalking OAP starts up at the first time.
+#
+# Also, SkyWalking would detect the existing templates in the database, once they are missing, all templates in this file
+# could be added automatically.
+
+templates:
+  - name: "Zabbix"

Review comment:
       There has a little difference between OTEL or Zabbix. Such as `Disk R/W`, the Zabbix is not supporting read bytes per second, only support read/write count. I found the [Zabbix agent support platform document](https://www.zabbix.com/documentation/current/manual/appendix/items/supported_by_platform), It could behave more description.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (30a8312) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `24.57%`.
   > The diff coverage is `41.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     55.97%   31.40%   -24.58%     
   + Complexity     3901     1991     -1910     
   =============================================
     Files           973      829      -144     
     Lines         24216    20412     -3804     
     Branches       2394     1923      -471     
   =============================================
   - Hits          13556     6411     -7145     
   - Misses         9464    13528     +4064     
   + Partials       1196      473      -723     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `16.74% <ø> (-35.89%)` | `17.00 <0.00> (-45.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [523 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (1ed1a79) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `10.72%`.
   > The diff coverage is `35.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     55.97%   45.25%   -10.73%     
   + Complexity     3901     3269      -632     
   =============================================
     Files           973      962       -11     
     Lines         24216    23671      -545     
     Branches       2394     2323       -71     
   =============================================
   - Hits          13556    10713     -2843     
   - Misses         9464    12026     +2562     
   + Partials       1196      932      -264     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [259 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (763bc45) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `21.52%`.
   > The diff coverage is `27.55%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   35.30%   -21.53%     
   + Complexity     3911     2138     -1773     
   =============================================
     Files           962      807      -155     
     Lines         23957    19972     -3985     
     Branches       2362     1909      -453     
   =============================================
   - Hits          13616     7052     -6564     
   - Misses         9149    12389     +3240     
   + Partials       1192      531      -661     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [439 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...763bc45](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c434154) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.20%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.62%   -3.21%     
   + Complexity     3911     3791     -120     
   ============================================
     Files           962      977      +15     
     Lines         23957    24247     +290     
     Branches       2362     2384      +22     
   ============================================
   - Hits          13616    13003     -613     
   - Misses         9149    10095     +946     
   + Partials       1192     1149      -43     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [71 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] mrproliu commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r572999041



##########
File path: docs/en/setup/backend/backend-zabbix.md
##########
@@ -0,0 +1,70 @@
+# Zabbix Receiver

Review comment:
       It using TCP short connection. no plan to add a benchmark. And no authentication support currently.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.19%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.64%   -3.20%     
   + Complexity     3911     3777     -134     
   ============================================
     Files           962      976      +14     
     Lines         23957    24177     +220     
     Branches       2362     2376      +14     
   ============================================
   - Hits          13616    12969     -647     
   - Misses         9149    10073     +924     
   + Partials       1192     1135      -57     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [87 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] mrproliu commented on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-776025900


   I have tested, and take a screenshot in the VM view.
   ![image](https://user-images.githubusercontent.com/3417650/107386516-e3d53300-6b2e-11eb-9968-167105f678a4.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (1ed1a79) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `6.99%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   48.98%   -7.00%     
   + Complexity     3901     3481     -420     
   ============================================
     Files           973      962      -11     
     Lines         24216    23718     -498     
     Branches       2394     2328      -66     
   ============================================
   - Hits          13556    11618    -1938     
   - Misses         9464    11118    +1654     
   + Partials       1196      982     -214     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.56%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [207 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (cfe3021) into [master](https://codecov.io/gh/apache/skywalking/commit/56c264d1fa640115197ed19bb8a68388c6fa3b95?el=desc) (56c264d) will **decrease** coverage by `5.01%`.
   > The diff coverage is `68.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     48.89%   43.87%   -5.02%     
   + Complexity     3495     2358    -1137     
   ============================================
     Files           960     1737     +777     
     Lines         23829    36891   +13062     
     Branches       2320     4253    +1933     
   ============================================
   + Hits          11650    16185    +4535     
   - Misses        11155    19708    +8553     
   + Partials       1024      998      -26     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.19% <ø> (+3.55%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `42.72% <42.72%> (ø)` | `6.00 <6.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `50.00% <50.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `52.94% <52.94%> (ø)` | `3.00 <3.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `62.50% <62.50%> (ø)` | `7.00 <7.00> (?)` | |
   | [...ap/server/library/server/tcp/TCPServerManager.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJNYW5hZ2VyLmphdmE=) | `74.35% <74.35%> (ø)` | `5.00 <5.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `80.00% <80.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `81.25% <81.25%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `88.88% <88.88%> (ø)` | `8.00 <8.00> (?)` | |
   | ... and [1350 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [56c264d...60ca798](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `4.58%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   52.25%   -4.59%     
   + Complexity     3911     3709     -202     
   ============================================
     Files           962      976      +14     
     Lines         23957    24236     +279     
     Branches       2362     2380      +18     
   ============================================
   - Hits          13616    12664     -952     
   - Misses         9149    10456    +1307     
   + Partials       1192     1116      -76     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [95 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c434154) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `2.27%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   54.56%   -2.28%     
   + Complexity     3911     3854      -57     
   ============================================
     Files           962      977      +15     
     Lines         23957    24247     +290     
     Branches       2362     2384      +22     
   ============================================
   - Hits          13616    13230     -386     
   - Misses         9149     9854     +705     
   + Partials       1192     1163      -29     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [56 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (da8ec05) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `1.23%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   51.59%   -1.24%     
   + Complexity     3793     3677     -116     
   ============================================
     Files          1732      964     -768     
     Lines         36915    23902   -13013     
     Branches       4071     2326    -1745     
   ============================================
   - Hits          19504    12333    -7171     
   + Misses        16434    10476    -5958     
   - Partials        977     1093     +116     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1268 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `20.98%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   35.84%   -20.99%     
   + Complexity     3911     2166     -1745     
   =============================================
     Files           962      808      -154     
     Lines         23957    19979     -3978     
     Branches       2362     1911      -451     
   =============================================
   - Hits          13616     7162     -6454     
   - Misses         9149    12284     +3135     
   + Partials       1192      533      -659     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [424 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c4737cc) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `4.62%`.
   > The diff coverage is `35.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   51.35%   -4.63%     
   + Complexity     3901     3640     -261     
   ============================================
     Files           973      980       +7     
     Lines         24216    24232      +16     
     Branches       2394     2378      -16     
   ============================================
   - Hits          13556    12445    -1111     
   - Misses         9464    10745    +1281     
   + Partials       1196     1042     -154     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [161 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (1ed1a79) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `14.61%`.
   > The diff coverage is `35.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     55.97%   41.36%   -14.62%     
   + Complexity     3901     2463     -1438     
   =============================================
     Files           973      812      -161     
     Lines         24216    20099     -4117     
     Branches       2394     1921      -473     
   =============================================
   - Hits          13556     8313     -5243     
   - Misses         9464    11130     +1666     
   + Partials       1196      656      -540     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [424 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.40%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.42%   -6.41%     
   + Complexity     3911     2924     -987     
   ============================================
     Files           962      825     -137     
     Lines         23957    20592    -3365     
     Branches       2362     1957     -405     
   ============================================
   - Hits          13616    10384    -3232     
   - Misses         9149     9395     +246     
   + Partials       1192      813     -379     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [283 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r573506318



##########
File path: oap-server/server-receiver-plugin/skywalking-zabbix-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zabbix/provider/ZabbixMetrics.java
##########
@@ -0,0 +1,312 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.receiver.zabbix.provider;
+
+import com.google.common.collect.ImmutableMap;
+import io.vavr.Tuple;
+import io.vavr.Tuple2;
+import lombok.Builder;
+import lombok.Data;
+import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.math.NumberUtils;
+import org.apache.commons.lang3.time.StopWatch;
+import org.apache.commons.text.StringTokenizer;
+import org.apache.skywalking.apm.util.StringUtil;
+import org.apache.skywalking.oap.meter.analyzer.MetricConvert;
+import org.apache.skywalking.oap.meter.analyzer.dsl.Sample;
+import org.apache.skywalking.oap.meter.analyzer.dsl.SampleFamily;
+import org.apache.skywalking.oap.meter.analyzer.dsl.SampleFamilyBuilder;
+import org.apache.skywalking.oap.server.core.analysis.meter.MeterSystem;
+import org.apache.skywalking.oap.server.library.util.CollectionUtils;
+import org.apache.skywalking.oap.server.receiver.zabbix.provider.config.ZabbixConfig;
+import org.apache.skywalking.oap.server.receiver.zabbix.provider.protocol.bean.ZabbixRequest;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+import java.util.stream.Collectors;
+
+import static com.google.common.collect.ImmutableMap.toImmutableMap;
+
+/**
+ * Management all Zabbix metrics
+ */
+@Slf4j
+public class ZabbixMetrics {
+
+    private final List<ZabbixConfig> originalConfigs;
+
+    /**
+     * All enabled service and instance group
+     */
+    private List<InstanceGroup> allServices = new ArrayList<>();
+
+    public ZabbixMetrics(List<ZabbixConfig> originalConfigs, MeterSystem meterSystem) {
+        this.originalConfigs = originalConfigs;
+        initConfigs(meterSystem);
+    }
+
+    /**
+     * Get all key names when Zabbix agent queried
+     */
+    public Set<String> getAllMonitorMetricNames(String hostName) {
+        // Find instance group
+        return findInstanceGroup(hostName).map(InstanceGroup::getEnabledKeys).orElse(null);
+    }
+
+    /**
+     * Receive agent data and convert to meter system
+     */
+    public ConvertStatics convertMetrics(List<ZabbixRequest.AgentData> agentDataList) {
+        if (CollectionUtils.isEmpty(agentDataList)) {
+            return ConvertStatics.EMPTY;
+        }
+
+        return agentDataList.stream()
+            // Group by host
+            .collect(Collectors.groupingBy(ZabbixRequest.AgentData::getHost)).entrySet().stream()
+            // Convert every agent data list
+            .map(e -> findInstanceGroup(e.getKey()).map(instanceGroup -> instanceGroup.convertToMeter(e.getValue())).orElse(null))
+            .filter(Objects::nonNull)
+            // Merge all statics
+            .reduce(ConvertStatics::merge)
+            .orElse(ConvertStatics.EMPTY);
+    }
+
+    private Optional<InstanceGroup> findInstanceGroup(String hostName) {
+        // Find service group, support using cache
+        return allServices.stream().filter(group -> group.matchesWithHostName(hostName)).findAny();
+    }
+
+    private void initConfigs(MeterSystem meterSystem) {
+        // Temporary instance group cache, encase generate multiple instance group
+        HashMap<String, InstanceGroup> tmpGroupCache = new HashMap<>();
+
+        // Each config entities
+        originalConfigs.forEach(c ->
+            c.getEntities().getHostPatterns().forEach(instance ->
+                tmpGroupCache.computeIfAbsent(instance, ins -> {
+                    InstanceGroup instanceGroup = new InstanceGroup(ins, meterSystem);
+                    allServices.add(instanceGroup);
+                    return instanceGroup;
+                }).appendMetrics(c)));
+    }
+
+    /**
+     * Metrics convert to meter system statics
+     */
+    @Builder
+    @Getter
+    public static class ConvertStatics {
+        public static final ConvertStatics EMPTY = ConvertStatics.builder().build();
+        private int total;
+        private int success;
+        private int failed;
+        private double useTime;
+
+        public ConvertStatics merge(ConvertStatics statics) {
+            this.total += statics.total;
+            this.success += statics.success;
+            this.failed += statics.failed;
+            this.useTime += statics.useTime;
+            return this;
+        }
+    }
+
+    /**
+     * Instance group metrics

Review comment:
       ```suggestion
        * The group of instances according to hostPatterns defined in Zabbix rule file
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (bd822db) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `0.50%`.
   > The diff coverage is `78.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     53.20%   52.69%   -0.51%     
   + Complexity     3900     3731     -169     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24317   -13015     
     Branches       4149     2370    -1779     
   ============================================
   - Hits          19861    12815    -7046     
   + Misses        16489    10445    -6044     
   - Partials        982     1057      +75     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | ... and [1372 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `11.59%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.24%   -11.60%     
   + Complexity     3911     2672     -1239     
   =============================================
     Files           962      826      -136     
     Lines         23957    20551     -3406     
     Branches       2362     1972      -390     
   =============================================
   - Hits          13616     9298     -4318     
   - Misses         9149    10548     +1399     
   + Partials       1192      705      -487     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [332 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.60%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.22%   -6.61%     
   + Complexity     3911     3599     -312     
   ============================================
     Files           962      976      +14     
     Lines         23957    24189     +232     
     Branches       2362     2362              
   ============================================
   - Hits          13616    12150    -1466     
   - Misses         9149    10968    +1819     
   + Partials       1192     1071     -121     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [133 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (9ff6055) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `8.21%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   48.61%   -8.22%     
   + Complexity     3911     3482     -429     
   ============================================
     Files           962      977      +15     
     Lines         23957    24180     +223     
     Branches       2362     2361       -1     
   ============================================
   - Hits          13616    11756    -1860     
   - Misses         9149    11415    +2266     
   + Partials       1192     1009     -183     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [180 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (98e429d) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **increase** coverage by `1.13%`.
   > The diff coverage is `80.43%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     53.20%   54.33%   +1.13%     
   + Complexity     3900     3851      -49     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24319   -13013     
     Branches       4149     2386    -1763     
   ============================================
   - Hits          19861    13213    -6648     
   + Misses        16489     9914    -6575     
   - Partials        982     1192     +210     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
   | ... and [1348 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b17f32a) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `13.89%`.
   > The diff coverage is `35.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     52.83%   38.93%   -13.90%     
   + Complexity     3793     2794      -999     
   =============================================
     Files          1732      946      -786     
     Lines         36915    23239    -13676     
     Branches       4071     2257     -1814     
   =============================================
   - Hits          19504     9049    -10455     
   + Misses        16434    13387     -3047     
   + Partials        977      803      -174     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1341 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...0cc358d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (e4af2d8) into [master](https://codecov.io/gh/apache/skywalking/commit/30a88b555f44c52f40345aeacd1bc3300446de89?el=desc) (30a88b5) will **increase** coverage by `4.05%`.
   > The diff coverage is `81.48%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     45.56%   49.61%   +4.05%     
   - Complexity     2596     3081     +485     
   ============================================
     Files          1742     1761      +19     
     Lines         37022    37405     +383     
     Branches       4306     4337      +31     
   ============================================
   + Hits          16870    18560    +1690     
   + Misses        19165    17855    -1310     
   - Partials        987      990       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.38% <ø> (+9.52%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.36% <76.36%> (ø)` | `11.00 <11.00> (?)` | |
   | [...ap/server/library/server/tcp/TCPServerManager.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJNYW5hZ2VyLmphdmE=) | `79.48% <79.48%> (ø)` | `5.00 <5.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [30a88b5...be0c599](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (0b1d8c5) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `11.27%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.56%   -11.28%     
   + Complexity     3911     3339      -572     
   =============================================
     Files           962      976       +14     
     Lines         23957    24148      +191     
     Branches       2362     2361        -1     
   =============================================
   - Hits          13616    11003     -2613     
   - Misses         9149    12224     +3075     
   + Partials       1192      921      -271     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [190 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...12d65b8](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (ecac220) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `8.26%`.
   > The diff coverage is `77.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   48.56%   -8.27%     
   + Complexity     3911     2868    -1043     
   ============================================
     Files           962      825     -137     
     Lines         23957    20595    -3362     
     Branches       2362     1959     -403     
   ============================================
   - Hits          13616    10002    -3614     
   - Misses         9149     9827     +678     
   + Partials       1192      766     -426     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `92.00% <92.00%> (ø)` | `4.00 <4.00> (?)` | |
   | ... and [292 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `10.96%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.87%   -10.97%     
   + Complexity     3911     2711     -1200     
   =============================================
     Files           962      826      -136     
     Lines         23957    20551     -3406     
     Branches       2362     1972      -390     
   =============================================
   - Hits          13616     9427     -4189     
   - Misses         9149    10425     +1276     
   + Partials       1192      699      -493     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [314 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (12d65b8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `11.13%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.69%   -11.14%     
   + Complexity     3911     2702     -1209     
   =============================================
     Files           962      808      -154     
     Lines         23957    20043     -3914     
     Branches       2362     1903      -459     
   =============================================
   - Hits          13616     9159     -4457     
   - Misses         9149    10159     +1010     
   + Partials       1192      725      -467     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [352 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...12d65b8](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r573485296



##########
File path: oap-server/server-bootstrap/src/main/resources/zabbix-rules/agent.yaml
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+metricPrefix: meter_vm
+expSuffix: tag({tags -> tags.host = 'vm::' + tags.host}).service(['host'])
+entities:
+  hostPatterns:
+    - .+
+  labels:
+requiredZabbixItemKeys:
+  # cpu
+  - system.cpu.load[all,avg15]
+  - system.cpu.load[all,avg1]
+  - system.cpu.load[all,avg5]
+  - system.cpu.util[,guest]
+  - system.cpu.util[,guest_nice]
+  - system.cpu.util[,idle]
+  - system.cpu.util[,interrupt]
+  - system.cpu.util[,iowait]
+  - system.cpu.util[,nice]
+  - system.cpu.util[,softirq]
+  - system.cpu.util[,steal]
+  - system.cpu.util[,system]
+  - system.cpu.util[,user]
+  # memory
+  - vm.memory.size[available]
+  - vm.memory.size[pavailable]
+  - vm.memory.size[total]
+  - vm.memory.size[pavailable]
+  # swap
+  - system.swap.size[,free]
+  - system.swap.size[,total]
+  - system.swap.size[,pused]
+  # file
+  - vfs.fs.inode[/,pused]
+  - vfs.fs.size[/,total]
+  - vfs.fs.size[/,used]
+  - vfs.dev.read[,ops,avg1]
+  - vfs.dev.write[,ops,avg1]
+
+metrics:
+  # cpu
+  - name: cpu_load1
+    exp: system_cpu_load.tagEqual('2', 'avg1').avg(['host']) * 100
+  - name: cpu_load5
+    exp: system_cpu_load.tagEqual('2', 'avg5').avg(['host']) * 100
+  - name: cpu_load15
+    exp: system_cpu_load.tagEqual('2', 'avg15').avg(['host']) * 100
+  - name: cpu_average_used
+    exp: system_cpu_util.avg(['2', 'host'])
+  - name: cpu_total_percentage
+    exp: system_cpu_util.tagNotEqual('2', 'idle').sum(['host'])
+  # memory
+  - name: memory_total
+    exp: vm_memory_size.tagEqual('1', 'total').avg(['host'])
+  - name: memory_available
+    exp: vm_memory_size.tagEqual('1', 'available').avg(['host'])
+  - name: memory_used
+    exp: vm_memory_size.tagEqual('1', 'total').avg(['host']) - vm_memory_size.tagEqual('1', 'available').avg(['host'])
+  # swap
+  - name: memory_swap_free
+    exp: system_swap_size.tagEqual('2', 'free').avg(['host'])
+  - name: memory_swap_total
+    exp: system_swap_size.tagEqual('2', 'total').avg(['host'])
+  - name: memory_swap_percentage
+    exp: system_swap_size.tagEqual('2', 'pused')
+  # file
+  - name: filesystem_percentage
+    exp: vfs_fs_inode.tagEqual('2', 'pused').avg(['1', 'host'])
+  - name: vfs_fs_size
+    exp: vfs_fs_size.avg(['1', '2', 'host'])
+  - name: disk_read
+    # `* 1024` is for adapting to `divide 1024` by the VM UI template configuration, which converts `byte`->`kb` because of OTEL/Prometheus Node exporter.
+    exp: vfs_dev_read * 1024
+  - name: disk_written
+    # `* 1024` is for adapting to `divide 1024` by the VM UI template configuration, which converts `byte`->`kb` because of OTEL/Prometheus Node exporter.
+    exp: vfs_dev_write * 1024

Review comment:
       FYI @wankai123 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (1ed1a79) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `2.24%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   53.73%   -2.25%     
   + Complexity     3901     3789     -112     
   ============================================
     Files           973      981       +8     
     Lines         24216    24318     +102     
     Branches       2394     2386       -8     
   ============================================
   - Hits          13556    13067     -489     
   - Misses         9464    10146     +682     
   + Partials       1196     1105      -91     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.56%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [137 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r571637352



##########
File path: oap-server/server-bootstrap/src/main/resources/ui-initialized-templates/zabbix.yml
##########
@@ -0,0 +1,157 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# UI templates initialized file includes the default template when the SkyWalking OAP starts up at the first time.
+#
+# Also, SkyWalking would detect the existing templates in the database, once they are missing, all templates in this file
+# could be added automatically.
+
+templates:
+  - name: "Zabbix"

Review comment:
       Let's merge sps into the existing the disk metrics. We could declare them clearly on the UI configuration, rather than providing a totally new dashboard.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (ecac220) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `9.07%`.
   > The diff coverage is `77.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   47.75%   -9.08%     
   + Complexity     3911     2825    -1086     
   ============================================
     Files           962      825     -137     
     Lines         23957    20595    -3362     
     Branches       2362     1959     -403     
   ============================================
   - Hits          13616     9836    -3780     
   - Misses         9149    10007     +858     
   + Partials       1192      752     -440     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `92.00% <92.00%> (ø)` | `4.00 <4.00> (?)` | |
   | ... and [310 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `13.06%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   43.77%   -13.07%     
   + Complexity     3911     3231      -680     
   =============================================
     Files           962      976       +14     
     Lines         23957    24112      +155     
     Branches       2362     2357        -5     
   =============================================
   - Hits          13616    10555     -3061     
   - Misses         9149    12655     +3506     
   + Partials       1192      902      -290     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [239 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (e758af2) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `26.08%`.
   > The diff coverage is `60.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     55.97%   29.89%   -26.09%     
   =============================================
     Files           973     1655      +682     
     Lines         24216    34623    +10407     
     Branches       2394     4555     +2161     
   =============================================
   - Hits          13556    10350     -3206     
   - Misses         9464    23316    +13852     
   + Partials       1196      957      -239     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+47.36%)` | `0.00 <0.00> (-62.00)` | :arrow_up: |
   | [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-81.65%)` | `0.00 <0.00> (-10.00)` | |
   | [.../oap/server/core/server/TCPBinderRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL1RDUEJpbmRlclJlZ2lzdGVySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ap/server/library/server/tcp/TCPServerManager.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/receiver/zabbix/module/ZabbixReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9tb2R1bGUvWmFiYml4UmVjZWl2ZXJNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-8.20%)` | `0.00 <0.00> (-2.00)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `27.77% <27.77%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1700 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (cfeca41) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `13.11%`.
   > The diff coverage is `41.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     53.20%   40.08%   -13.12%     
   + Complexity     3900     2937      -963     
   =============================================
     Files          1751      962      -789     
     Lines         37332    23628    -13704     
     Branches       4149     2319     -1830     
   =============================================
   - Hits          19861     9472    -10389     
   + Misses        16489    13325     -3164     
   + Partials        982      831      -151     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1428 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c4737cc) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `8.74%`.
   > The diff coverage is `35.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   47.23%   -8.75%     
   + Complexity     3901     3428     -473     
   ============================================
     Files           973      980       +7     
     Lines         24216    24196      -20     
     Branches       2394     2377      -17     
   ============================================
   - Hits          13556    11428    -2128     
   - Misses         9464    11789    +2325     
   + Partials       1196      979     -217     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [208 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (da8ec05) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `2.14%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   50.69%   -2.15%     
   + Complexity     3793     3614     -179     
   ============================================
     Files          1732      964     -768     
     Lines         36915    23902   -13013     
     Branches       4071     2326    -1745     
   ============================================
   - Hits          19504    12116    -7388     
   + Misses        16434    10709    -5725     
   - Partials        977     1077     +100     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.39%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.43%   -6.40%     
   + Complexity     3911     2926     -985     
   ============================================
     Files           962      825     -137     
     Lines         23957    20592    -3365     
     Branches       2362     1957     -405     
   ============================================
   - Hits          13616    10386    -3230     
   - Misses         9149     9393     +244     
   + Partials       1192      813     -379     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [282 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...c9678ef](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (663a646) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `7.06%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   48.91%   -7.07%     
   + Complexity     3901     3559     -342     
   ============================================
     Files           973      979       +6     
     Lines         24216    24192      -24     
     Branches       2394     2375      -19     
   ============================================
   - Hits          13556    11833    -1723     
   - Misses         9464    11307    +1843     
   + Partials       1196     1052     -144     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.56%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [192 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `30.00%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   26.83%   -30.01%     
   + Complexity     3911     1701     -2210     
   =============================================
     Files           962      806      -156     
     Lines         23957    19835     -4122     
     Branches       2362     1867      -495     
   =============================================
   - Hits          13616     5322     -8294     
   - Misses         9149    14129     +4980     
   + Partials       1192      384      -808     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `17.22% <ø> (-35.41%)` | `18.00 <0.00> (-44.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [518 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (287e6c6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `11.50%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.32%   -11.51%     
   + Complexity     3911     2686     -1225     
   =============================================
     Files           962      826      -136     
     Lines         23957    20588     -3369     
     Branches       2362     1959      -403     
   =============================================
   - Hits          13616     9332     -4284     
   - Misses         9149    10551     +1402     
   + Partials       1192      705      -487     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [339 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.59%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.23%   -3.60%     
   + Complexity     3911     3721     -190     
   ============================================
     Files           962      975      +13     
     Lines         23957    24167     +210     
     Branches       2362     2359       -3     
   ============================================
   - Hits          13616    12866     -750     
   - Misses         9149    10163    +1014     
   + Partials       1192     1138      -54     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [116 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...c9678ef](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (da8ec05) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `2.00%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   50.83%   -2.01%     
   + Complexity     3793     3627     -166     
   ============================================
     Files          1732      964     -768     
     Lines         36915    23902   -13013     
     Branches       4071     2326    -1745     
   ============================================
   - Hits          19504    12150    -7354     
   + Misses        16434    10670    -5764     
   - Partials        977     1082     +105     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1263 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (4cd8bf0) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `2.85%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.97%   -2.86%     
   + Complexity     3911     3794     -117     
   ============================================
     Files           962      977      +15     
     Lines         23957    24269     +312     
     Branches       2362     2386      +24     
   ============================================
   - Hits          13616    13100     -516     
   - Misses         9149    10010     +861     
   + Partials       1192     1159      -33     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...4cd8bf0](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (da8ec05) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `5.20%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   47.62%   -5.21%     
   + Complexity     3793     3407     -386     
   ============================================
     Files          1732      947     -785     
     Lines         36915    23373   -13542     
     Branches       4071     2256    -1815     
   ============================================
   - Hits          19504    11132    -8372     
   + Misses        16434    11262    -5172     
   - Partials        977      979       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.37%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.45%   -6.38%     
   + Complexity     3911     3609     -302     
   ============================================
     Files           962      976      +14     
     Lines         23957    24200     +243     
     Branches       2362     2379      +17     
   ============================================
   - Hits          13616    12211    -1405     
   - Misses         9149    10901    +1752     
   + Partials       1192     1088     -104     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [121 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c434154) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.51%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.31%   -6.52%     
   + Complexity     3911     3604     -307     
   ============================================
     Files           962      976      +14     
     Lines         23957    24164     +207     
     Branches       2362     2374      +12     
   ============================================
   - Hits          13616    12159    -1457     
   - Misses         9149    10924    +1775     
   + Partials       1192     1081     -111     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [138 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (1ed1a79) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `3.21%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   52.76%   -3.22%     
   + Complexity     3901     3745     -156     
   ============================================
     Files           973      981       +8     
     Lines         24216    24305      +89     
     Branches       2394     2386       -8     
   ============================================
   - Hits          13556    12824     -732     
   - Misses         9464    10395     +931     
   + Partials       1196     1086     -110     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.56%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [149 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b425d99) into [master](https://codecov.io/gh/apache/skywalking/commit/ba6d49ad917bf698d6179ebc90a3a0703e74a4b1?el=desc) (ba6d49a) will **increase** coverage by `5.59%`.
   > The diff coverage is `77.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     49.66%   55.26%   +5.59%     
   - Complexity     3558     3889     +331     
   ============================================
     Files          1752      981     -771     
     Lines         37357    24347   -13010     
     Branches       4146     2388    -1758     
   ============================================
   - Hits          18554    13455    -5099     
   + Misses        17830     9703    -8127     
   - Partials        973     1189     +216     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [1278 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...b425d99](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b425d99) into [master](https://codecov.io/gh/apache/skywalking/commit/ba6d49ad917bf698d6179ebc90a3a0703e74a4b1?el=desc) (ba6d49a) will **increase** coverage by `7.70%`.
   > The diff coverage is `77.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     49.66%   57.37%   +7.70%     
   - Complexity     3558     4002     +444     
   ============================================
     Files          1752      981     -771     
     Lines         37357    24347   -13010     
     Branches       4146     2388    -1758     
   ============================================
   - Hits          18554    13969    -4585     
   + Misses        17830     9159    -8671     
   - Partials        973     1219     +246     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...b425d99](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (4debe3b) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `10.43%`.
   > The diff coverage is `42.09%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     53.20%   42.76%   -10.44%     
   + Complexity     3900     3092      -808     
   =============================================
     Files          1751      962      -789     
     Lines         37332    23650    -13682     
     Branches       4149     2320     -1829     
   =============================================
   - Hits          19861    10113     -9748     
   + Misses        16489    12688     -3801     
   + Partials        982      849      -133     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1408 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `2.32%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   54.50%   -2.33%     
   + Complexity     3911     3818      -93     
   ============================================
     Files           962      976      +14     
     Lines         23957    24236     +279     
     Branches       2362     2380      +18     
   ============================================
   - Hits          13616    13211     -405     
   - Misses         9149     9876     +727     
   + Partials       1192     1149      -43     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [72 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c4737cc) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `20.10%`.
   > The diff coverage is `35.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     55.97%   35.87%   -20.11%     
   + Complexity     3901     2180     -1721     
   =============================================
     Files           973      811      -162     
     Lines         24216    20018     -4198     
     Branches       2394     1912      -482     
   =============================================
   - Hits          13556     7182     -6374     
   - Misses         9464    12297     +2833     
   + Partials       1196      539      -657     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [445 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (287e6c6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `7.34%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   49.49%   -7.35%     
   + Complexity     3911     2877    -1034     
   ============================================
     Files           962      826     -136     
     Lines         23957    20622    -3335     
     Branches       2362     1977     -385     
   ============================================
   - Hits          13616    10206    -3410     
   - Misses         9149     9634     +485     
   + Partials       1192      782     -410     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [286 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b17f32a) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `13.84%`.
   > The diff coverage is `35.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     52.83%   38.99%   -13.85%     
   + Complexity     3793     2800      -993     
   =============================================
     Files          1732      946      -786     
     Lines         36915    23239    -13676     
     Branches       4071     2257     -1814     
   =============================================
   - Hits          19504     9061    -10443     
   + Misses        16434    13376     -3058     
   + Partials        977      802      -175     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1340 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...0cc358d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (12d65b8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `0.00%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   56.82%   -0.01%     
   - Complexity     3911     3952      +41     
   ============================================
     Files           962      977      +15     
     Lines         23957    24254     +297     
     Branches       2362     2381      +19     
   ============================================
   + Hits          13616    13783     +167     
   - Misses         9149     9269     +120     
   - Partials       1192     1202      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [39 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...12d65b8](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] mrproliu commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r571594661



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java
##########
@@ -284,6 +289,11 @@ public void prepare() throws ServiceNotProvidedException, ModuleStartException {
         TopNStreamProcessor.getInstance().setTopNWorkerReportCycle(moduleConfig.getTopNReportPeriod());
         apdexThresholdConfig = new ApdexThresholdConfig(this);
         ApdexMetrics.setDICT(apdexThresholdConfig);
+
+        // TCP manager
+        tcpServerManager = new TCPServerManager(moduleConfig.getTcpHost(),
+            moduleConfig.getTcpBossGroupThreadCount(), moduleConfig.getTcpWorkerGroupThreadCount());
+        this.registerServiceImplementation(TCPBinderRegister.class, new TCPBinderRegisterImpl(tcpServerManager));

Review comment:
       Here is inject the TCP server manager, all TCP server depends on `TCPBinder`. Declare in here because I need to share the TCP connect and handle thread pool.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (93aa01d) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `11.73%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.10%   -11.74%     
   + Complexity     3911     2604     -1307     
   =============================================
     Files           962      807      -155     
     Lines         23957    20051     -3906     
     Branches       2362     1915      -447     
   =============================================
   - Hits          13616     9044     -4572     
   - Misses         9149    10322     +1173     
   + Partials       1192      685      -507     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [335 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...93aa01d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.53%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.30%   -6.54%     
   + Complexity     3911     3603     -308     
   ============================================
     Files           962      976      +14     
     Lines         23957    24189     +232     
     Branches       2362     2362              
   ============================================
   - Hits          13616    12168    -1448     
   - Misses         9149    10943    +1794     
   + Partials       1192     1078     -114     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [131 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c89b4e6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `11.79%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.04%   -11.80%     
   + Complexity     3911     2707     -1204     
   =============================================
     Files           962      825      -137     
     Lines         23957    20556     -3401     
     Branches       2362     1956      -406     
   =============================================
   - Hits          13616     9259     -4357     
   - Misses         9149    10542     +1393     
   + Partials       1192      755      -437     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [332 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (08876d9) into [master](https://codecov.io/gh/apache/skywalking/commit/e138d29778fb458a6fad5f3fd82121c7bba3cc95?el=desc) (e138d29) will **decrease** coverage by `8.07%`.
   > The diff coverage is `38.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.54%   44.46%   -8.08%     
   + Complexity     3793     3233     -560     
   ============================================
     Files          1748      963     -785     
     Lines         37066    23803   -13263     
     Branches       4102     2303    -1799     
   ============================================
   - Hits          19475    10584    -8891     
   + Misses        16620    12304    -4316     
   + Partials        971      915      -56     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `92.85% <ø> (+66.93%)` | `3.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1315 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8c51043...0437d1d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (0c87938) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `15.75%`.
   > The diff coverage is `77.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   41.07%   -15.76%     
   + Complexity     3911     2498     -1413     
   =============================================
     Files           962      825      -137     
     Lines         23957    20575     -3382     
     Branches       2362     1958      -404     
   =============================================
   - Hits          13616     8452     -5164     
   - Misses         9149    11499     +2350     
   + Partials       1192      624      -568     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `92.00% <92.00%> (ø)` | `4.00 <4.00> (?)` | |
   | ... and [364 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (60ca798) into [master](https://codecov.io/gh/apache/skywalking/commit/56c264d1fa640115197ed19bb8a68388c6fa3b95?el=desc) (56c264d) will **decrease** coverage by `5.96%`.
   > The diff coverage is `35.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     48.89%   42.92%   -5.97%     
   + Complexity     3495     2589     -906     
   ============================================
     Files           960      814     -146     
     Lines         23829    20230    -3599     
     Branches       2320     1908     -412     
   ============================================
   - Hits          11650     8683    -2967     
   + Misses        11155    10863     -292     
   + Partials       1024      684     -340     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.19% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [322 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [56c264d...60ca798](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c89b4e6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `20.64%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   36.18%   -20.65%     
   + Complexity     3911     2219     -1692     
   =============================================
     Files           962      824      -138     
     Lines         23957    20345     -3612     
     Branches       2362     1920      -442     
   =============================================
   - Hits          13616     7362     -6254     
   - Misses         9149    12428     +3279     
   + Partials       1192      555      -637     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [430 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...93aa01d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (763bc45) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `17.12%`.
   > The diff coverage is `27.55%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   39.70%   -17.13%     
   + Complexity     3911     2914      -997     
   =============================================
     Files           962      958        -4     
     Lines         23957    23589      -368     
     Branches       2362     2315       -47     
   =============================================
   - Hits          13616     9367     -4249     
   - Misses         9149    13403     +4254     
   + Partials       1192      819      -373     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [283 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...763bc45](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (0cc358d) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `9.96%`.
   > The diff coverage is `35.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   42.86%   -9.97%     
   + Complexity     3793     2493    -1300     
   ============================================
     Files          1732      813     -919     
     Lines         36915    20232   -16683     
     Branches       4071     1901    -2170     
   ============================================
   - Hits          19504     8673   -10831     
   + Misses        16434    10882    -5552     
   + Partials        977      677     -300     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1372 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...0cc358d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (da8ec05) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `2.01%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   50.82%   -2.02%     
   + Complexity     3793     3625     -168     
   ============================================
     Files          1732      964     -768     
     Lines         36915    23902   -13013     
     Branches       4071     2326    -1745     
   ============================================
   - Hits          19504    12147    -7357     
   + Misses        16434    10673    -5761     
   - Partials        977     1082     +105     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (60ca798) into [master](https://codecov.io/gh/apache/skywalking/commit/56c264d1fa640115197ed19bb8a68388c6fa3b95?el=desc) (56c264d) will **increase** coverage by `7.33%`.
   > The diff coverage is `35.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     48.89%   56.22%   +7.33%     
   - Complexity     3495     3886     +391     
   ============================================
     Files           960      965       +5     
     Lines         23829    23906      +77     
     Branches       2320     2320              
   ============================================
   + Hits          11650    13442    +1792     
   + Misses        11155     9301    -1854     
   - Partials       1024     1163     +139     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.19% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [171 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [56c264d...60ca798](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (be0c599) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `4.44%`.
   > The diff coverage is `35.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   52.39%   -4.45%     
   + Complexity     3911     3674     -237     
   ============================================
     Files           962      981      +19     
     Lines         23957    24285     +328     
     Branches       2362     2382      +20     
   ============================================
   - Hits          13616    12723     -893     
   - Misses         9149    10482    +1333     
   + Partials       1192     1080     -112     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [132 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...2635228](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.57%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.26%   -3.58%     
   + Complexity     3911     3726     -185     
   ============================================
     Files           962      975      +13     
     Lines         23957    24167     +210     
     Branches       2362     2359       -3     
   ============================================
   - Hits          13616    12872     -744     
   - Misses         9149    10160    +1011     
   + Partials       1192     1135      -57     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [114 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (49242fd) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `12.42%`.
   > The diff coverage is `67.21%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   44.41%   -12.43%     
   + Complexity     3911     3062      -849     
   =============================================
     Files           962     1763      +801     
     Lines         23957    37598    +13641     
     Branches       2362     4174     +1812     
   =============================================
   + Hits          13616    16698     +3082     
   - Misses         9149    19903    +10754     
   + Partials       1192      997      -195     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.66% <ø> (+4.03%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `42.20% <42.20%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `50.00% <50.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `80.00% <80.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `81.25% <81.25%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `89.18% <89.18%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1329 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (ecac220) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `11.46%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.36%   -11.47%     
   + Complexity     3911     2698     -1213     
   =============================================
     Files           962      825      -137     
     Lines         23957    20547     -3410     
     Branches       2362     1954      -408     
   =============================================
   - Hits          13616     9322     -4294     
   - Misses         9149    10493     +1344     
   + Partials       1192      732      -460     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [338 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (13e80f8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `15.12%`.
   > The diff coverage is `27.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   41.70%   -15.13%     
   + Complexity     3911     2499     -1412     
   =============================================
     Files           962      825      -137     
     Lines         23957    20414     -3543     
     Branches       2362     1925      -437     
   =============================================
   - Hits          13616     8514     -5102     
   - Misses         9149    11241     +2092     
   + Partials       1192      659      -533     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [369 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...6e44b52](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (663a646) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `8.69%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   47.28%   -8.70%     
   + Complexity     3901     3476     -425     
   ============================================
     Files           973      979       +6     
     Lines         24216    24192      -24     
     Branches       2394     2375      -19     
   ============================================
   - Hits          13556    11438    -2118     
   - Misses         9464    11737    +2273     
   + Partials       1196     1017     -179     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.56%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [220 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (1ed1a79) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `4.99%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   50.98%   -5.00%     
   + Complexity     3901     3653     -248     
   ============================================
     Files           973      981       +8     
     Lines         24216    24269      +53     
     Branches       2394     2385       -9     
   ============================================
   - Hits          13556    12373    -1183     
   - Misses         9464    10844    +1380     
   + Partials       1196     1052     -144     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.56%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [167 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b17f32a) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `5.45%`.
   > The diff coverage is `35.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   47.37%   -5.46%     
   + Complexity     3793     3435     -358     
   ============================================
     Files          1732      964     -768     
     Lines         36915    23886   -13029     
     Branches       4071     2325    -1746     
   ============================================
   - Hits          19504    11317    -8187     
   + Misses        16434    11589    -4845     
   - Partials        977      980       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1273 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (287e6c6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `5.21%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   51.61%   -5.22%     
   + Complexity     3911     3010     -901     
   ============================================
     Files           962      826     -136     
     Lines         23957    20640    -3317     
     Branches       2362     1978     -384     
   ============================================
   - Hits          13616    10654    -2962     
   + Misses         9149     9130      -19     
   + Partials       1192      856     -336     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [253 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (98e429d) into [master](https://codecov.io/gh/apache/skywalking/commit/ba6d49ad917bf698d6179ebc90a3a0703e74a4b1?el=desc) (ba6d49a) will **increase** coverage by `2.29%`.
   > The diff coverage is `81.43%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     49.66%   51.96%   +2.29%     
   - Complexity     3558     3851     +293     
   ============================================
     Files          1752     1771      +19     
     Lines         37357    37735     +378     
     Branches       4146     4179      +33     
   ============================================
   + Hits          18554    19608    +1054     
   + Misses        17830    17131     -699     
   - Partials        973      996      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.38% <ø> (+9.52%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.36% <76.36%> (ø)` | `11.00 <11.00> (?)` | |
   | [...ap/server/library/server/tcp/TCPServerManager.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJNYW5hZ2VyLmphdmE=) | `79.48% <79.48%> (ø)` | `5.00 <5.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [108 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...b425d99](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **increase** coverage by `0.53%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     56.83%   57.36%   +0.53%     
   + Complexity     3911      802    -3109     
   ============================================
     Files           962      170     -792     
     Lines         23957     4133   -19824     
     Branches       2362      477    -1885     
   ============================================
   - Hits          13616     2371   -11245     
   + Misses         9149     1459    -7690     
   + Partials       1192      303     -889     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
   | [...walking/apm/agent/core/context/ContextCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0Q2Fycmllci5qYXZh) | `46.29% <0.00%> (-29.63%)` | `8.00% <0.00%> (-2.00%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-25.65%)` | `6.00% <0.00%> (-4.00%)` | |
   | [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `75.00% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | |
   | [...mponent/command/ConfigurationDiscoveryCommand.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlDb21tYW5kLmphdmE=) | `69.56% <0.00%> (-17.40%)` | `7.00% <0.00%> (-1.00%)` | |
   | [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `67.60% <0.00%> (-12.68%)` | `11.00% <0.00%> (-4.00%)` | |
   | [...ing/apm/agent/core/context/trace/TraceSegment.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9UcmFjZVNlZ21lbnQuamF2YQ==) | `65.00% <0.00%> (-12.50%)` | `8.00% <0.00%> (-2.00%)` | |
   | [...pm/agent/core/context/ids/DistributedTraceIds.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvRGlzdHJpYnV0ZWRUcmFjZUlkcy5qYXZh) | `66.66% <0.00%> (-11.12%)` | `3.00% <0.00%> (-1.00%)` | |
   | [...m/network/trace/component/command/BaseCommand.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9jb21tYW5kL0Jhc2VDb21tYW5kLmphdmE=) | `92.30% <0.00%> (-7.70%)` | `3.00% <0.00%> (-1.00%)` | |
   | ... and [805 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (4debe3b) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `2.34%`.
   > The diff coverage is `48.48%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     53.20%   50.85%   -2.35%     
   + Complexity     3900     3616     -284     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24271   -13061     
     Branches       4149     2382    -1767     
   ============================================
   - Hits          19861    12343    -7518     
   + Misses        16489    10899    -5590     
   - Partials        982     1029      +47     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1374 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (4debe3b) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `6.83%`.
   > The diff coverage is `46.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     53.20%   46.36%   -6.84%     
   + Complexity     3900     3412     -488     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24221   -13111     
     Branches       4149     2380    -1769     
   ============================================
   - Hits          19861    11231    -8630     
   + Misses        16489    12049    -4440     
   + Partials        982      941      -41     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1389 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (287e6c6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `7.65%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   49.18%   -7.66%     
   + Complexity     3911     2868    -1043     
   ============================================
     Files           962      826     -136     
     Lines         23957    20611    -3346     
     Branches       2362     1960     -402     
   ============================================
   - Hits          13616    10137    -3479     
   - Misses         9149     9710     +561     
   + Partials       1192      764     -428     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [294 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c89b4e6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `13.60%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   43.22%   -13.61%     
   + Complexity     3911     2632     -1279     
   =============================================
     Files           962      825      -137     
     Lines         23957    20556     -3401     
     Branches       2362     1956      -406     
   =============================================
   - Hits          13616     8886     -4730     
   - Misses         9149    10964     +1815     
   + Partials       1192      706      -486     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [346 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (be0c599) into [master](https://codecov.io/gh/apache/skywalking/commit/30a88b555f44c52f40345aeacd1bc3300446de89?el=desc) (30a88b5) will **increase** coverage by `0.61%`.
   > The diff coverage is `35.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     45.56%   46.17%   +0.61%     
   - Complexity     2596     3340     +744     
   ============================================
     Files          1742      980     -762     
     Lines         37022    24191   -12831     
     Branches       4306     2377    -1929     
   ============================================
   - Hits          16870    11171    -5699     
   + Misses        19165    12088    -7077     
   + Partials        987      932      -55     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [1328 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [30a88b5...be0c599](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (4cd8bf0) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **increase** coverage by `0.37%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     56.83%   57.20%   +0.37%     
   - Complexity     3911     3981      +70     
   ============================================
     Files           962      977      +15     
     Lines         23957    24282     +325     
     Branches       2362     2386      +24     
   ============================================
   + Hits          13616    13891     +275     
   - Misses         9149     9186      +37     
   - Partials       1192     1205      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...4cd8bf0](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (08876d9) into [master](https://codecov.io/gh/apache/skywalking/commit/e138d29778fb458a6fad5f3fd82121c7bba3cc95?el=desc) (e138d29) will **decrease** coverage by `7.40%`.
   > The diff coverage is `38.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.54%   45.14%   -7.41%     
   + Complexity     3793     3269     -524     
   ============================================
     Files          1748      963     -785     
     Lines         37066    23803   -13263     
     Branches       4102     2303    -1799     
   ============================================
   - Hits          19475    10745    -8730     
   + Misses        16620    12129    -4491     
   + Partials        971      929      -42     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `92.85% <ø> (+66.93%)` | `3.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1311 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8c51043...0437d1d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b425d99) into [master](https://codecov.io/gh/apache/skywalking/commit/ba6d49ad917bf698d6179ebc90a3a0703e74a4b1?el=desc) (ba6d49a) will **increase** coverage by `7.70%`.
   > The diff coverage is `77.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     49.66%   57.37%   +7.70%     
   - Complexity     3558     4002     +444     
   ============================================
     Files          1752      981     -771     
     Lines         37357    24347   -13010     
     Branches       4146     2388    -1758     
   ============================================
   - Hits          18554    13969    -4585     
   + Misses        17830     9159    -8671     
   - Partials        973     1219     +246     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...b425d99](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `18.46%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   38.36%   -18.47%     
   + Complexity     3911     2766     -1145     
   =============================================
     Files           962      958        -4     
     Lines         23957    23465      -492     
     Branches       2362     2274       -88     
   =============================================
   - Hits          13616     9003     -4613     
   - Misses         9149    13692     +4543     
   + Partials       1192      770      -422     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `17.22% <ø> (-35.41%)` | `18.00 <0.00> (-44.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [315 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (e758af2) into [master](https://codecov.io/gh/apache/skywalking/commit/56c264d1fa640115197ed19bb8a68388c6fa3b95?el=desc) (56c264d) will **decrease** coverage by `18.99%`.
   > The diff coverage is `60.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     48.89%   29.89%   -19.00%     
   =============================================
     Files           960     1655      +695     
     Lines         23829    34623    +10794     
     Branches       2320     4555     +2235     
   =============================================
   - Hits          11650    10350     -1300     
   - Misses        11155    23316    +12161     
   + Partials       1024      957       -67     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+47.36%)` | `0.00 <0.00> (-62.00)` | :arrow_up: |
   | [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-78.35%)` | `0.00 <0.00> (-10.00)` | |
   | [.../oap/server/core/server/TCPBinderRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL1RDUEJpbmRlclJlZ2lzdGVySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ap/server/library/server/tcp/TCPServerManager.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/receiver/zabbix/module/ZabbixReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9tb2R1bGUvWmFiYml4UmVjZWl2ZXJNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-8.34%)` | `0.00 <0.00> (-2.00)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `27.77% <27.77%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1676 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [56c264d...95e2d94](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (cfe3021) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `12.30%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     52.83%   40.53%   -12.31%     
   + Complexity     3793     2358     -1435     
   =============================================
     Files          1732      796      -936     
     Lines         36915    19669    -17246     
     Branches       4071     1840     -2231     
   =============================================
   - Hits          19504     7972    -11532     
   + Misses        16434    11075     -5359     
   + Partials        977      622      -355     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1392 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (e758af2) into [master](https://codecov.io/gh/apache/skywalking/commit/56c264d1fa640115197ed19bb8a68388c6fa3b95?el=desc) (56c264d) will **decrease** coverage by `18.99%`.
   > The diff coverage is `60.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     48.89%   29.89%   -19.00%     
   =============================================
     Files           960     1655      +695     
     Lines         23829    34623    +10794     
     Branches       2320     4555     +2235     
   =============================================
   - Hits          11650    10350     -1300     
   - Misses        11155    23316    +12161     
   + Partials       1024      957       -67     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `100.00% <ø> (+47.36%)` | `0.00 <0.00> (-62.00)` | :arrow_up: |
   | [...e/skywalking/oap/server/core/CoreModuleConfig.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZUNvbmZpZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-2.00)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-78.35%)` | `0.00 <0.00> (-10.00)` | |
   | [.../oap/server/core/server/TCPBinderRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL1RDUEJpbmRlclJlZ2lzdGVySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ap/server/library/server/tcp/TCPServerManager.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/receiver/zabbix/module/ZabbixReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9tb2R1bGUvWmFiYml4UmVjZWl2ZXJNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-8.34%)` | `0.00 <0.00> (-2.00)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `27.77% <27.77%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1676 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [56c264d...60ca798](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (bd822db) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `20.00%`.
   > The diff coverage is `72.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     53.20%   33.19%   -20.01%     
   + Complexity     3900     2047     -1853     
   =============================================
     Files          1751      811      -940     
     Lines         37332    20025    -17307     
     Branches       4149     1896     -2253     
   =============================================
   - Hits          19861     6647    -13214     
   + Misses        16489    12888     -3601     
   + Partials        982      490      -492     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...sticsearch/StorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | `5.06% <0.00%> (-61.61%)` | `2.00 <0.00> (-7.00)` | |
   | ... and [1521 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (cfeca41) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `13.27%`.
   > The diff coverage is `41.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     53.20%   39.92%   -13.28%     
   + Complexity     3900     2928      -972     
   =============================================
     Files          1751      962      -789     
     Lines         37332    23627    -13705     
     Branches       4149     2317     -1832     
   =============================================
   - Hits          19861     9433    -10428     
   + Misses        16489    13366     -3123     
   + Partials        982      828      -154     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1429 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (98e429d) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `7.55%`.
   > The diff coverage is `48.48%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     53.20%   45.64%   -7.56%     
   + Complexity     3900     2772    -1128     
   ============================================
     Files          1751      830     -921     
     Lines         37332    20612   -16720     
     Branches       4149     1958    -2191     
   ============================================
   - Hits          19861     9408   -10453     
   + Misses        16489    10462    -6027     
   + Partials        982      742     -240     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1443 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (cfeca41) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `11.61%`.
   > The diff coverage is `41.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     53.20%   41.58%   -11.62%     
   + Complexity     3900     3065      -835     
   =============================================
     Files          1751      962      -789     
     Lines         37332    23655    -13677     
     Branches       4149     2320     -1829     
   =============================================
   - Hits          19861     9837    -10024     
   + Misses        16489    12942     -3547     
   + Partials        982      876      -106     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1407 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `5.40%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   51.43%   -5.41%     
   + Complexity     3911     3631     -280     
   ============================================
     Files           962      976      +14     
     Lines         23957    24159     +202     
     Branches       2362     2375      +13     
   ============================================
   - Hits          13616    12426    -1190     
   - Misses         9149    10703    +1554     
   + Partials       1192     1030     -162     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [126 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `12.12%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   44.71%   -12.13%     
   + Complexity     3911     2698     -1213     
   =============================================
     Files           962      825      -137     
     Lines         23957    20556     -3401     
     Branches       2362     1956      -406     
   =============================================
   - Hits          13616     9191     -4425     
   - Misses         9149    10641     +1492     
   + Partials       1192      724      -468     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [331 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r573365423



##########
File path: oap-server/server-bootstrap/src/main/resources/zabbix-rules/agent.yaml
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+metricPrefix: meter_vm
+expSuffix: tag({tags -> tags.host = 'vm::' + tags.host}).service(['host'])
+entities:
+  hostPatterns:
+    - .+
+  labels:
+requiredZabbixItemKeys:
+  # cpu
+  - system.cpu.load[all,avg15]
+  - system.cpu.load[all,avg1]
+  - system.cpu.load[all,avg5]
+  - system.cpu.util[,guest]
+  - system.cpu.util[,guest_nice]
+  - system.cpu.util[,idle]
+  - system.cpu.util[,interrupt]
+  - system.cpu.util[,iowait]
+  - system.cpu.util[,nice]
+  - system.cpu.util[,softirq]
+  - system.cpu.util[,steal]
+  - system.cpu.util[,system]
+  - system.cpu.util[,user]
+  # memory
+  - vm.memory.size[available]
+  - vm.memory.size[pavailable]
+  - vm.memory.size[total]
+  - vm.memory.size[pavailable]
+  # swap
+  - system.swap.size[,free]
+  - system.swap.size[,total]
+  - system.swap.size[,pused]
+  # file
+  - vfs.fs.inode[/,pused]
+  - vfs.fs.size[/,total]
+  - vfs.fs.size[/,used]
+  - vfs.dev.read[,ops,avg1]
+  - vfs.dev.write[,ops,avg1]
+
+metrics:
+  # cpu
+  - name: cpu_load1
+    exp: system_cpu_load.tagEqual('2', 'avg1').avg(['host']) * 100
+  - name: cpu_load5
+    exp: system_cpu_load.tagEqual('2', 'avg5').avg(['host']) * 100
+  - name: cpu_load15
+    exp: system_cpu_load.tagEqual('2', 'avg15').avg(['host']) * 100
+  - name: cpu_average_used
+    exp: system_cpu_util.avg(['2', 'host'])
+  - name: cpu_total_percentage
+    exp: system_cpu_util.tagNotEqual('2', 'idle').sum(['host'])
+  # memory
+  - name: memory_total
+    exp: vm_memory_size.tagEqual('1', 'total').avg(['host'])
+  - name: memory_available
+    exp: vm_memory_size.tagEqual('1', 'available').avg(['host'])
+  - name: memory_used
+    exp: vm_memory_size.tagEqual('1', 'total').avg(['host']) - vm_memory_size.tagEqual('1', 'available').avg(['host'])
+  # swap
+  - name: memory_swap_free
+    exp: system_swap_size.tagEqual('2', 'free').avg(['host'])
+  - name: memory_swap_total
+    exp: system_swap_size.tagEqual('2', 'total').avg(['host'])
+  - name: memory_swap_percentage
+    exp: system_swap_size.tagEqual('2', 'pused')
+  # file
+  - name: filesystem_percentage
+    exp: vfs_fs_inode.tagEqual('2', 'pused').avg(['1', 'host'])
+  - name: vfs_fs_size
+    exp: vfs_fs_size.avg(['1', '2', 'host'])
+  - name: disk_read
+    # Adapt the VM UI template

Review comment:
       ```suggestion
       # `* 1024` is for adapting to `divide 1024` by the VM UI template configuration, which converts `byte`->`kb` because of OTEL/Prometheus Node exporter.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c89b4e6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `19.91%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   36.91%   -19.92%     
   + Complexity     3911     2261     -1650     
   =============================================
     Files           962      824      -138     
     Lines         23957    20345     -3612     
     Branches       2362     1920      -442     
   =============================================
   - Hits          13616     7511     -6105     
   - Misses         9149    12277     +3128     
   + Partials       1192      557      -635     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [421 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c434154) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.51%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.32%   -3.52%     
   + Complexity     3911     3771     -140     
   ============================================
     Files           962      977      +15     
     Lines         23957    24247     +290     
     Branches       2362     2384      +22     
   ============================================
   - Hits          13616    12929     -687     
   - Misses         9149    10167    +1018     
   + Partials       1192     1151      -41     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [79 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (4a024ac) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `15.79%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   41.03%   -15.80%     
   + Complexity     3911     2473     -1438     
   =============================================
     Files           962      808      -154     
     Lines         23957    20030     -3927     
     Branches       2362     1901      -461     
   =============================================
   - Hits          13616     8220     -5396     
   - Misses         9149    11155     +2006     
   + Partials       1192      655      -537     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [392 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...4cd8bf0](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r571610225



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java
##########
@@ -284,6 +289,11 @@ public void prepare() throws ServiceNotProvidedException, ModuleStartException {
         TopNStreamProcessor.getInstance().setTopNWorkerReportCycle(moduleConfig.getTopNReportPeriod());
         apdexThresholdConfig = new ApdexThresholdConfig(this);
         ApdexMetrics.setDICT(apdexThresholdConfig);
+
+        // TCP manager
+        tcpServerManager = new TCPServerManager(moduleConfig.getTcpHost(),
+            moduleConfig.getTcpBossGroupThreadCount(), moduleConfig.getTcpWorkerGroupThreadCount());
+        this.registerServiceImplementation(TCPBinderRegister.class, new TCPBinderRegisterImpl(tcpServerManager));

Review comment:
       Zabbix server with its TCP protocol is very unique, how this could share with others? Could you provide a real or closing real(in theory) case to support this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c89b4e6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `9.06%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   47.77%   -9.07%     
   + Complexity     3911     3476     -435     
   ============================================
     Files           962      976      +14     
     Lines         23957    24173     +216     
     Branches       2362     2362              
   ============================================
   - Hits          13616    11548    -2068     
   - Misses         9149    11582    +2433     
   + Partials       1192     1043     -149     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [176 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (12d65b8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `16.78%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   40.04%   -16.79%     
   + Complexity     3911     2438     -1473     
   =============================================
     Files           962      807      -155     
     Lines         23957    20013     -3944     
     Branches       2362     1899      -463     
   =============================================
   - Hits          13616     8015     -5601     
   - Misses         9149    11362     +2213     
   + Partials       1192      636      -556     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [415 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...12d65b8](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (98e429d) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `0.14%`.
   > The diff coverage is `50.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     53.20%   53.05%   -0.15%     
   + Complexity     3900     3769     -131     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24275   -13057     
     Branches       4149     2381    -1768     
   ============================================
   - Hits          19861    12879    -6982     
   + Misses        16489    10223    -6266     
   - Partials        982     1173     +191     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1351 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] mrproliu commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r572996633



##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/Expression.java
##########
@@ -105,12 +106,11 @@ public SampleFamily propertyMissing(String metricName) {
                     return SampleFamily.EMPTY;
                 }
                 if (sampleFamilies.containsKey(metricName)) {
+                    ExpressionParsingContext.get().ifPresent(ctx -> ctx.samples.add(metricName));
                     return sampleFamilies.get(metricName);
                 }
-                if (!ExpressionParsingContext.get().isPresent()) {
-                    log.warn("{} referred by \"{}\" doesn't exist in {}", metricName, literal, sampleFamilies.keySet());
-                }
-                return SampleFamily.EMPTY;
+                // Using finder, support "."
+                return new SampleFamilyFinder(metricName, literal, sampleFamilies);

Review comment:
       Replace all `.` to `_` in the Zabbix metric name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (12d65b8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `0.71%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   56.11%   -0.72%     
   + Complexity     3911     3904       -7     
   ============================================
     Files           962      977      +15     
     Lines         23957    24254     +297     
     Branches       2362     2381      +19     
   ============================================
   - Hits          13616    13611       -5     
   - Misses         9149     9456     +307     
   + Partials       1192     1187       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [61 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...12d65b8](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (763bc45) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `17.12%`.
   > The diff coverage is `27.55%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   39.70%   -17.13%     
   + Complexity     3911     2914      -997     
   =============================================
     Files           962      958        -4     
     Lines         23957    23589      -368     
     Branches       2362     2315       -47     
   =============================================
   - Hits          13616     9367     -4249     
   - Misses         9149    13403     +4254     
   + Partials       1192      819      -373     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [283 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...1e6bce6](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b17f32a) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `7.10%`.
   > The diff coverage is `35.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   45.72%   -7.11%     
   + Complexity     3793     3333     -460     
   ============================================
     Files          1732      963     -769     
     Lines         36915    23838   -13077     
     Branches       4071     2321    -1750     
   ============================================
   - Hits          19504    10900    -8604     
   + Misses        16434    11982    -4452     
   + Partials        977      956      -21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1285 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...0cc358d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (12d65b8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `2.80%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   54.03%   -2.81%     
   + Complexity     3911     3814      -97     
   ============================================
     Files           962      977      +15     
     Lines         23957    24241     +284     
     Branches       2362     2381      +19     
   ============================================
   - Hits          13616    13098     -518     
   - Misses         9149     9995     +846     
   + Partials       1192     1148      -44     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [89 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...12d65b8](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b48699d) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `14.73%`.
   > The diff coverage is `27.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   42.10%   -14.74%     
   + Complexity     3911     3031      -880     
   =============================================
     Files           962      958        -4     
     Lines         23957    23507      -450     
     Branches       2362     2277       -85     
   =============================================
   - Hits          13616     9897     -3719     
   - Misses         9149    12762     +3613     
   + Partials       1192      848      -344     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [266 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...763bc45](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (ecac220) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `12.30%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   44.53%   -12.31%     
   + Complexity     3911     2598     -1313     
   =============================================
     Files           962      807      -155     
     Lines         23957    20041     -3916     
     Branches       2362     1901      -461     
   =============================================
   - Hits          13616     8925     -4691     
   - Misses         9149    10413     +1264     
   + Partials       1192      703      -489     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [361 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `8.50%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   48.33%   -8.51%     
   + Complexity     3911     2836    -1075     
   ============================================
     Files           962      826     -136     
     Lines         23957    20587    -3370     
     Branches       2362     1973     -389     
   ============================================
   - Hits          13616     9950    -3666     
   - Misses         9149     9893     +744     
   + Partials       1192      744     -448     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [285 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (60ca798) into [master](https://codecov.io/gh/apache/skywalking/commit/56c264d1fa640115197ed19bb8a68388c6fa3b95?el=desc) (56c264d) will **increase** coverage by `6.62%`.
   > The diff coverage is `35.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     48.89%   55.51%   +6.62%     
   - Complexity     3495     3836     +341     
   ============================================
     Files           960      965       +5     
     Lines         23829    23878      +49     
     Branches       2320     2315       -5     
   ============================================
   + Hits          11650    13255    +1605     
   + Misses        11155     9478    -1677     
   - Partials       1024     1145     +121     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.19% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [169 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [56c264d...60ca798](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (bd822db) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **increase** coverage by `0.72%`.
   > The diff coverage is `78.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     53.20%   53.92%   +0.72%     
   + Complexity     3900     3794     -106     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24317   -13015     
     Branches       4149     2370    -1779     
   ============================================
   - Hits          19861    13113    -6748     
   + Misses        16489    10106    -6383     
   - Partials        982     1098     +116     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | ... and [1366 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (ecac220) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `8.26%`.
   > The diff coverage is `77.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   48.56%   -8.27%     
   + Complexity     3911     2868    -1043     
   ============================================
     Files           962      825     -137     
     Lines         23957    20595    -3362     
     Branches       2362     1959     -403     
   ============================================
   - Hits          13616    10002    -3614     
   - Misses         9149     9827     +678     
   + Partials       1192      766     -426     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `92.00% <92.00%> (ø)` | `4.00 <4.00> (?)` | |
   | ... and [292 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.39%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.43%   -6.40%     
   + Complexity     3911     2926     -985     
   ============================================
     Files           962      825     -137     
     Lines         23957    20592    -3365     
     Branches       2362     1957     -405     
   ============================================
   - Hits          13616    10386    -3230     
   - Misses         9149     9393     +244     
   + Partials       1192      813     -379     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [282 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c434154) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.90%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   49.92%   -6.91%     
   + Complexity     3911     3586     -325     
   ============================================
     Files           962      976      +14     
     Lines         23957    24161     +204     
     Branches       2362     2374      +12     
   ============================================
   - Hits          13616    12063    -1553     
   - Misses         9149    11020    +1871     
   + Partials       1192     1078     -114     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [149 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.42%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.40%   -3.43%     
   + Complexity     3911     3767     -144     
   ============================================
     Files           962      976      +14     
     Lines         23957    24177     +220     
     Branches       2362     2376      +14     
   ============================================
   - Hits          13616    12912     -704     
   - Misses         9149    10144     +995     
   + Partials       1192     1121      -71     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [91 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (08876d9) into [master](https://codecov.io/gh/apache/skywalking/commit/e138d29778fb458a6fad5f3fd82121c7bba3cc95?el=desc) (e138d29) will **decrease** coverage by `5.88%`.
   > The diff coverage is `38.67%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.54%   46.65%   -5.89%     
   + Complexity     3793     3359     -434     
   ============================================
     Files          1748      963     -785     
     Lines         37066    23822   -13244     
     Branches       4102     2318    -1784     
   ============================================
   - Hits          19475    11114    -8361     
   + Misses        16620    11745    -4875     
   + Partials        971      963       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `92.85% <ø> (+66.93%)` | `3.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8c51043...cf8651a](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r568289580



##########
File path: docs/en/setup/backend/backend-zabbix.md
##########
@@ -0,0 +1,67 @@
+# Zabbix Receiver
+Zabbix receiver is accepting the metrics of [Zabbix Agent Active Checks protocol](https://www.zabbix.com/documentation/current/manual/appendix/items/activepassive#active_checks) fromat into the [Meter System](./../../concepts-and-designs/meter.md).
+
+## Module define
+```yaml
+receiver-zabbix:
+  selector: ${SW_RECEIVER_METER:default}
+  default:
+    # Export tcp port, Zabbix agent could connected and transport data
+    port: 13800
+    # Enable config when receive agent request
+    activeFiles: agent.yaml
+```
+
+## Configuration file
+Zabbix receiver is configured via a configuration file. The configuration file defines everything related to receiving 
+ from agents, as well as which rule files to load.
+ 
+OAP can load the configuration at bootstrap. If the new configuration is not well-formed, OAP fails to start up. The files
+are located at `$CLASSPATH/zabbix-receive-config`.

Review comment:
       ```suggestion
   are located at `$CLASSPATH/zabbix-rules`.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (12d65b8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `0.68%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   56.14%   -0.69%     
   + Complexity     3911     3909       -2     
   ============================================
     Files           962      977      +15     
     Lines         23957    24254     +297     
     Branches       2362     2381      +19     
   ============================================
   + Hits          13616    13618       +2     
   - Misses         9149     9449     +300     
   + Partials       1192     1187       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [57 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...12d65b8](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (e4af2d8) into [master](https://codecov.io/gh/apache/skywalking/commit/30a88b555f44c52f40345aeacd1bc3300446de89?el=desc) (30a88b5) will **decrease** coverage by `10.16%`.
   > The diff coverage is `35.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     45.56%   35.40%   -10.17%     
   + Complexity     2596     2152      -444     
   =============================================
     Files          1742      812      -930     
     Lines         37022    20034    -16988     
     Branches       4306     1912     -2394     
   =============================================
   - Hits          16870     7093     -9777     
   + Misses        19165    12404     -6761     
   + Partials        987      537      -450     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [1365 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [30a88b5...be0c599](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (08876d9) into [master](https://codecov.io/gh/apache/skywalking/commit/e138d29778fb458a6fad5f3fd82121c7bba3cc95?el=desc) (e138d29) will **decrease** coverage by `5.99%`.
   > The diff coverage is `38.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.54%   46.54%   -6.00%     
   + Complexity     3793     3350     -443     
   ============================================
     Files          1748      963     -785     
     Lines         37066    23822   -13244     
     Branches       4102     2318    -1784     
   ============================================
   - Hits          19475    11088    -8387     
   + Misses        16620    11773    -4847     
   + Partials        971      961      -10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `92.85% <ø> (+66.93%)` | `3.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8c51043...0437d1d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `11.33%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.50%   -11.34%     
   + Complexity     3911     2690     -1221     
   =============================================
     Files           962      826      -136     
     Lines         23957    20551     -3406     
     Branches       2362     1972      -390     
   =============================================
   - Hits          13616     9351     -4265     
   - Misses         9149    10498     +1349     
   + Partials       1192      702      -490     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [323 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.77%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.06%   -6.78%     
   + Complexity     3911     3593     -318     
   ============================================
     Files           962      976      +14     
     Lines         23957    24189     +232     
     Branches       2362     2362              
   ============================================
   - Hits          13616    12110    -1506     
   - Misses         9149    11017    +1868     
   + Partials       1192     1062     -130     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [134 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (5b03bfb) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.57%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.25%   -3.58%     
   + Complexity     3911     3729     -182     
   ============================================
     Files           962      975      +13     
     Lines         23957    24178     +221     
     Branches       2362     2376      +14     
   ============================================
   - Hits          13616    12877     -739     
   - Misses         9149    10166    +1017     
   + Partials       1192     1135      -57     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [103 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (4debe3b) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `8.02%`.
   > The diff coverage is `43.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     53.20%   45.17%   -8.03%     
   + Complexity     3900     3255     -645     
   ============================================
     Files          1751      963     -788     
     Lines         37332    23715   -13617     
     Branches       4149     2327    -1822     
   ============================================
   - Hits          19861    10713    -9148     
   + Misses        16489    12101    -4388     
   + Partials        982      901      -81     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `27.27% <ø> (-36.37%)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1394 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c434154) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.07%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.76%   -3.08%     
   + Complexity     3911     3798     -113     
   ============================================
     Files           962      977      +15     
     Lines         23957    24247     +290     
     Branches       2362     2384      +22     
   ============================================
   - Hits          13616    13036     -580     
   - Misses         9149    10059     +910     
   + Partials       1192     1152      -40     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [68 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b17f32a) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `6.39%`.
   > The diff coverage is `35.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   46.43%   -6.40%     
   + Complexity     3793     3377     -416     
   ============================================
     Files          1732      963     -769     
     Lines         36915    23838   -13077     
     Branches       4071     2321    -1750     
   ============================================
   - Hits          19504    11070    -8434     
   + Misses        16434    11797    -4637     
   + Partials        977      971       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1282 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...0cc358d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (ecac220) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `10.41%`.
   > The diff coverage is `77.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   46.42%   -10.42%     
   + Complexity     3911     2747     -1164     
   =============================================
     Files           962      825      -137     
     Lines         23957    20564     -3393     
     Branches       2362     1954      -408     
   =============================================
   - Hits          13616     9546     -4070     
   - Misses         9149    10272     +1123     
   + Partials       1192      746      -446     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `92.00% <92.00%> (ø)` | `4.00 <4.00> (?)` | |
   | ... and [339 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b425d99) into [master](https://codecov.io/gh/apache/skywalking/commit/ba6d49ad917bf698d6179ebc90a3a0703e74a4b1?el=desc) (ba6d49a) will **increase** coverage by `7.57%`.
   > The diff coverage is `77.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     49.66%   57.24%   +7.57%     
   - Complexity     3558     3998     +440     
   ============================================
     Files          1752      981     -771     
     Lines         37357    24347   -13010     
     Branches       4146     2388    -1758     
   ============================================
   - Hits          18554    13937    -4617     
   + Misses        17830     9202    -8628     
   - Partials        973     1208     +235     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...b425d99](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (cfe3021) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `12.52%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     52.83%   40.30%   -12.53%     
   + Complexity     3793     2351     -1442     
   =============================================
     Files          1732      796      -936     
     Lines         36915    19669    -17246     
     Branches       4071     1840     -2231     
   =============================================
   - Hits          19504     7928    -11576     
   + Misses        16434    11120     -5314     
   + Partials        977      621      -356     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1392 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (be0c599) into [master](https://codecov.io/gh/apache/skywalking/commit/30a88b555f44c52f40345aeacd1bc3300446de89?el=desc) (30a88b5) will **increase** coverage by `5.28%`.
   > The diff coverage is `35.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     45.56%   50.85%   +5.28%     
   - Complexity     2596     3608    +1012     
   ============================================
     Files          1742      981     -761     
     Lines         37022    24272   -12750     
     Branches       4306     2382    -1924     
   ============================================
   - Hits          16870    12343    -4527     
   + Misses        19165    10887    -8278     
   - Partials        987     1042      +55     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [1311 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [30a88b5...be0c599](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (13e80f8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `27.72%`.
   > The diff coverage is `27.45%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   29.11%   -27.73%     
   + Complexity     3911     1814     -2097     
   =============================================
     Files           962      806      -156     
     Lines         23957    19712     -4245     
     Branches       2362     1832      -530     
   =============================================
   - Hits          13616     5739     -7877     
   - Misses         9149    13543     +4394     
   + Partials       1192      430      -762     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==) | `58.18% <0.00%> (-6.64%)` | `6.00 <0.00> (-1.00)` | |
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `17.22% <ø> (-35.41%)` | `18.00 <0.00> (-44.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [516 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...6e44b52](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (13e80f8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `16.39%`.
   > The diff coverage is `27.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   40.44%   -16.40%     
   + Complexity     3911     2391     -1520     
   =============================================
     Files           962      807      -155     
     Lines         23957    19908     -4049     
     Branches       2362     1872      -490     
   =============================================
   - Hits          13616     8051     -5565     
   - Misses         9149    11236     +2087     
   + Partials       1192      621      -571     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [396 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...6e44b52](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (da8ec05) into [master](https://codecov.io/gh/apache/skywalking/commit/01d1eff6c796510b5698ad5d84d0800d56e06c6b?el=desc) (01d1eff) will **decrease** coverage by `2.14%`.
   > The diff coverage is `36.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.83%   50.69%   -2.15%     
   + Complexity     3793     3614     -179     
   ============================================
     Files          1732      964     -768     
     Lines         36915    23902   -13013     
     Branches       4071     2326    -1745     
   ============================================
   - Hits          19504    12117    -7387     
   + Misses        16434    10709    -5725     
   - Partials        977     1076      +99     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.72% <28.72%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [1264 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [01d1eff...da8ec05](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b425d99) into [master](https://codecov.io/gh/apache/skywalking/commit/ba6d49ad917bf698d6179ebc90a3a0703e74a4b1?el=desc) (ba6d49a) will **decrease** coverage by `7.91%`.
   > The diff coverage is `77.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     49.66%   41.75%   -7.92%     
   + Complexity     3558     2573     -985     
   ============================================
     Files          1752      830     -922     
     Lines         37357    20629   -16728     
     Branches       4146     1958    -2188     
   ============================================
   - Hits          18554     8613    -9941     
   + Misses        17830    11352    -6478     
   + Partials        973      664     -309     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [1342 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...b425d99](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (70013d7) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `16.29%`.
   > The diff coverage is `27.55%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   40.53%   -16.30%     
   + Complexity     3911     2909     -1002     
   =============================================
     Files           962      958        -4     
     Lines         23957    23508      -449     
     Branches       2362     2274       -88     
   =============================================
   - Hits          13616     9530     -4086     
   - Misses         9149    13185     +4036     
   + Partials       1192      793      -399     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [270 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...763bc45](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (3b30413) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `15.42%`.
   > The diff coverage is `27.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   41.41%   -15.43%     
   + Complexity     3911     3027      -884     
   =============================================
     Files           962      958        -4     
     Lines         23957    23622      -335     
     Branches       2362     2320       -42     
   =============================================
   - Hits          13616     9782     -3834     
   - Misses         9149    12985     +3836     
   + Partials       1192      855      -337     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [247 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...763bc45](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (bd822db) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `5.90%`.
   > The diff coverage is `77.88%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     53.20%   47.30%   -5.91%     
   + Complexity     3900     2822    -1078     
   ============================================
     Files          1751      830     -921     
     Lines         37332    20687   -16645     
     Branches       4149     1964    -2185     
   ============================================
   - Hits          19861     9785   -10076     
   + Misses        16489    10185    -6304     
   + Partials        982      717     -265     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | ... and [1453 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (98e429d) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `0.78%`.
   > The diff coverage is `50.10%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     53.20%   52.41%   -0.79%     
   + Complexity     3900     3738     -162     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24275   -13057     
     Branches       4149     2381    -1768     
   ============================================
   - Hits          19861    12723    -7138     
   + Misses        16489    10410    -6079     
   - Partials        982     1142     +160     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1354 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r573495258



##########
File path: oap-server/server-receiver-plugin/skywalking-zabbix-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zabbix/provider/protocol/ZabbixProtocolDecoder.java
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.receiver.zabbix.provider.protocol;
+
+import com.google.common.base.Charsets;
+import com.google.gson.Gson;
+import com.google.gson.GsonBuilder;
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.handler.codec.ByteToMessageDecoder;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.skywalking.oap.server.receiver.zabbix.provider.protocol.bean.ZabbixRequest;
+import org.apache.skywalking.oap.server.receiver.zabbix.provider.protocol.bean.ZabbixRequestJsonDeserializer;
+
+import java.util.List;
+
+@Slf4j
+public class ZabbixProtocolDecoder extends ByteToMessageDecoder {
+    private static final int HEADER_LEN = 9;
+    private static final byte[] PROTOCOL = new byte[] {'Z', 'B', 'X', 'D'};
+
+    private final Gson requestParser = new GsonBuilder()
+        .registerTypeAdapter(ZabbixRequest.class, new ZabbixRequestJsonDeserializer()).create();
+
+    @Override
+    protected void decode(ChannelHandlerContext channelHandlerContext, ByteBuf byteBuf, List<Object> list) throws Exception {
+        // Decode header and get payload
+        String payload = decodeToPayload(channelHandlerContext, byteBuf);
+        if (StringUtils.isEmpty(payload)) {
+            return;
+        }
+
+        // Parse content and add to list
+        try {
+            ZabbixRequest request = requestParser.fromJson(payload, ZabbixRequest.class);
+            list.add(request);
+        } catch (Exception e) {
+            errorProtocol(channelHandlerContext, byteBuf, "Parsing zabbix request data error");
+        }
+    }
+
+    /**
+     * Decode protocol to payload string
+     */
+    public String decodeToPayload(ChannelHandlerContext channelHandlerContext, ByteBuf byteBuf) throws InterruptedException {
+        int readable = byteBuf.readableBytes();
+        int baseIndex = byteBuf.readerIndex();
+        if (readable < HEADER_LEN) {
+            errorProtocol(channelHandlerContext, byteBuf, "header length is not enough");
+            return null;
+        }
+
+        // Read header
+        byte[] header = new byte[HEADER_LEN];
+        byteBuf.readBytes(header);
+        if (header[0] != PROTOCOL[0] || header[1] != PROTOCOL[1] || header[2] != PROTOCOL[2] || header[3] != PROTOCOL[3]) {
+            errorProtocol(channelHandlerContext, byteBuf, "header is not right");
+            return null;
+        }
+
+        // Only support communications protocol
+        if (header[4] != 1) {
+            errorProtocol(channelHandlerContext, byteBuf, "header flags only support communications protocol");
+            return null;
+        }
+
+        // Check payload
+        int dataLength = header[5] & 0xFF | (header[6] & 0xFF) << 8 | (header[7] & 0xFF) << 16 | (header[8] & 0xFF) << 24;
+        int totalLength = HEADER_LEN + dataLength + 4;
+        // If not receive all data, reset buffer and re-decode after content receive finish
+        if (readable < totalLength) {
+            byteBuf.readerIndex(baseIndex);
+            return null;
+        }
+
+        if (dataLength <= 0) {
+            errorProtocol(channelHandlerContext, byteBuf, "content could not be empty");
+            return null;
+        }
+
+        // Skip protocol extensions
+        byteBuf.skipBytes(4);
+
+        // Reading content
+        byte[] payload = new byte[dataLength];
+        byteBuf.readBytes(payload);
+
+        return new String(payload, Charsets.UTF_8);
+    }
+
+    /**
+     * Close connection if protocol error
+     */
+    private void errorProtocol(ChannelHandlerContext context, ByteBuf byteBuf, String reason) throws InterruptedException {
+        log.warn("Receive message is not Zabbix protocol, reason: {}", reason);
+        // Skip all content
+        byteBuf.skipBytes(byteBuf.readableBytes());
+        // Close connection
+        context.close();

Review comment:
       Don't we need `context.close()` any other place?  Current code structure seems having connection leak risk. Could you recheck?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (08876d9) into [master](https://codecov.io/gh/apache/skywalking/commit/e138d29778fb458a6fad5f3fd82121c7bba3cc95?el=desc) (e138d29) will **decrease** coverage by `9.81%`.
   > The diff coverage is `38.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     52.54%   42.72%   -9.82%     
   + Complexity     3793     3095     -698     
   ============================================
     Files          1748      963     -785     
     Lines         37066    23771   -13295     
     Branches       4102     2301    -1801     
   ============================================
   - Hits          19475    10157    -9318     
   + Misses        16620    12746    -3874     
   + Partials        971      868     -103     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.44% <ø> (-29.42%)` | `26.00 <0.00> (-36.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `92.85% <ø> (+66.93%)` | `3.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1337 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8c51043...0437d1d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (1ed1a79) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `5.09%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   50.87%   -5.10%     
   + Complexity     3901     3645     -256     
   ============================================
     Files           973      981       +8     
     Lines         24216    24269      +53     
     Branches       2394     2385       -9     
   ============================================
   - Hits          13556    12348    -1208     
   - Misses         9464    10866    +1402     
   + Partials       1196     1055     -141     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.56%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [168 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (98e429d) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **increase** coverage by `0.20%`.
   > The diff coverage is `50.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     53.20%   53.40%   +0.20%     
   + Complexity     3900     3799     -101     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24303   -13029     
     Branches       4149     2386    -1763     
   ============================================
   - Hits          19861    12979    -6882     
   + Misses        16489    10145    -6344     
   - Partials        982     1179     +197     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [1349 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...98e429d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (4a024ac) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `10.62%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   46.21%   -10.63%     
   + Complexity     3911     3344      -567     
   =============================================
     Files           962      958        -4     
     Lines         23957    23627      -330     
     Branches       2362     2306       -56     
   =============================================
   - Hits          13616    10919     -2697     
   - Misses         9149    11746     +2597     
   + Partials       1192      962      -230     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [195 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...4cd8bf0](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (08876d9) into [master](https://codecov.io/gh/apache/skywalking/commit/e138d29778fb458a6fad5f3fd82121c7bba3cc95?el=desc) (e138d29) will **increase** coverage by `6.05%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     52.54%   58.59%   +6.05%     
   + Complexity     3793      812    -2981     
   ============================================
     Files          1748      170    -1578     
     Lines         37066     4149   -32917     
     Branches       4102      481    -3621     
   ============================================
   - Hits          19475     2431   -17044     
   + Misses        16620     1410   -15210     
   + Partials        971      308     -663     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...re/conf/dynamic/ConfigurationDiscoveryService.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9keW5hbWljL0NvbmZpZ3VyYXRpb25EaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `79.78% <100.00%> (+26.70%)` | `14.00 <2.00> (+5.00)` | |
   | [...t/status/HierarchyMatchExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvSGllcmFyY2h5TWF0Y2hFeGNlcHRpb25DaGVja1N0cmF0ZWd5LmphdmE=) | `9.09% <0.00%> (-90.91%)` | `1.00% <0.00%> (ø%)` | |
   | [...g/apm/agent/core/context/status/StatusChecker.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvU3RhdHVzQ2hlY2tlci5qYXZh) | `23.80% <0.00%> (-76.20%)` | `1.00% <0.00%> (ø%)` | |
   | [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `28.57% <0.00%> (-71.43%)` | `2.00% <0.00%> (ø%)` | |
   | [...re/logging/core/converters/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (-66.67%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-66.67%)` | `2.00% <0.00%> (-2.00%)` | |
   | [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `20.00% <0.00%> (-60.00%)` | `1.00% <0.00%> (ø%)` | |
   | [...lking/apm/agent/core/context/ExtensionContext.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9FeHRlbnNpb25Db250ZXh0LmphdmE=) | `23.25% <0.00%> (-51.17%)` | `7.00% <0.00%> (ø%)` | |
   | [...core/context/status/OffExceptionCheckStrategy.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvT2ZmRXhjZXB0aW9uQ2hlY2tTdHJhdGVneS5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (ø%)` | |
   | [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `38.46% <0.00%> (-46.16%)` | `6.00% <0.00%> (-4.00%)` | |
   | ... and [1647 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8c51043...0437d1d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (bd822db) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **increase** coverage by `0.56%`.
   > The diff coverage is `78.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     53.20%   53.76%   +0.56%     
   + Complexity     3900     3790     -110     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24317   -13015     
     Branches       4149     2370    -1779     
   ============================================
   - Hits          19861    13074    -6787     
   + Misses        16489    10153    -6336     
   - Partials        982     1090     +108     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | ... and [1368 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (60ca798) into [master](https://codecov.io/gh/apache/skywalking/commit/56c264d1fa640115197ed19bb8a68388c6fa3b95?el=desc) (56c264d) will **increase** coverage by `7.46%`.
   > The diff coverage is `35.69%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     48.89%   56.35%   +7.46%     
   - Complexity     3495     3890     +395     
   ============================================
     Files           960      965       +5     
     Lines         23829    23906      +77     
     Branches       2320     2320              
   ============================================
   + Hits          11650    13473    +1823     
   + Misses        11155     9260    -1895     
   - Partials       1024     1173     +149     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.34%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.19% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [172 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [56c264d...60ca798](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (ecac220) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `9.99%`.
   > The diff coverage is `77.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   46.84%   -10.00%     
   + Complexity     3911     2777     -1134     
   =============================================
     Files           962      825      -137     
     Lines         23957    20592     -3365     
     Branches       2362     1959      -403     
   =============================================
   - Hits          13616     9646     -3970     
   - Misses         9149    10194     +1045     
   + Partials       1192      752      -440     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `92.00% <92.00%> (ø)` | `4.00 <4.00> (?)` | |
   | ... and [333 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (be0c599) into [master](https://codecov.io/gh/apache/skywalking/commit/30a88b555f44c52f40345aeacd1bc3300446de89?el=desc) (30a88b5) will **increase** coverage by `6.82%`.
   > The diff coverage is `35.65%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     45.56%   52.39%   +6.82%     
   - Complexity     2596     3674    +1078     
   ============================================
     Files          1742      981     -761     
     Lines         37022    24285   -12737     
     Branches       4306     2382    -1924     
   ============================================
   - Hits          16870    12723    -4147     
   + Misses        19165    10482    -8683     
   - Partials        987     1080      +93     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `55.98% <ø> (+3.12%)` | `65.00 <0.00> (+3.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | ... and [1303 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [30a88b5...be0c599](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c9678ef) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `19.26%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   37.56%   -19.27%     
   + Complexity     3911     2288     -1623     
   =============================================
     Files           962      824      -138     
     Lines         23957    20345     -3612     
     Branches       2362     1920      -442     
   =============================================
   - Hits          13616     7643     -5973     
   - Misses         9149    12125     +2976     
   + Partials       1192      577      -615     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [417 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b83f408) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `2.52%`.
   > The diff coverage is `26.73%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   54.31%   -2.53%     
   + Complexity     3911     3809     -102     
   ============================================
     Files           962      976      +14     
     Lines         23957    24190     +233     
     Branches       2362     2376      +14     
   ============================================
   - Hits          13616    13138     -478     
   - Misses         9149     9887     +738     
   + Partials       1192     1165      -27     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [75 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...9ff6055](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng merged pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (0c87938) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `14.01%`.
   > The diff coverage is `77.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   42.82%   -14.02%     
   + Complexity     3911     2606     -1305     
   =============================================
     Files           962      825      -137     
     Lines         23957    20575     -3382     
     Branches       2362     1958      -404     
   =============================================
   - Hits          13616     8811     -4805     
   - Misses         9149    11108     +1959     
   + Partials       1192      656      -536     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | [...eceiver/zabbix/provider/protocol/ZabbixServer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhTZXJ2ZXIuamF2YQ==) | `92.00% <92.00%> (ø)` | `4.00 <4.00> (?)` | |
   | ... and [354 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c434154) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `0.68%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   56.15%   -0.69%     
   - Complexity     3911     3925      +14     
   ============================================
     Files           962      977      +15     
     Lines         23957    24260     +303     
     Branches       2362     2384      +22     
   ============================================
   + Hits          13616    13622       +6     
   - Misses         9149     9451     +302     
   + Partials       1192     1187       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [35 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (12d65b8) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `0.87%`.
   > The diff coverage is `77.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   55.96%   -0.88%     
   + Complexity     3911     3896      -15     
   ============================================
     Files           962      977      +15     
     Lines         23957    24254     +297     
     Branches       2362     2381      +19     
   ============================================
   - Hits          13616    13573      -43     
   - Misses         9149     9497     +348     
   + Partials       1192     1184       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.67% <ø> (+10.04%)` | `72.00 <0.00> (+10.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `61.90% <61.90%> (ø)` | `6.00 <6.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `75.92% <75.92%> (ø)` | `10.00 <10.00> (?)` | |
   | [...ceiver/zabbix/provider/ZabbixReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `78.94% <78.94%> (ø)` | `8.00 <8.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `88.88% <88.88%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `90.00% <90.00%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [63 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...12d65b8](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (49242fd) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `24.44%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   32.38%   -24.45%     
   + Complexity     3911     1970     -1941     
   =============================================
     Files           962      807      -155     
     Lines         23957    19801     -4156     
     Branches       2362     1862      -500     
   =============================================
   - Hits          13616     6413     -7203     
   - Misses         9149    12932     +3783     
   + Partials       1192      456      -736     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [459 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (663a646) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `4.98%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   50.99%   -4.99%     
   + Complexity     3901     3681     -220     
   ============================================
     Files           973      979       +6     
     Lines         24216    24236      +20     
     Branches       2394     2380      -14     
   ============================================
   - Hits          13556    12358    -1198     
   - Misses         9464    10787    +1323     
   + Partials       1196     1091     -105     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.56%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [156 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `3.33%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   53.49%   -3.34%     
   + Complexity     3911     3755     -156     
   ============================================
     Files           962      976      +14     
     Lines         23957    24236     +279     
     Branches       2362     2380      +18     
   ============================================
   - Hits          13616    12966     -650     
   - Misses         9149    10144     +995     
   + Partials       1192     1126      -66     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [85 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (bd822db) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `1.65%`.
   > The diff coverage is `78.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     53.20%   51.54%   -1.66%     
   + Complexity     3900     3684     -216     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24317   -13015     
     Branches       4149     2370    -1779     
   ============================================
   - Hits          19861    12535    -7326     
   + Misses        16489    10753    -5736     
   - Partials        982     1029      +47     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | ... and [1375 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (663a646) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `31.04%`.
   > The diff coverage is `77.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     55.97%   24.93%   -31.05%     
   + Complexity     3901     1564     -2337     
   =============================================
     Files           973      810      -163     
     Lines         24216    19711     -4505     
     Branches       2394     1828      -566     
   =============================================
   - Hits          13556     4914     -8642     
   - Misses         9464    14458     +4994     
   + Partials       1196      339      -857     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `30.62% <ø> (-22.01%)` | `29.00 <0.00> (-33.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../skywalking/oap/meter/analyzer/dsl/Expression.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb24uamF2YQ==) | `62.26% <50.00%> (-2.56%)` | `7.00 <0.00> (ø)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | ... and [596 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...c4737cc](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (224f6a6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `6.35%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     56.83%   50.48%   -6.36%     
   + Complexity     3911     3609     -302     
   ============================================
     Files           962      976      +14     
     Lines         23957    24189     +232     
     Branches       2362     2362              
   ============================================
   - Hits          13616    12211    -1405     
   - Misses         9149    10890    +1741     
   + Partials       1192     1088     -104     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [127 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...ecac220](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (bd822db) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **increase** coverage by `0.77%`.
   > The diff coverage is `78.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   + Coverage     53.20%   53.97%   +0.77%     
   + Complexity     3900     3801      -99     
   ============================================
     Files          1751      981     -770     
     Lines         37332    24317   -13015     
     Branches       4149     2370    -1779     
   ============================================
   - Hits          19861    13126    -6735     
   + Misses        16489    10096    -6393     
   - Partials        982     1095     +113     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `63.63% <ø> (ø)` | `2.00 <0.00> (ø)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../elasticsearch/cache/NetworkAddressAliasEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvY2FjaGUvTmV0d29ya0FkZHJlc3NBbGlhc0VzREFPLmphdmE=) | `76.47% <0.00%> (ø)` | `3.00 <0.00> (ø)` | |
   | ... and [1364 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (bd822db) into [master](https://codecov.io/gh/apache/skywalking/commit/3246e1c5020f8ada5db6050fcd6655d8a9d84e6a?el=desc) (3246e1c) will **decrease** coverage by `10.07%`.
   > The diff coverage is `76.51%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     53.20%   43.12%   -10.08%     
   + Complexity     3900     2625     -1275     
   =============================================
     Files          1751      830      -921     
     Lines         37332    20615    -16717     
     Branches       4149     1959     -2190     
   =============================================
   - Hits          19861     8890    -10971     
   + Misses        16489    11081     -5408     
   + Partials        982      644      -338     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.34%)` | `71.00 <0.00> (+9.00)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `72.72% <0.00%> (-7.28%)` | `7.00 <0.00> (ø)` | |
   | [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...oap/server/core/analysis/manual/log/LogRecord.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9Mb2dSZWNvcmQuamF2YQ==) | `9.09% <ø> (-54.55%)` | `0.00 <0.00> (-2.00)` | |
   | [...ore/analysis/meter/function/HistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vSGlzdG9ncmFtRnVuY3Rpb24uamF2YQ==) | `0.00% <ø> (-56.25%)` | `0.00 <0.00> (ø)` | |
   | [...re/analysis/meter/function/PercentileFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vUGVyY2VudGlsZUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-12.20%)` | `0.00 <0.00> (ø)` | |
   | [...lysis/meter/function/avg/AvgHistogramFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vYXZnL0F2Z0hpc3RvZ3JhbUZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-62.80%)` | `0.00 <0.00> (ø)` | |
   | [...analysis/meter/function/latest/LatestFunction.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vbGF0ZXN0L0xhdGVzdEZ1bmN0aW9uLmphdmE=) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00 <0.00> (-1.00)` | |
   | ... and [1468 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [ba6d49a...cfeca41](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (93aa01d) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `13.15%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   43.67%   -13.16%     
   + Complexity     3911     2542     -1369     
   =============================================
     Files           962      807      -155     
     Lines         23957    20038     -3919     
     Branches       2362     1915      -447     
   =============================================
   - Hits          13616     8752     -4864     
   - Misses         9149    10633     +1484     
   + Partials       1192      653      -539     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [348 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...93aa01d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c9678ef) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `25.28%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   31.55%   -25.29%     
   + Complexity     3911     1928     -1983     
   =============================================
     Files           962      806      -156     
     Lines         23957    19796     -4161     
     Branches       2362     1863      -499     
   =============================================
   - Hits          13616     6246     -7370     
   - Misses         9149    13078     +3929     
   + Partials       1192      472      -720     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [473 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...5961d25](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c89b4e6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `13.46%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   43.36%   -13.47%     
   + Complexity     3911     2640     -1271     
   =============================================
     Files           962      825      -137     
     Lines         23957    20556     -3401     
     Branches       2362     1956      -406     
   =============================================
   - Hits          13616     8915     -4701     
   - Misses         9149    10928     +1779     
   + Partials       1192      713      -479     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [344 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...0c87938](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (49242fd) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `14.65%`.
   > The diff coverage is `27.01%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   42.17%   -14.66%     
   + Complexity     3911     3062      -849     
   =============================================
     Files           962      958        -4     
     Lines         23957    23559      -398     
     Branches       2362     2298       -64     
   =============================================
   - Hits          13616     9937     -3679     
   - Misses         9149    12772     +3623     
   + Partials       1192      850      -342     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [...rovider/protocol/ZabbixErrorProtocolException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhFcnJvclByb3RvY29sRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | ... and [239 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [c1736b6...49242fd](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (1ed1a79) into [master](https://codecov.io/gh/apache/skywalking/commit/fc23dabf37a85cfc27482dbaf25b0109114f6ef7?el=desc) (fc23dab) will **decrease** coverage by `1.60%`.
   > The diff coverage is `77.27%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #6176      +/-   ##
   ============================================
   - Coverage     55.97%   54.37%   -1.61%     
   + Complexity     3901     3820      -81     
   ============================================
     Files           973      981       +8     
     Lines         24216    24318     +102     
     Branches       2394     2386       -8     
   ============================================
   - Hits          13556    13223     -333     
   - Misses         9464     9991     +527     
   + Partials       1196     1104      -92     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `62.20% <ø> (+9.56%)` | `71.00 <0.00> (+9.00)` | |
   | [.../server/library/server/tcp/TCPServerException.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL3RjcC9UQ1BTZXJ2ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.06% <0.00%> (-0.14%)` | `2.00 <0.00> (ø)` | |
   | [.../tool/profile/core/mock/MockTCPBinderRegister.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tUQ1BCaW5kZXJSZWdpc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `58.13% <58.13%> (ø)` | `6.00 <6.00> (?)` | |
   | [...ing/oap/meter/analyzer/dsl/SampleFamilyFinder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseUZpbmRlci5qYXZh) | `75.00% <75.00%> (ø)` | `8.00 <8.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `76.14% <76.14%> (ø)` | `11.00 <11.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `80.00% <80.00%> (ø)` | `4.00 <4.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `82.35% <82.35%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [134 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [fc23dab...1ed1a79](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (b48699d) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `11.81%`.
   > The diff coverage is `27.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   45.02%   -11.82%     
   + Complexity     3911     3301      -610     
   =============================================
     Files           962      976       +14     
     Lines         23957    24167      +210     
     Branches       2362     2360        -2     
   =============================================
   - Hits          13616    10880     -2736     
   - Misses         9149    12330     +3181     
   + Partials       1192      957      -235     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `56.45% <ø> (+3.82%)` | `66.00 <0.00> (+4.00)` | |
   | [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
   | [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `78.48% <ø> (-3.17%)` | `10.00 <0.00> (ø)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [210 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...763bc45](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r571586848



##########
File path: oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/dsl/SampleFamilyFinder.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.meter.analyzer.dsl;
+
+import com.google.common.collect.ImmutableMap;
+import groovy.lang.GroovyInterceptable;
+import groovy.lang.MetaClass;
+import lombok.extern.slf4j.Slf4j;
+import org.codehaus.groovy.runtime.InvokerHelper;
+
+/**
+ * Help to find {@link SampleFamily}, support "." in metric name
+ */
+@Slf4j
+public class SampleFamilyFinder extends SampleFamily implements GroovyInterceptable {

Review comment:
       I have concern of this mechanism, let's discuss this first.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: [WIP] Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#issuecomment-768428736


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=h1) Report
   > Merging [#6176](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=desc) (c89b4e6) into [master](https://codecov.io/gh/apache/skywalking/commit/8fed8768b9eeba35518d81c2f1a7906d7b608d3d?el=desc) (8fed876) will **decrease** coverage by `25.06%`.
   > The diff coverage is `26.64%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/6176/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #6176       +/-   ##
   =============================================
   - Coverage     56.83%   31.76%   -25.07%     
   + Complexity     3911     1935     -1976     
   =============================================
     Files           962      806      -156     
     Lines         23957    19805     -4152     
     Branches       2362     1863      -499     
   =============================================
   - Hits          13616     6292     -7324     
   - Misses         9149    13045     +3896     
   + Partials       1192      468      -724     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `31.10% <ø> (-21.54%)` | `34.00 <0.00> (-28.00)` | |
   | [...bix/provider/protocol/ZabbixProtocolDataCodec.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERhdGFDb2RlYy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolDecoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbERlY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolEncoder.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEVuY29kZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...abbix/provider/protocol/ZabbixProtocolHandler.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9aYWJiaXhQcm90b2NvbEhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bix/provider/protocol/bean/ZabbixProtocolType.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFByb3RvY29sVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...r/protocol/bean/ZabbixRequestJsonDeserializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlcXVlc3RKc29uRGVzZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...er/protocol/bean/ZabbixResponseJsonSerializer.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9wcm90b2NvbC9iZWFuL1phYmJpeFJlc3BvbnNlSnNvblNlcmlhbGl6ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...server/receiver/zabbix/provider/ZabbixMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9aYWJiaXhNZXRyaWNzLmphdmE=) | `28.26% <28.26%> (ø)` | `6.00 <6.00> (?)` | |
   | [...receiver/zabbix/provider/config/ZabbixConfigs.java](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctemFiYml4LXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL3phYmJpeC9wcm92aWRlci9jb25maWcvWmFiYml4Q29uZmlncy5qYXZh) | `50.00% <50.00%> (ø)` | `3.00 <3.00> (?)` | |
   | ... and [475 more](https://codecov.io/gh/apache/skywalking/pull/6176/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=footer). Last update [8fed876...93aa01d](https://codecov.io/gh/apache/skywalking/pull/6176?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on a change in pull request #6176: Adopt Zabbix protocol

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #6176:
URL: https://github.com/apache/skywalking/pull/6176#discussion_r571586015



##########
File path: oap-server/server-bootstrap/src/main/resources/ui-initialized-templates/zabbix.yml
##########
@@ -0,0 +1,157 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# UI templates initialized file includes the default template when the SkyWalking OAP starts up at the first time.
+#
+# Also, SkyWalking would detect the existing templates in the database, once they are missing, all templates in this file
+# could be added automatically.
+
+templates:
+  - name: "Zabbix"

Review comment:
       Do you really need this? My expectation would be, the VM monitoring could share the same templates with existing VM template. Could you share the details about why adding this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org