[jira] [Commented] (OFBIZ-4345) voided payments are auto-applied to new order invoices

["Bilgin Ibryam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073590#comment-13073590 ] 

Bilgin Ibryam commented on OFBIZ-4345:
--------------------------------------

Martin, 

your patch seems to be OK, but what about also filtering out OrderPaymentPreference with statusId PAYMENT_CANCELLED?
Is it going to work fine in your case?

> voided payments are auto-applied to new order invoices
> ------------------------------------------------------
>
>                 Key: OFBIZ-4345
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4345
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Martin Kreidenweis
>            Assignee: Bilgin Ibryam
>         Attachments: OFBIZ-4345-voidedAutoApply.patch
>
>
> {{InvoiceServices.createInvoiceForOrder}} automatically creates {{PaymentApplication}} records when unapplied payments exist for the order. Unfortunately this doesn't consider the {{Payment.statusId}}. 
> So when a user accidentally enters a wrong payment and voids it right away, it is still automatically applied to the invoice on invoice creation. The GUI then provides no way to un-apply the payment, because it assumes that for voided payments no payment applications can exist any more. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira