You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dolphinscheduler.apache.org by Jave-Chen <ke...@foxmail.com> on 2020/02/08 13:05:36 UTC
回复： [CI][Code style] Need help with checking code style check by Ali way
The file <https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml> is created at 2017, are u sure?
------------------ 原始邮件 ------------------
发件人: "lidong dai"<dailidong66@gmail.com>;
发送时间: 2020年2月8日(星期六) 晚上8:59
收件人: "dev"<dev@dolphinscheduler.apache.org>;
抄送: "wangyang.03"<wangyang.03@bytedance.com>;
主题: Re: [CI][Code style] Need help with checking code style check by Ali way
hi ,
I see checkstyle.xml (
https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml)
from
http://mail-archives.apache.org/mod_mbox/dolphinscheduler-dev/202001.mbox/%3Ctencent_6DF620A15E4A57C43A349736CBCD15454907%40qq.com%3E,
is this checkstyle OK ?
<https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml>
Best Regards
---------------
DolphinScheduler(Incubator) PPMC
Lidong Dai 代立冬
dailidong66@gmail.com
---------------
Jave-Chen <kejia.chen@foxmail.com> 于2020年2月8日周六 下午4:41写道：
> Hi, all
> As we discussed about checkstyle, we agreed use Ali code style.
> <
> http://mail-archives.apache.org/mod_mbox/dolphinscheduler-dev/202001.mbox/%3Ctencent_6DF620A15E4A57C43A349736CBCD15454907%40qq.com%3E&gt
> ;
>
>
> I did some effects with this, and there are some problems now:
> 1. I did't find checkstyle config file for Ali code style, which means we
> need to&nbsp;
> create these rules by ourselves.
> 2. Another possible way is to use PMD, but the PMD implementations has
> fewer&nbsp;
> rules than IDEA plugin or Eclipse plugin.&nbsp;
> For example indent check is not implemented by PMD, which I think
> is unacceptable.
> You can see The PDM implementations and rules&nbsp; at
> <https://github.com/alibaba/p3c/tree/master/p3c-pmd&gt;
>
>
> So, is there anyone can help solve these problems？
> Or we have to reconsider Google code style.
re： [CI][Code style] Need help with checking code style check by Ali way
Posted by Jave-Chen <ke...@foxmail.com>.
Because there isn't an checkstyle configure file of Ali way,
So it is impossible to check code style in with GitHub Action.
But I strongly suggest use IDE plugin to check your code
locally .
------------------ 原始邮件 ------------------
发件人: "Jave-Chen"<kejia.chen@foxmail.com>;
发送时间: 2020年2月8日(星期六) 晚上9:05
收件人: "dev"<dev@dolphinscheduler.apache.org>;
主题: 回复： [CI][Code style] Need help with checking code style check by Ali way
The file <https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml&gt; is created at 2017, are u sure?
------------------&nbsp;原始邮件&nbsp;------------------
发件人:&nbsp;"lidong dai"<dailidong66@gmail.com&gt;;
发送时间:&nbsp;2020年2月8日(星期六) 晚上8:59
收件人:&nbsp;"dev"<dev@dolphinscheduler.apache.org&gt;;
抄送:&nbsp;"wangyang.03"<wangyang.03@bytedance.com&gt;;
主题:&nbsp;Re: [CI][Code style] Need help with checking code style check by Ali way
hi ,
I see checkstyle.xml (
https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml)
from
http://mail-archives.apache.org/mod_mbox/dolphinscheduler-dev/202001.mbox/%3Ctencent_6DF620A15E4A57C43A349736CBCD15454907%40qq.com%3E,
is this checkstyle OK ?
<https://github.com/zhnlk/ali-checkstyle-xml/blob/master/ali-checkstyle.xml&gt;
Best Regards
---------------
DolphinScheduler(Incubator) PPMC
Lidong Dai 代立冬
dailidong66@gmail.com
---------------
Jave-Chen <kejia.chen@foxmail.com&gt; 于2020年2月8日周六 下午4:41写道：
&gt; Hi, all
&gt; As we discussed about checkstyle, we agreed use Ali code style.
&gt; <
&gt; http://mail-archives.apache.org/mod_mbox/dolphinscheduler-dev/202001.mbox/%3Ctencent_6DF620A15E4A57C43A349736CBCD15454907%40qq.com%3E&amp;gt
&gt; ;
&gt;
&gt;
&gt; I did some effects with this, and there are some problems now:
&gt; 1. I did't find checkstyle config file for Ali code style, which means we
&gt; need to&amp;nbsp;
&gt; create these rules by ourselves.
&gt; 2. Another possible way is to use PMD, but the PMD implementations has
&gt; fewer&amp;nbsp;
&gt; rules than IDEA plugin or Eclipse plugin.&amp;nbsp;
&gt; For example indent check is not implemented by PMD, which I think
&gt; is unacceptable.
&gt; You can see The PDM implementations and rules&amp;nbsp; at
&gt; <https://github.com/alibaba/p3c/tree/master/p3c-pmd&amp;gt;
&gt;
&gt;
&gt; So, is there anyone can help solve these problems？
&gt; Or we have to reconsider Google code style.