[jira] Commented: (PIG-38) abstract PigScript parser

["Olga Natkovich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548488 ] 

Olga Natkovich commented on PIG-38:
-----------------------------------

The patch looks fine. I also ran unit, end-to-end and manual grunt tests. All looks good. +1 on the patch

> abstract PigScript parser
> -------------------------
>
>                 Key: PIG-38
>                 URL: https://issues.apache.org/jira/browse/PIG-38
>             Project: Pig
>          Issue Type: Improvement
>          Components: grunt
>         Environment: grunt and pigpen
>            Reporter: Christopher Olston
>         Attachments: pigScriptParser.patch
>
>
> I am developing Pig Pen, an Eclipse plugin for Pig. Pig Pen needs to parse .pig scripts. The parsing is the same as for grunt, but the actions I take are different (e.g., Pig Pen will ignore "store" commands for the purpose of editing).
> What I'd like to do is create an abstract class PigScriptParser, which is identical to the current GruntParser except no actions are taken. Then I'll add a GruntParser that extends PigScriptParser, and has concrete implementations of actions (e.g., what to do when a "store" command is encountered).
> I'll also add a PigPenParser that also extends PigScriptParser.
> This should not affect the behavior of GruntParser at all -- it just separates the parsing from the actuating.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.