You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Matt <mi...@gmail.com> on 2016/02/23 21:24:06 UTC
Review Request 43812: Use ember functions mapProperty and pushObjects
in AMBARI-14987
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43812/
-----------------------------------------------------------
Review request for Ambari and Alexandr Antonenko.
Bugs: AMBARI-14987
https://issues.apache.org/jira/browse/AMBARI-14987
Repository: ambari
Description
-------
Use mapProperty and pushObjects as suggested by AlexAntonenko in https://reviews.apache.org/r/43430/
Diffs
-----
ambari-web/app/mixins/wizard/assign_master_components.js 62efdac
ambari-web/test/mixins/wizard/assign_master_components_test.js a3ffb22
Diff: https://reviews.apache.org/r/43812/diff/
Testing
-------
Manually Tested.
Updated unit test to use JSON.stringify(). All unit tests passed.
10422 tests complete (9 seconds)
121 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40.956 s
[INFO] Finished at: 2016-02-23T12:18:56-08:00
[INFO] Final Memory: 12M/310M
[INFO] ------------------------------------------------------------------------
Thanks,
Matt
Re: Review Request 43812: Use ember functions mapProperty and
pushObjects in AMBARI-14987
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43812/#review120691
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On Feb. 23, 2016, 8:24 p.m., Matt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43812/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2016, 8:24 p.m.)
>
>
> Review request for Ambari and Alexandr Antonenko.
>
>
> Bugs: AMBARI-14987
> https://issues.apache.org/jira/browse/AMBARI-14987
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Use mapProperty and pushObjects as suggested by AlexAntonenko in https://reviews.apache.org/r/43430/
>
>
> Diffs
> -----
>
> ambari-web/app/mixins/wizard/assign_master_components.js 62efdac
> ambari-web/test/mixins/wizard/assign_master_components_test.js a3ffb22
>
> Diff: https://reviews.apache.org/r/43812/diff/
>
>
> Testing
> -------
>
> Manually Tested.
>
> Updated unit test to use JSON.stringify(). All unit tests passed.
>
> 10422 tests complete (9 seconds)
> 121 tests pending
>
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40.956 s
> [INFO] Finished at: 2016-02-23T12:18:56-08:00
> [INFO] Final Memory: 12M/310M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Matt
>
>