You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by wr...@apache.org on 2010/10/01 05:31:57 UTC
svn commit: r1003375 - /apr/apr-util/branches/1.3.x/include/apr_memcache.h
Author: wrowe
Date: Fri Oct 1 03:31:56 2010
New Revision: 1003375
URL: http://svn.apache.org/viewvc?rev=1003375&view=rev
Log:
Note bug
Modified:
apr/apr-util/branches/1.3.x/include/apr_memcache.h
Modified: apr/apr-util/branches/1.3.x/include/apr_memcache.h
URL: http://svn.apache.org/viewvc/apr/apr-util/branches/1.3.x/include/apr_memcache.h?rev=1003375&r1=1003374&r2=1003375&view=diff
==============================================================================
--- apr/apr-util/branches/1.3.x/include/apr_memcache.h (original)
+++ apr/apr-util/branches/1.3.x/include/apr_memcache.h Fri Oct 1 03:31:56 2010
@@ -287,6 +287,9 @@ APU_DECLARE(apr_status_t) apr_memcache_m
* @param data_size length of data at baton
* @param timeout time in seconds for the data to live on the server
* @param flags any flags set by the client for this key
+ * @bug timeout is not implemented
+ * @bug timeouts for apr must be prototyped in apr_interval_time_t;
+ * this changes in 2.0
*/
APU_DECLARE(apr_status_t) apr_memcache_set(apr_memcache_t *mc,
const char *key,
Re: svn commit: r1003375 - /apr/apr-util/branches/1.3.x/include/apr_memcache.h
Posted by Jeff Trawick <tr...@gmail.com>.
On Thu, Sep 30, 2010 at 11:31 PM, <wr...@apache.org> wrote:
> Author: wrowe
> Date: Fri Oct 1 03:31:56 2010
> New Revision: 1003375
>
> URL: http://svn.apache.org/viewvc?rev=1003375&view=rev
> Log:
> Note bug
>
> Modified:
> apr/apr-util/branches/1.3.x/include/apr_memcache.h
>
> Modified: apr/apr-util/branches/1.3.x/include/apr_memcache.h
> URL: http://svn.apache.org/viewvc/apr/apr-util/branches/1.3.x/include/apr_memcache.h?rev=1003375&r1=1003374&r2=1003375&view=diff
> ==============================================================================
> --- apr/apr-util/branches/1.3.x/include/apr_memcache.h (original)
> +++ apr/apr-util/branches/1.3.x/include/apr_memcache.h Fri Oct 1 03:31:56 2010
> @@ -287,6 +287,9 @@ APU_DECLARE(apr_status_t) apr_memcache_m
> * @param data_size length of data at baton
> * @param timeout time in seconds for the data to live on the server
> * @param flags any flags set by the client for this key
> + * @bug timeout is not implemented
Do you recall the details of the bug? The timeout here is the server
timeout, and it is written to the server in the protocol data.
klen = apr_snprintf(conn->buffer, BUFFER_SIZE, " %u %u %"
APR_SIZE_T_FMT " " MC_EOL,
flags, timeout, data_size);
vec[2].iov_base = conn->buffer;
vec[2].iov_len = klen;
> + * @bug timeouts for apr must be prototyped in apr_interval_time_t;
> + * this changes in 2.0
(committed only to the 1.3.x branch)
> */
> APU_DECLARE(apr_status_t) apr_memcache_set(apr_memcache_t *mc,
> const char *key,