You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/21 18:35:22 UTC

[GitHub] [tvm] areusch commented on a diff in pull request #11045: [docs] Add lightweight docs image

areusch commented on code in PR #11045:
URL: https://github.com/apache/tvm/pull/11045#discussion_r855488162


##########
docker/build.sh:
##########
@@ -99,6 +99,11 @@ if [[ "$1" == "--cache-from" ]]; then
     shift 1
 fi
 
+if [[ "$1" == "--cache" ]]; then

Review Comment:
   can you add to the docs above?



##########
tests/scripts/ci.py:
##########
@@ -239,20 +231,20 @@ def docs(
     skip_build -- skip build and setup scripts
     interactive -- start a shell after running build / test scripts
     """
-    config = "./tests/scripts/task_config_build_gpu.sh"
     build_dir = get_build_dir("gpu")
     if cpu and full:

Review Comment:
   should we change the cpu flag name here too? seems like it's more like tutorials or not



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org