You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Tobias Bocanegra (JIRA)" <ji...@apache.org> on 2008/09/17 16:25:44 UTC
[jira] Created: (SLING-663) Make sling:Folder more folder like
Make sling:Folder more folder like
----------------------------------
Key: SLING-663
URL: https://issues.apache.org/jira/browse/SLING-663
Project: Sling
Issue Type: Wish
Components: API
Reporter: Tobias Bocanegra
the current sling:Folder looks like this:
[sling:Folder] > nt:hierarchyNode, nt:unstructured
orderable
+ * (nt:base) = sling:Folder version
this is very convenient since it allows all kind of properties and nodes.
But imo it's wrong that it is orderable. since folders dont have an
order (at least in no FS is know).
furthermore, i find it 'wrong' to allow * child nodes. if you want to
add an arbitrary child node to a folder, we should use the
sling:HierarchyNode mixin. as for the * properties, i think they are ok and should stay.
the only inconvenience about nt:folder is, that is does not define a
default primary type.
so i suggest to change sling:Folder to:
[sling:Folder] > nt:folder
- * (undefined) multiple
- * (undefined)
+ * (nt:hierarchyNode) = sling:Folder version
and add:
[sling:HierarchyNode] > nt:hierarchyNode mixin
[sling:OrderedFolder] > sling:Folder orderable
+ * (nt:hierarchyNode) = sling:OrderedFolder version
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-663) Make sling:Folder more folder like
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger updated SLING-663:
------------------------------------
Component/s: (was: API)
JCR Resource
Fix Version/s: JCR Resource 2.0.4
Affects Version/s: JCR Resource 2.0.2
> Make sling:Folder more folder like
> ----------------------------------
>
> Key: SLING-663
> URL: https://issues.apache.org/jira/browse/SLING-663
> Project: Sling
> Issue Type: Wish
> Components: JCR Resource
> Affects Versions: JCR Resource 2.0.2
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Fix For: JCR Resource 2.0.4
>
>
> the current sling:Folder looks like this:
> [sling:Folder] > nt:hierarchyNode, nt:unstructured
> orderable
> + * (nt:base) = sling:Folder version
> this is very convenient since it allows all kind of properties and nodes.
> But imo it's wrong that it is orderable. since folders dont have an
> order (at least in no FS is know).
> furthermore, i find it 'wrong' to allow * child nodes. if you want to
> add an arbitrary child node to a folder, we should use the
> sling:HierarchyNode mixin. as for the * properties, i think they are ok and should stay.
> the only inconvenience about nt:folder is, that is does not define a
> default primary type.
> so i suggest to change sling:Folder to:
> [sling:Folder] > nt:folder
> - * (undefined) multiple
> - * (undefined)
> + * (nt:hierarchyNode) = sling:Folder version
> and add:
> [sling:HierarchyNode] > nt:hierarchyNode mixin
> [sling:OrderedFolder] > sling:Folder orderable
> + * (nt:hierarchyNode) = sling:OrderedFolder version
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-663) Make sling:Folder more folder like
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-663:
---------------------------------------
Assignee: Felix Meschberger
> Make sling:Folder more folder like
> ----------------------------------
>
> Key: SLING-663
> URL: https://issues.apache.org/jira/browse/SLING-663
> Project: Sling
> Issue Type: Wish
> Components: API
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
>
> the current sling:Folder looks like this:
> [sling:Folder] > nt:hierarchyNode, nt:unstructured
> orderable
> + * (nt:base) = sling:Folder version
> this is very convenient since it allows all kind of properties and nodes.
> But imo it's wrong that it is orderable. since folders dont have an
> order (at least in no FS is know).
> furthermore, i find it 'wrong' to allow * child nodes. if you want to
> add an arbitrary child node to a folder, we should use the
> sling:HierarchyNode mixin. as for the * properties, i think they are ok and should stay.
> the only inconvenience about nt:folder is, that is does not define a
> default primary type.
> so i suggest to change sling:Folder to:
> [sling:Folder] > nt:folder
> - * (undefined) multiple
> - * (undefined)
> + * (nt:hierarchyNode) = sling:Folder version
> and add:
> [sling:HierarchyNode] > nt:hierarchyNode mixin
> [sling:OrderedFolder] > sling:Folder orderable
> + * (nt:hierarchyNode) = sling:OrderedFolder version
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-663) Make sling:Folder more folder like
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632611#action_12632611 ]
Alexander Klimetschek commented on SLING-663:
---------------------------------------------
I think since it is not that uncommon to have nt:unstructured/non hierarchy nodes inside a sling:Folder (eg. /libs/mylib is a sling:Folder because of webdav, but inside you have a node for your mylib specific stuff that could be anything), it would be good to allow any child nodes in a sling:Folder. Wasn't it the original purpose of the sling:Folder to combine nt:folder (for WebDav) and nt:unstructured?
> Make sling:Folder more folder like
> ----------------------------------
>
> Key: SLING-663
> URL: https://issues.apache.org/jira/browse/SLING-663
> Project: Sling
> Issue Type: Wish
> Components: JCR Resource
> Affects Versions: JCR Resource 2.0.2
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Fix For: JCR Resource 2.0.4
>
>
> the current sling:Folder looks like this:
> [sling:Folder] > nt:hierarchyNode, nt:unstructured
> orderable
> + * (nt:base) = sling:Folder version
> this is very convenient since it allows all kind of properties and nodes.
> But imo it's wrong that it is orderable. since folders dont have an
> order (at least in no FS is know).
> furthermore, i find it 'wrong' to allow * child nodes. if you want to
> add an arbitrary child node to a folder, we should use the
> sling:HierarchyNode mixin. as for the * properties, i think they are ok and should stay.
> the only inconvenience about nt:folder is, that is does not define a
> default primary type.
> so i suggest to change sling:Folder to:
> [sling:Folder] > nt:folder
> - * (undefined) multiple
> - * (undefined)
> + * (nt:hierarchyNode) = sling:Folder version
> and add:
> [sling:HierarchyNode] > nt:hierarchyNode mixin
> [sling:OrderedFolder] > sling:Folder orderable
> + * (nt:hierarchyNode) = sling:OrderedFolder version
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SLING-663) Make sling:Folder more folder like
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reopened SLING-663:
-------------------------------------
The integration build currently breaks in the HttpPing and InitialContent tests because the ContentLoaderService is not able to create its status nodes due to the limitation noted on the dev-list in [1].
Reopening this issue for further fixing.
[1] http://markmail.org/message/7t4opk3fzmt7csxn
> Make sling:Folder more folder like
> ----------------------------------
>
> Key: SLING-663
> URL: https://issues.apache.org/jira/browse/SLING-663
> Project: Sling
> Issue Type: Wish
> Components: JCR Resource
> Affects Versions: JCR Resource 2.0.2
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Fix For: JCR Resource 2.0.4
>
>
> the current sling:Folder looks like this:
> [sling:Folder] > nt:hierarchyNode, nt:unstructured
> orderable
> + * (nt:base) = sling:Folder version
> this is very convenient since it allows all kind of properties and nodes.
> But imo it's wrong that it is orderable. since folders dont have an
> order (at least in no FS is know).
> furthermore, i find it 'wrong' to allow * child nodes. if you want to
> add an arbitrary child node to a folder, we should use the
> sling:HierarchyNode mixin. as for the * properties, i think they are ok and should stay.
> the only inconvenience about nt:folder is, that is does not define a
> default primary type.
> so i suggest to change sling:Folder to:
> [sling:Folder] > nt:folder
> - * (undefined) multiple
> - * (undefined)
> + * (nt:hierarchyNode) = sling:Folder version
> and add:
> [sling:HierarchyNode] > nt:hierarchyNode mixin
> [sling:OrderedFolder] > sling:Folder orderable
> + * (nt:hierarchyNode) = sling:OrderedFolder version
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-663) Make sling:Folder more folder like
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger resolved SLING-663.
-------------------------------------
Resolution: Fixed
Applied the changes in Rev. 696568
This change brings a few changes to how sling:Folder works:
* child node entries are not orderable any more. This probably makes sense in that it replicates generic filesystem folder behaviour
* sling:Folder now extends nt:folder making handling easier
* the required child node type is no nt:hierarchyNode
To help with migration and use of sling:Folder two new node types are added:
* sling:HierarchyNode is a mixin node type allowing to turn any node into a nt:hierarchyNode
* sling:OrderedFolder is a sling:Folder which has orderable child nodes
Please close this issue, if this resolution is ok for you. Thanks.
> Make sling:Folder more folder like
> ----------------------------------
>
> Key: SLING-663
> URL: https://issues.apache.org/jira/browse/SLING-663
> Project: Sling
> Issue Type: Wish
> Components: JCR Resource
> Affects Versions: JCR Resource 2.0.2
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Fix For: JCR Resource 2.0.4
>
>
> the current sling:Folder looks like this:
> [sling:Folder] > nt:hierarchyNode, nt:unstructured
> orderable
> + * (nt:base) = sling:Folder version
> this is very convenient since it allows all kind of properties and nodes.
> But imo it's wrong that it is orderable. since folders dont have an
> order (at least in no FS is know).
> furthermore, i find it 'wrong' to allow * child nodes. if you want to
> add an arbitrary child node to a folder, we should use the
> sling:HierarchyNode mixin. as for the * properties, i think they are ok and should stay.
> the only inconvenience about nt:folder is, that is does not define a
> default primary type.
> so i suggest to change sling:Folder to:
> [sling:Folder] > nt:folder
> - * (undefined) multiple
> - * (undefined)
> + * (nt:hierarchyNode) = sling:Folder version
> and add:
> [sling:HierarchyNode] > nt:hierarchyNode mixin
> [sling:OrderedFolder] > sling:Folder orderable
> + * (nt:hierarchyNode) = sling:OrderedFolder version
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-663) Make sling:Folder more folder like
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-663.
-----------------------------------
Resolution: Fixed
After changing the node type definition in Rev. 697080, any node is allowed again below sling:Folder, yet the default node type is sling:Folder.
Integration tests now run smoothly (except the JSONRenderer test on some systems, but this is a different issue...)
> Make sling:Folder more folder like
> ----------------------------------
>
> Key: SLING-663
> URL: https://issues.apache.org/jira/browse/SLING-663
> Project: Sling
> Issue Type: Wish
> Components: JCR Resource
> Affects Versions: JCR Resource 2.0.2
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Fix For: JCR Resource 2.0.4
>
>
> the current sling:Folder looks like this:
> [sling:Folder] > nt:hierarchyNode, nt:unstructured
> orderable
> + * (nt:base) = sling:Folder version
> this is very convenient since it allows all kind of properties and nodes.
> But imo it's wrong that it is orderable. since folders dont have an
> order (at least in no FS is know).
> furthermore, i find it 'wrong' to allow * child nodes. if you want to
> add an arbitrary child node to a folder, we should use the
> sling:HierarchyNode mixin. as for the * properties, i think they are ok and should stay.
> the only inconvenience about nt:folder is, that is does not define a
> default primary type.
> so i suggest to change sling:Folder to:
> [sling:Folder] > nt:folder
> - * (undefined) multiple
> - * (undefined)
> + * (nt:hierarchyNode) = sling:Folder version
> and add:
> [sling:HierarchyNode] > nt:hierarchyNode mixin
> [sling:OrderedFolder] > sling:Folder orderable
> + * (nt:hierarchyNode) = sling:OrderedFolder version
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.