You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/02/28 21:02:43 UTC

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6179

Change subject: IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.
......................................................................

IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_breakpad.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_ldap.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_processes.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_ssl.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_webui.xml
18 files changed, 2 insertions(+), 561 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/6179/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM
......................................................................


Patch Set 5:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/53/

-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6179/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.
commit message out of bounds.


http://gerrit.cloudera.org:8080/#/c/6179/2/docs/topics/impala_breakpad.xml
File docs/topics/impala_breakpad.xml:

PS2, Line 90: Clusters not managed by cluster management software:
this is unnecessary now - you could just remove this line completely. Although this is probably a case with several other places in the docs once we get rid of all the 'if you are using CM' mentions.


-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM
......................................................................


Patch Set 5:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/54/

-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM
......................................................................


IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Reviewed-on: http://gerrit.cloudera.org:8080/6179
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Tested-by: Impala Public Jenkins
Reviewed-by: John Russell <jr...@cloudera.com>
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admin.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_breakpad.xml
D docs/topics/impala_cm_installation.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_hbase.xml
D docs/topics/impala_howto_rm.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_ldap.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_processes.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_ssl.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_webui.xml
22 files changed, 2 insertions(+), 1,082 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Ambreen Kazi: Looks good to me, but someone else must approve
  John Russell: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#4).

Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM
......................................................................

IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_breakpad.xml
D docs/topics/impala_cm_installation.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_hbase.xml
D docs/topics/impala_howto_rm.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_ldap.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_processes.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_ssl.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_webui.xml
20 files changed, 3 insertions(+), 1,075 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/6179/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM
......................................................................


Patch Set 5: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6179/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.
> commit message out of bounds.
Done


http://gerrit.cloudera.org:8080/#/c/6179/2/docs/topics/impala_breakpad.xml
File docs/topics/impala_breakpad.xml:

PS2, Line 90: Clusters not managed by cluster management software:
> this is unnecessary now - you could just remove this line completely. Altho
Right, I'll leave this for the moment because it is highly likely to be handled by Laurel in a different code review.


-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).

Change subject: IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.
......................................................................

IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_breakpad.xml
D docs/topics/impala_cm_installation.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_hbase.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_ldap.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_processes.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_ssl.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_webui.xml
19 files changed, 2 insertions(+), 635 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/6179/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM
......................................................................


Patch Set 5: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#5).

Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM
......................................................................

IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admin.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_breakpad.xml
D docs/topics/impala_cm_installation.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_hbase.xml
D docs/topics/impala_howto_rm.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_ldap.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_processes.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_ssl.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_webui.xml
22 files changed, 2 insertions(+), 1,082 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/6179/5
-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM
......................................................................


Patch Set 4:

I don't have a clean build. Are there references to impala_howto_rm still remaining in the docs? Several errors related to it.

-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).

Change subject: IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.
......................................................................

IMPALA-3401: [DOCS] Physically remove blocks of content devoted to Cloudera Manager.

Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_admission.xml
M docs/topics/impala_authorization.xml
M docs/topics/impala_breakpad.xml
D docs/topics/impala_cm_installation.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_hbase.xml
D docs/topics/impala_howto_rm.xml
M docs/topics/impala_incompatible_changes.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_ldap.xml
M docs/topics/impala_logging.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_processes.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_scalability.xml
M docs/topics/impala_ssl.xml
M docs/topics/impala_txtfile.xml
M docs/topics/impala_webui.xml
20 files changed, 3 insertions(+), 1,075 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/6179/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-3401: [DOCS] Remove blocks of content devoted to CM

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3401: [DOCS] Remove blocks of content devoted to CM
......................................................................


Patch Set 5: Code-Review+1

Clean build. Checked a few files and looks like the changes made it in.

-- 
To view, visit http://gerrit.cloudera.org:8080/6179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07d56463939fe152c1c6124cc0ad5591337bad6b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No