You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "rzo1 (via GitHub)" <gi...@apache.org> on 2023/08/15 13:51:04 UTC
[PR] STORM-3949 - libthrift 0.18.1 (storm)
rzo1 opened a new pull request, #3564:
URL: https://github.com/apache/storm/pull/3564
## What is the purpose of the change
- Upgrade `libthrift` to 0.18.1
## How was the change tested
- Run tests locally similar to GH actions
- GH actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3949] libthrift 0.18.1 (storm)
Posted by "agresch (via GitHub)" <gi...@apache.org>.
agresch commented on PR #3564:
URL: https://github.com/apache/storm/pull/3564#issuecomment-1796384706
When storm upgraded to thrift 0.13 initially, we would see huge CPU spikes on supervisors and nimbus after approximately 24 hours for unknown reasons. The problem went away when we backed out that change. Just wondering if anyone has seen any performance issues of note with this change so far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3949] libthrift 0.18.1 (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3564:
URL: https://github.com/apache/storm/pull/3564#issuecomment-1796531951
@agresch think we will see after a 2.6.0 ist available because I doubt anyone is using the Last SNAPSHOT build in a staging environment ,et.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3949] libthrift 0.18.1 (storm)
Posted by "bipinprasad (via GitHub)" <gi...@apache.org>.
bipinprasad commented on code in PR #3564:
URL: https://github.com/apache/storm/pull/3564#discussion_r1294952064
##########
DEPENDENCY-LICENSES:
##########
@@ -114,6 +114,7 @@ List of third-party dependencies grouped by their license type.
* Apache HttpCore (org.apache.httpcomponents:httpcore:4.4.10 - http://hc.apache.org/httpcomponents-core-ga)
* Apache HttpCore (org.apache.httpcomponents:httpcore:4.4.13 - http://hc.apache.org/httpcomponents-core-ga)
* Apache HttpCore (org.apache.httpcomponents:httpcore:4.4.1 - http://hc.apache.org/httpcomponents-core-ga)
+ * Apache HttpCore (org.apache.httpcomponents:httpcore:4.4.4 - http://hc.apache.org/httpcomponents-core-ga)
Review Comment:
if possible, can we use just the 4.4.5 version below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3949] libthrift 0.18.1 (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 merged PR #3564:
URL: https://github.com/apache/storm/pull/3564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3949] libthrift 0.18.1 (storm)
Posted by "avermeer (via GitHub)" <gi...@apache.org>.
avermeer commented on PR #3564:
URL: https://github.com/apache/storm/pull/3564#issuecomment-1799118025
I have been running my pre-production topologies with Storm 2.6.0 SNAPSHOT
build of the 2023/11/03, with a flow ~1000 tuples/minutes since 2 days,and
so far my metrics on latency, Kafka lag, etc aren't showing regressions ;
consumption is even more stable than with Storm 2.5.0.
on Supervisor machines, CPU & Memory are behaving "just as usual"
Please note that I haven't rebuilt my topologies bigjars with 2.6.0
dependencies (but I fixed some trivial issues related to old bad practices).
Alexandre
Le lun. 6 nov. 2023 à 22:38, Richard Zowalla ***@***.***> a
écrit :
> @agresch <https://github.com/agresch> think we will see after a 2.6.0 ist
> available because I doubt anyone is using the Last SNAPSHOT build in a
> staging environment ,et.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/storm/pull/3564#issuecomment-1796531951>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AEIJEMPYONB5FHCE7SJ5YDDYDFKDTAVCNFSM6AAAAAA3RDE5T2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJWGUZTCOJVGE>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3949] libthrift 0.18.1 (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #3564:
URL: https://github.com/apache/storm/pull/3564#discussion_r1295067635
##########
DEPENDENCY-LICENSES:
##########
@@ -114,6 +114,7 @@ List of third-party dependencies grouped by their license type.
* Apache HttpCore (org.apache.httpcomponents:httpcore:4.4.10 - http://hc.apache.org/httpcomponents-core-ga)
* Apache HttpCore (org.apache.httpcomponents:httpcore:4.4.13 - http://hc.apache.org/httpcomponents-core-ga)
* Apache HttpCore (org.apache.httpcomponents:httpcore:4.4.1 - http://hc.apache.org/httpcomponents-core-ga)
+ * Apache HttpCore (org.apache.httpcomponents:httpcore:4.4.4 - http://hc.apache.org/httpcomponents-core-ga)
Review Comment:
I cleaned it up, so we only have one version of httpclient / httpcore in the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org