You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/11 10:02:41 UTC

[GitHub] [airflow] aru-trackunit commented on a diff in pull request #28852: Fixing get_conn_uri method - adding ``@`` when login, password, host, port is not given

aru-trackunit commented on code in PR #28852:
URL: https://github.com/apache/airflow/pull/28852#discussion_r1066798202


##########
tests/always/test_connection.py:
##########
@@ -275,13 +275,13 @@ def test_connection_extra_with_encryption_rotate_fernet_key(self):
             description="no schema",
         ),
         UriTestCaseConfig(
-            test_conn_uri="google-cloud-platform://?key_path=%2Fkeys%2Fkey.json&scope="
+            test_conn_uri="google-cloud-platform://@/?key_path=%2Fkeys%2Fkey.json&scope="

Review Comment:
   Ideally I wouldn't update tests, but as far as I understand it doesn't comply with the CLI contract.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org