You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/05/12 10:11:17 UTC
[GitHub] [hadoop-thirdparty] jojochuang opened a new pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script
jojochuang opened a new pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14
(1) Hard code a python dependency version to avoid image build error.
(2) Remove npm which is not used for building hadoop-thirdparty to avoid image build error.
(2) Migrate to Ubuntu 18.04 (Bionic) to use GPG 2.2 (LTS) instead of 1.x for signing.
The build script runs a gpg agent inside docker that shares the gpg keys with the host machine, of which most ships GPG2.2. GPG 1.x is quite old and is not compatible with GPG 2.x. Ubuntu 16.04 (Xenia) has gpg2.1 packages, which is incompatible with gpg2.2. Ubuntu 18.04 installs gpg 2.2 by default.
Test: manually tested by running `dev-support/bin/create-release --asfrelease --docker --dockercache`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script
Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-839651970
This change blocks the hadoop-thirdparty 1.1.0 release. Please review @aajisaka @ayushtkn @vinayakumarb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
[GitHub] [hadoop-thirdparty] jojochuang commented on pull request #14: HADOOP-17692. [thirdparty] Fix the docker image
Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-840305102
Thanks @aajisaka !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
[GitHub] [hadoop-thirdparty] aajisaka commented on pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script
Posted by GitBox <gi...@apache.org>.
aajisaka commented on pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#issuecomment-840239920
Thank you @jojochuang. Maybe we need to update the description to something like "Fix the docker image".
In the future, I want to clean up the Dockerfile:
- Upgrade Yetus to 0.13.0 and Python to 3.x
- Upgrade to Focal
- Remove unused libraries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
[GitHub] [hadoop-thirdparty] aajisaka commented on a change in pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631520733
##########
File path: dev-support/docker/Dockerfile
##########
@@ -93,20 +94,8 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
-
-######
-# Install cmake 3.1.0 (3.5.1 ships with Xenial)
-######
-RUN mkdir -p /opt/cmake \
- && curl -L -s -S \
- https://cmake.org/files/v3.1/cmake-3.1.0-Linux-x86_64.tar.gz \
- -o /opt/cmake.tar.gz \
- && tar xzf /opt/cmake.tar.gz --strip-components 1 -C /opt/cmake
-ENV CMAKE_HOME /opt/cmake
-ENV PATH "${PATH}:/opt/cmake/bin"
-
######
-# Install Google Protobuf 3.7.1 (2.6.0 ships with Xenial)
+# Install Google Protobuf 3.7.1 (3.0.0 ships with Bionic)
Review comment:
I think protobuf is not required and can be removed to build the image faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #14: HADOOP-17692. Update Hadoop-thirdparty release script
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631526674
##########
File path: dev-support/docker/Dockerfile
##########
@@ -93,20 +94,8 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
-
-######
-# Install cmake 3.1.0 (3.5.1 ships with Xenial)
-######
-RUN mkdir -p /opt/cmake \
- && curl -L -s -S \
- https://cmake.org/files/v3.1/cmake-3.1.0-Linux-x86_64.tar.gz \
- -o /opt/cmake.tar.gz \
- && tar xzf /opt/cmake.tar.gz --strip-components 1 -C /opt/cmake
-ENV CMAKE_HOME /opt/cmake
-ENV PATH "${PATH}:/opt/cmake/bin"
-
######
-# Install Google Protobuf 3.7.1 (2.6.0 ships with Xenial)
+# Install Google Protobuf 3.7.1 (3.0.0 ships with Bionic)
Review comment:
a! you're perfectly right. I kept thinking we shade protobuf so we need it. But we don't use protoc to compile proto files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
[GitHub] [hadoop-thirdparty] jojochuang merged pull request #14: HADOOP-17692. [thirdparty] Fix the docker image
Posted by GitBox <gi...@apache.org>.
jojochuang merged pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
[GitHub] [hadoop-thirdparty] jojochuang commented on a change in pull request #14: HADOOP-17692. [thirdparty] Fix the docker image
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #14:
URL: https://github.com/apache/hadoop-thirdparty/pull/14#discussion_r631539990
##########
File path: dev-support/docker/Dockerfile
##########
@@ -93,20 +94,8 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
-
-######
-# Install cmake 3.1.0 (3.5.1 ships with Xenial)
-######
-RUN mkdir -p /opt/cmake \
- && curl -L -s -S \
- https://cmake.org/files/v3.1/cmake-3.1.0-Linux-x86_64.tar.gz \
- -o /opt/cmake.tar.gz \
- && tar xzf /opt/cmake.tar.gz --strip-components 1 -C /opt/cmake
-ENV CMAKE_HOME /opt/cmake
-ENV PATH "${PATH}:/opt/cmake/bin"
-
######
-# Install Google Protobuf 3.7.1 (2.6.0 ships with Xenial)
+# Install Google Protobuf 3.7.1 (3.0.0 ships with Bionic)
Review comment:
Updated. Please review, @aajisaka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org