You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/30 16:59:24 UTC
[GitHub] [airflow] Swalloow commented on a diff in pull request #24220: Add support for KEDA HPA config to Helm Chart
Swalloow commented on code in PR #24220:
URL: https://github.com/apache/airflow/pull/24220#discussion_r911257842
##########
tests/charts/test_keda.py:
##########
@@ -52,6 +52,50 @@ def test_keda_enabled(self, executor, is_created):
else:
assert docs == []
+ @parameterized.expand(
+ [
+ ('CeleryExecutor'),
+ ('CeleryKubernetesExecutor'),
+ ]
+ )
+ def test_keda_advanced(self, executor):
+ """
+ Verify keda advanced config.
+ """
+ expected_advanced = {
+ "horizontalPodAutoscalerConfig": {
+ "behavior": {
+ "scaleDown": {
+ "stabilizationWindowSeconds": 300,
+ "policies": [{"type": "Percent", "value": 100, "periodSeconds": 15}],
+ }
+ }
+ }
+ }
+ docs = render_chart(
+ values={
+ "workers": {
+ "keda": {
+ "enabled": True,
+ "advanced": {
+ "horizontalPodAutoscalerConfig": {
+ "behavior": {
+ "scaleDown": {
+ "stabilizationWindowSeconds": 300,
+ "policies": [{"type": "Percent", "value": 100, "periodSeconds": 15}],
+ }
+ }
+ }
+ },
+ },
+ "persistence": {"enabled": False},
Review Comment:
Thanks, I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org