You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/03 12:51:48 UTC

[GitHub] [spark] Swinky commented on pull request #31724: [SPARK-34222][SQL][FollowUp] Non-recursive implementation of buildBalancedPredicate

Swinky commented on pull request #31724:
URL: https://github.com/apache/spark/pull/31724#issuecomment-789692664


   for N predicates, number of recursive calls on stack are `logN`, (with base 2) for `buildBalancedPredicate`.
   
   If we have such huge predicates then it would fail with stackoverflow in `splitDisjunctivePredicates` and `splitConjunctivePredicates` before this ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org