You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2017/07/17 02:26:48 UTC
[GitHub] incubator-guacamole-client pull request #177: GUACAMOLE-339: Add Remote Host...
GitHub user necouchman opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/177
GUACAMOLE-339: Add Remote Host to Connection History Table
This pull request adds the necessary fields and methods to the JDBC module to track the remote host in the connection history table, and to display it in the various history output tables in the client interface.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/incubator-guacamole-client GUACAMOLE-339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #177
----
commit f2120c8d14ddb86ebdac1cf27e4c93b164401e01
Author: Nick Couchman <ni...@yahoo.com>
Date: 2017-07-17T01:58:28Z
GUACAMOLE-339: Add remote host field to database and populate appropriately.
commit 7522a495b823f7facaa571cf743613d85fe59e7a
Author: Nick Couchman <ni...@yahoo.com>
Date: 2017-07-17T02:23:00Z
GUACAMOLE-339: Display the remote host field in connection history tables.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #177: GUACAMOLE-339: Add Remote Host...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-client/pull/177
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #177: GUACAMOLE-339: Add Remote Host...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/177#discussion_r127626364
--- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/schema/001-create-schema.sql ---
@@ -322,6 +322,7 @@ CREATE TABLE `guacamole_connection_history` (
`history_id` int(11) NOT NULL AUTO_INCREMENT,
`user_id` int(11) DEFAULT NULL,
`username` varchar(128) NOT NULL,
+ `remote_host` varchar(128) DEFAULT NULL,
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-client pull request #177: GUACAMOLE-339: Add Remote Host...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/177#discussion_r127626203
--- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/schema/001-create-schema.sql ---
@@ -322,6 +322,7 @@ CREATE TABLE `guacamole_connection_history` (
`history_id` int(11) NOT NULL AUTO_INCREMENT,
`user_id` int(11) DEFAULT NULL,
`username` varchar(128) NOT NULL,
+ `remote_host` varchar(128) DEFAULT NULL,
--- End diff --
Do you think we may need more that 128 characters?
Googling around a bit, the maximum length of any particular domain name in DNS is 253 characters, while fully-qualified hostnames are generally limited to 255 characters on UNIX and others. Based on that, I'd say this should be bumped up to 256.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---