[GitHub] [kafka] kirktrue commented on pull request #13659: MINOR: add docs to remind reader that impl of ConsumerPartitionAssign…

["kirktrue (via GitHub)" <gi...@apache.org>]

kirktrue commented on PR #13659:
URL: https://github.com/apache/kafka/pull/13659#issuecomment-1533285689

   This looks good to me.
   
   I looked briefly at the code that calls [`configure()`](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignor.java#L307). But I was a little surprised when I ran the [`ConsumerPartitionAssignorTest`](https://github.com/apache/kafka/blob/trunk/clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignorTest.java) with code coverage enabled and those particular tests aren't actually testing that functionality.
    
   Would you be up for adding a test or two to `ConsumerPartitionAssignorTest` to make sure that functionality is properly covered? If not, I'm happy to add it myself.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org