You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Vamsee Yarlagadda <va...@cloudera.com> on 2017/09/12 01:00:33 UTC

Re: Review Request 62231: SENTRY-1946: getPathsUpdatesFrom() got its boolean logic inversed which results in sending two snapshots at the same time

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62231/
-----------------------------------------------------------

(Updated Sept. 12, 2017, 1 a.m.)


Review request for sentry, Alexander Kolbasov and Sergio Pena.


Summary (updated)
-----------------

SENTRY-1946: getPathsUpdatesFrom() got its boolean logic inversed which results in sending two snapshots at the same time


Repository: sentry


Description
-------

SENTRY-1946: Conditional error in SENTRY-1931 results in sending two snapshots at the same time


Diffs
-----

  sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java 2866ab348390e092d0c1732c6ab8a8bea0529a4b 


Diff: https://reviews.apache.org/r/62231/diff/1/


Testing
-------

In progress


Thanks,

Vamsee Yarlagadda


Re: Review Request 62231: SENTRY-1946: getPathsUpdatesFrom() got its boolean logic inversed which results in sending two snapshots at the same time

Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62231/#review185131
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Kolbasov


On Sept. 12, 2017, 1 a.m., Vamsee Yarlagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62231/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2017, 1 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1946: Conditional error in SENTRY-1931 results in sending two snapshots at the same time
> 
> 
> Diffs
> -----
> 
>   sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java 2866ab348390e092d0c1732c6ab8a8bea0529a4b 
> 
> 
> Diff: https://reviews.apache.org/r/62231/diff/1/
> 
> 
> Testing
> -------
> 
> In progress
> 
> 
> Thanks,
> 
> Vamsee Yarlagadda
> 
>


Re: Review Request 62231: SENTRY-1946: getPathsUpdatesFrom() got its boolean logic inversed which results in sending two snapshots at the same time

Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62231/#review185209
-----------------------------------------------------------


Ship it!




Ship It!

- Na Li


On Sept. 12, 2017, 1 a.m., Vamsee Yarlagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62231/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2017, 1 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov and Sergio Pena.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1946: Conditional error in SENTRY-1931 results in sending two snapshots at the same time
> 
> 
> Diffs
> -----
> 
>   sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java 2866ab348390e092d0c1732c6ab8a8bea0529a4b 
> 
> 
> Diff: https://reviews.apache.org/r/62231/diff/1/
> 
> 
> Testing
> -------
> 
> In progress
> 
> 
> Thanks,
> 
> Vamsee Yarlagadda
> 
>