You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/18 04:20:47 UTC
[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request
#4818: For issue4778, modify registry center root node
menghaoranss opened a new pull request #4818: For issue4778, modify registry center root node
URL: https://github.com/apache/incubator-shardingsphere/pull/4818
For #4778 .
Changes proposed in this pull request:
- change registry center root node from `state` to `registry`
- modify registry center listener manager class name
- refactor unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss closed pull request #4818:
For issue4778, modify registry center root node
Posted by GitBox <gi...@apache.org>.
menghaoranss closed pull request #4818: For issue4778, modify registry center root node
URL: https://github.com/apache/incubator-shardingsphere/pull/4818
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4818: For
issue4778, modify registry center root node
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4818: For issue4778, modify registry center root node
URL: https://github.com/apache/incubator-shardingsphere/pull/4818#issuecomment-600422937
## Pull Request Test Coverage Report for [Build 10343](https://coveralls.io/builds/29435434)
* **5** of **5** **(100.0%)** changed or added relevant lines in **3** files are covered.
* **18** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.08%**) to **59.896%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29435434/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/history/HistoryDataSyncTask.java](https://coveralls.io/builds/29435434/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Fhistory%2FHistoryDataSyncTask.java#L116) | 7 | 76.47% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/execute/executor/channel/MemoryChannel.java](https://coveralls.io/builds/29435434/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fexecute%2Fexecutor%2Fchannel%2FMemoryChannel.java#L61) | 8 | 51.85% |
<!-- | **Total:** | **18** | | -->
| Totals | [](https://coveralls.io/builds/29435434) |
| :-- | --: |
| Change from base [Build 1104](https://coveralls.io/builds/29434523): | -0.08% |
| Covered Lines: | 12553 |
| Relevant Lines: | 20958 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss commented on issue #4818:
For issue4778, modify registry center root node
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #4818: For issue4778, modify registry center root node
URL: https://github.com/apache/incubator-shardingsphere/pull/4818#issuecomment-600530697
I will resubmit after 4.1.0 released
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4818: For
issue4778, modify registry center root node
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4818: For issue4778, modify registry center root node
URL: https://github.com/apache/incubator-shardingsphere/pull/4818#issuecomment-600421607
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818?src=pr&el=h1) Report
> Merging [#4818](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/a6697dfceebac35d6abc388a77ef714f0d764833&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4818 +/- ##
=========================================
Coverage 56.36% 56.36%
Complexity 449 449
=========================================
Files 1166 1166
Lines 20957 20958 +1
Branches 3885 3885
=========================================
+ Hits 11812 11814 +2
Misses 8417 8417
+ Partials 728 727 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ration/core/registrycenter/RegistryCenterNode.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLXJlZ2lzdHJ5Y2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvcmVnaXN0cnljZW50ZXIvUmVnaXN0cnlDZW50ZXJOb2RlLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...listener/ShardingOrchestrationListenerManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWZhY2FkZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2ZhY2FkZS9saXN0ZW5lci9TaGFyZGluZ09yY2hlc3RyYXRpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...enter/listener/DataSourceStateChangedListener.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLXJlZ2lzdHJ5Y2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvcmVnaXN0cnljZW50ZXIvbGlzdGVuZXIvRGF0YVNvdXJjZVN0YXRlQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `71.42% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gistrycenter/listener/RegistryListenerManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLXJlZ2lzdHJ5Y2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvcmVnaXN0cnljZW50ZXIvbGlzdGVuZXIvUmVnaXN0cnlMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...shardingsphere/test/sql/loader/SQLCasesLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3FsLXRlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL2xvYWRlci9TUUxDYXNlc0xvYWRlci5qYXZh) | `70.37% <0.00%> (-0.88%)` | `0.00% <0.00%> (ø%)` | |
| [...derlying/common/properties/TypedPropertyValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL3Byb3BlcnRpZXMvVHlwZWRQcm9wZXJ0eVZhbHVlLmphdmE=) | `85.71% <0.00%> (+14.28%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818?src=pr&el=footer). Last update [a6697df...1aaf151](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4818?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services