You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 22:52:11 UTC
[GitHub] [spark] maropu commented on a change in pull request #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
maropu commented on a change in pull request #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398218911
##########
File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
##########
@@ -1,12 +1,5 @@
-- Test comments.
-
--- the first case of bracketed comment
---QUERY-DELIMITER-START
-/* This is the first example of bracketed comment.
-SELECT 'ommented out content' AS first;
-*/
-SELECT 'selected content' AS first;
---QUERY-DELIMITER-END
+--IMPORT nested-comments.sql
Review comment:
What did this means?
```
Golden files can't display well.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org