You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/23 18:47:52 UTC
[GitHub] [pulsar] devinbost opened a new pull request, #16204: #16203 Added doc to fix issue with missing client instructions for batch index acknowledgment
devinbost opened a new pull request, #16204:
URL: https://github.com/apache/pulsar/pull/16204
This change is documented here: https://github.com/apache/pulsar/issues/16203
I also made a minor spelling correction on that page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #16204: [doc-complete] #16203 Added doc to fix issue with missing client instructions for batch index acknowledgment
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16204:
URL: https://github.com/apache/pulsar/pull/16204#discussion_r905659760
##########
site2/docs/concepts-messaging.md:
##########
@@ -876,7 +891,7 @@ There are diverse system topics depending on namespaces. The following table out
| host/port | `heartbeat` | Persistent | 1 | Heartbeat detection |
| User-defined-ns | [`__change_events`](concepts-multi-tenancy.md#namespace-change-events-and-topic-level-policies) | Persistent | Default 4 | Topic events |
| User-defined-ns | `__transaction_buffer_snapshot` | Persistent | One per namespace | Transaction buffer snapshots |
-| User-defined-ns | `${topicName}__transaction_pending_ack` | Persistent | One per every topic subscription acknowledged with transactions | Acknowledgements with transactions |
+| User-defined-ns | `${topicName}__transaction_pending_ack` | Persistent | One per every topic subscription acknowledged with transactions | acknowledgments with transactions |
Review Comment:
```suggestion
| User-defined-ns | `${topicName}__transaction_pending_ack` | Persistent | One per every topic subscription acknowledged with transactions | Acknowledgments with transactions |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave merged pull request #16204: [doc-complete] #16203 Added doc to fix issue with missing client instructions for batch index acknowledgment
Posted by GitBox <gi...@apache.org>.
dave2wave merged PR #16204:
URL: https://github.com/apache/pulsar/pull/16204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #16204: [doc-complete] #16203 Added doc to fix issue with missing client instructions for batch index acknowledgment
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16204:
URL: https://github.com/apache/pulsar/pull/16204#discussion_r905660060
##########
site2/docs/concepts-messaging.md:
##########
@@ -903,8 +918,8 @@ Apache Pulsar avoids these and other message delivery failures using at-least-on
To utilize message redelivery, you need to enable this mechanism before the broker can resend the unacknowledged messages in Apache Pulsar client. You can activate the message redelivery mechanism in Apache Pulsar using three methods.
-- [Negative Acknowledgment](#negative-acknowledgement)
-- [Acknowledgement Timeout](#acknowledgement-timeout)
+- [Negative Acknowledgment](#negative-acknowledgment)
+- [acknowledgment Timeout](#acknowledgment-timeout)
Review Comment:
```suggestion
- [Acknowledgment Timeout](#acknowledgment-timeout)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16204: #16203 [doc] Added doc to fix issue with missing client instructions for batch index acknowledgment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16204:
URL: https://github.com/apache/pulsar/pull/16204#issuecomment-1164753884
@devinbost Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #16204: [doc-complete] #16203 Added doc to fix issue with missing client instructions for batch index acknowledgment
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16204:
URL: https://github.com/apache/pulsar/pull/16204#discussion_r905659503
##########
site2/docs/concepts-messaging.md:
##########
@@ -174,16 +189,16 @@ Messages are received from [brokers](reference-terminology.md#broker) either syn
Client libraries provide listener implementation for consumers. For example, the [Java client](client-libraries-java) provides a {@inject: javadoc:MesssageListener:/client/org/apache/pulsar/client/api/MessageListener} interface. In this interface, the `received` method is called whenever a new message is received.
-### Acknowledgement
+### acknowledgment
Review Comment:
```suggestion
### Acknowledgment
```
The first letter should be capitalized in a heading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16204: #16203 Added doc to fix issue with missing client instructions for batch index acknowledgment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16204:
URL: https://github.com/apache/pulsar/pull/16204#issuecomment-1164752943
@devinbost Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16204: [doc-complete] #16203 Added doc to fix issue with missing client instructions for batch index acknowledgment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16204:
URL: https://github.com/apache/pulsar/pull/16204#issuecomment-1164886515
@devinbost Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #16204: [doc-complete] #16203 Added doc to fix issue with missing client instructions for batch index acknowledgment
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #16204:
URL: https://github.com/apache/pulsar/pull/16204#discussion_r905659591
##########
site2/docs/concepts-messaging.md:
##########
@@ -279,11 +294,11 @@ If batching is enabled, all messages in one batch are redelivered to the consume
:::
-### Acknowledgement timeout
+### acknowledgment timeout
Review Comment:
```suggestion
### Acknowledgment timeout
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16204: [doc-complete] #16203 Added doc to fix issue with missing client instructions for batch index acknowledgment
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16204:
URL: https://github.com/apache/pulsar/pull/16204#issuecomment-1164755933
@devinbost Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org