[GitHub] markusthoemmes commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility 
URL: https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r191118454
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala
 ##########
 @@ -51,9 +56,11 @@ import whisk.core.entity.size.SizeLong
  * @param hostname the host name
  * @param timeout the timeout in msecs to wait for a response
  * @param maxResponse the maximum size in bytes the connection will accept
+ * @param maxConcurrent the maximum number of concurrent requests allowed
  */
-protected[core] class HttpUtils(hostname: String, timeout: FiniteDuration, maxResponse: ByteSize) {
-
+protected[core] class HttpUtils(hostname: String, timeout: FiniteDuration, maxResponse: ByteSize, maxConcurrent: Int) {
+  def this(hostname: String, timeout: FiniteDuration, maxResponse: ByteSize) =
+    this(hostname: String, timeout: FiniteDuration, maxResponse: ByteSize, 1)
 
 Review comment:
   Could you not use a default parameter for `maxConcurrent` here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services