You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/02 13:47:14 UTC

[GitHub] [rocketmq] Jacob-Jay opened a new issue #3921: let the code simple

Jacob-Jay opened a new issue #3921:
URL: https://github.com/apache/rocketmq/issues/3921


   https://github.com/apache/rocketmq/blob/c840b208337b26c7529602b81d398c0a87a23888/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java#L247
   
   ` if (ackIndex >= consumeRequest.getMsgs().size()) 
   {
                   ackIndex = consumeRequest.getMsgs().size() - 1;
             }
   int ok = ackIndex + 1;
   int failed = consumeRequest.getMsgs().size() - ok;`
   
   why not ok‘s value is consumeRequest.getMsgs().size() and  failed  zero direct? it's confusing now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] Jacob-Jay closed issue #3921: let the code simple

Posted by GitBox <gi...@apache.org>.
Jacob-Jay closed issue #3921:
URL: https://github.com/apache/rocketmq/issues/3921


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org