You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2013/05/13 23:43:16 UTC
[jira] [Updated] (HDFS-4797) BlockScanInfo does not override
equals(..) and hashCode() consistently
[ https://issues.apache.org/jira/browse/HDFS-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-4797:
-----------------------------------------
Attachment: h4797_20130513.patch
h4797_20130513.patch: remove "implements Comparable" from BlockScanInfo.
> BlockScanInfo does not override equals(..) and hashCode() consistently
> ----------------------------------------------------------------------
>
> Key: HDFS-4797
> URL: https://issues.apache.org/jira/browse/HDFS-4797
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h4797_20130513.patch
>
>
> In the code below, equals(..) compares lastScanTime but hashCode() is computed using block ID. Therefore, it could have two BlockScanInfo objects which are equal but have two different hash codes.
> {code}
> //BlockScanInfo
> @Override
> public int hashCode() {
> return block.hashCode();
> }
>
> @Override
> public boolean equals(Object other) {
> return other instanceof BlockScanInfo &&
> compareTo((BlockScanInfo)other) == 0;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira