[GitHub] [superset] michael-s-molina commented on a diff in pull request #23035: feat: Use AntD table in FilterableTable

["michael-s-molina (via GitHub)" <gi...@apache.org>]

michael-s-molina commented on code in PR #23035:
URL: https://github.com/apache/superset/pull/23035#discussion_r1186057524


##########
superset-frontend/src/components/FilterableTable/index.tsx:
##########
@@ -114,13 +92,10 @@ const StyledFilterableTable = styled.div`
       overflow: hidden;
     }
 
-    .ReactVirtualized__Table__headerColumn,
-    .ReactVirtualized__Table__rowColumn,
-    .grid-cell {
+    .ant-table-cell,
+    .virtual-table-cell {

Review Comment:
   @justinpark @EugeneTorap Can you provide some context why the default Table theming is not sufficient? The reason I'm asking is because one of the main reason we have a table component is to make sure all tables look and behave the same throughout the application. What are the behaviors that the default Table is missing? Can we implement them on the default Table?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org