escript tests

[Andrey Somov <py...@gmail.com>]

Hi all,
I like CouchDB and I would like to read its source to understand it better.
While reading the code I have already discovered places where it can
be improved (https://issues.apache.org/jira/browse/COUCHDB-800)

I find it very helpful to run and debug tests.

1. Some test fail - I get endless loop. Are the escript  tests
maintained ? (If yes I will try to find out what is wrong with my
setup)

2. '020-btree-bacisc.t' test only works with big lists. When the
rows() method returns less then 40 then the test fail. Does it mean
that the BTree does not work with small portions of data ? May the
test be changed (or added) to be able to process 3-5 values because it
would be much more convenient to follow the execution with the
debugger ?

3. If I find a place where the code may be improved shall I first
raise a question in this list or should I create an issue with a patch
and an explanation ?

--
Andrey

Re: escript tests

[Andrey Somov <py...@gmail.com>]

Thank you very much Chris ! I did not know about such a resource :)

Re: escript tests

[Chris Anderson <jc...@apache.org>]

On Mon, Sep 27, 2010 at 9:37 AM, Andrey Somov <py...@gmail.com> wrote:
> Thank you Chris. I have updated xulrunner (I am on Ubuntu) and all the
> tests pass.
>
> Unfortunately I cannot use FreeNode because I am behind a firewall.
>

is this blocked also?

http://webchat.freenode.net/


-- 
Chris Anderson
http://jchrisa.net
http://couch.io

Re: escript tests

[Andrey Somov <py...@gmail.com>]

Thank you Chris. I have updated xulrunner (I am on Ubuntu) and all the
tests pass.

Unfortunately I cannot use FreeNode because I am behind a firewall.

Re: escript tests

[Chris Anderson <jc...@apache.org>]

On Mon, Sep 27, 2010 at 2:17 AM, Andrey Somov <py...@gmail.com> wrote:
> Hi all,
> I like CouchDB and I would like to read its source to understand it better.
> While reading the code I have already discovered places where it can
> be improved (https://issues.apache.org/jira/browse/COUCHDB-800)
>

thanks for this.

> I find it very helpful to run and debug tests.
>

the tests pass for me, i run them like this from the source directory
(make sure couchdb is not running)

`make check`

There is also a way to run them individually. I don't recall it from
the top of my head.

Another resource you should look into is the #couchdb room on irc.freenode.net

It is a great place to get answers to development questions

Chris

> 1. Some test fail - I get endless loop. Are the escript  tests
> maintained ? (If yes I will try to find out what is wrong with my
> setup)
>
> 2. '020-btree-bacisc.t' test only works with big lists. When the
> rows() method returns less then 40 then the test fail. Does it mean
> that the BTree does not work with small portions of data ? May the
> test be changed (or added) to be able to process 3-5 values because it
> would be much more convenient to follow the execution with the
> debugger ?
>
> 3. If I find a place where the code may be improved shall I first
> raise a question in this list or should I create an issue with a patch
> and an explanation ?
>
> --
> Andrey
>



-- 
Chris Anderson
http://jchrisa.net
http://couch.io

Re: escript tests

[Andrey Somov <py...@gmail.com>]

> They're maintained, but they're not widely run outside the main
> committers. If you have issues or patches for them we'd be glad to
> have them so they run everywhere.
>
It was a problem with my setup.

>> 2. '020-btree-bacisc.t' test only works with big lists. When the
>> rows() method returns less then 40 then the test fail. Does it mean
>> that the BTree does not work with small portions of data ? May the
>> test be changed (or added) to be able to process 3-5 values because it
>> would be much more convenient to follow the execution with the
>> debugger ?
>>
>
> That's unintentional. I can't say I've ever tried running with a small
> number of rows. If its a simple change I'd be willing to add it. If it
> becomes a big change I'd probably ask you to add another test to
> exercise things with smaller numbers of rows.
>
I checked the test, but I could not locate the problem. If I can
identify the cause I will report it.

>... the best place to report them is in JIRA and not here.
No problem.

Thank you.
Andrey

Re: escript tests

[Paul Davis <pa...@gmail.com>]

On Mon, Sep 27, 2010 at 5:17 AM, Andrey Somov <py...@gmail.com> wrote:
> Hi all,
> I like CouchDB and I would like to read its source to understand it better.
> While reading the code I have already discovered places where it can
> be improved (https://issues.apache.org/jira/browse/COUCHDB-800)
>
> I find it very helpful to run and debug tests.
>
> 1. Some test fail - I get endless loop. Are the escript  tests
> maintained ? (If yes I will try to find out what is wrong with my
> setup)

They're maintained, but they're not widely run outside the main
committers. If you have issues or patches for them we'd be glad to
have them so they run everywhere.

> 2. '020-btree-bacisc.t' test only works with big lists. When the
> rows() method returns less then 40 then the test fail. Does it mean
> that the BTree does not work with small portions of data ? May the
> test be changed (or added) to be able to process 3-5 values because it
> would be much more convenient to follow the execution with the
> debugger ?
>

That's unintentional. I can't say I've ever tried running with a small
number of rows. If its a simple change I'd be willing to add it. If it
becomes a big change I'd probably ask you to add another test to
exercise things with smaller numbers of rows.

> 3. If I find a place where the code may be improved shall I first
> raise a question in this list or should I create an issue with a patch
> and an explanation ?
>
> --
> Andrey
>

Either or really. Feel free to ask here or in IRC before you do too
much coding on something. If you've already have patches or find
obvious things, the best place to report them is in JIRA and not here.
All patches from non-committers must go through JIRA and JIRA
automatically sends this list an email.

HTH,
Paul Davis