You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2017/10/02 21:26:34 UTC

[GitHub] tinkerpop pull request #726: TINKERPOP-1795: Getting Lambda comparator messa...

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/726

    TINKERPOP-1795: Getting Lambda comparator message for .profile() step

    https://issues.apache.org/jira/browse/TINKERPOP-1795
    
    Some objects are hard to check for "lambdaness" and require a `toString()` analysis. We checked for `@` but that doesn't work for named steps within `order()` (when using `profile()`). That is, its error prone. I came up with a new way to check for lambdas that works for Java, Groovy, and Python/Jython. 
    
    @spmallette -- can you please verify that a "toString()" of a lambda in C# will hold as well for the pattern.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1795

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #726
    
----
commit beae74c43505d1f7732f92a500dc58fc4b142af1
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2017-10-02T21:23:33Z

    fixed a bug in LambdaRestrictionStrategy where named @ steps were considered lambda. Came up with a different way to check lambdas in .toString(). Works for Groovy, Java, and Python.

----


---

[GitHub] tinkerpop issue #726: TINKERPOP-1795: Getting Lambda comparator message for ...

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/726
  
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1


---

[GitHub] tinkerpop pull request #726: TINKERPOP-1795: Getting Lambda comparator messa...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/726


---

[GitHub] tinkerpop issue #726: TINKERPOP-1795: Getting Lambda comparator message for ...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/726
  
    VOTE: +1


---