You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by chico charlesworth <ch...@googlemail.com> on 2008/12/10 16:10:47 UTC
Parameter count and totalResults discrepancy in RestfulJsonPeopleTest.testGetPeoplePagination()
testGetPeoplePagination() in RestfulJsonPeopleTest sets the count param to 1
(i.e extraParams.put("count", "1");), yet the assertion for totalResults
expects 3.
Surely, totalResults should be 1 as specified by the count param?
If we can all agree on this, then i'll create a jira issue.
Cheers
Chico
Re: Parameter count and totalResults discrepancy in RestfulJsonPeopleTest.testGetPeoplePagination()
Posted by Ian Boston <ie...@tfd.co.uk>.
Chico,
Thank you, I will review soon and if ok (probably) will apply. I trust
you saw my comments about import order on the last set of patches, no
problem if they are wrong, I can fix.
In general always open a Jira and attach, try not to send code or
patches, even snippets to the list since you are effectively
publishing with an unclear license. (I think thats right?)
Ian
BTW, thanks for all the work you are doing here, very much appreciated.
On 13 Dec 2008, at 03:08, chico charlesworth wrote:
> I've gone ahead and created two new jira issues 785 and 782, which
> I've
> attached some patches to firstly fix some of the issues in
> PeopleServiceDb
> and ActivityServiceDb, and secondly a unit test that tests some of the
> functionality in PeopleServiceDb (it brings the code coverage up to
> 50%).
> Next, I will look into creating a unit test for ActivityServiceDb.
>
> Cheers,
> Chico
>
> 2008/12/12 chico charlesworth <ch...@googlemail.com>
>
>> Ian, I'm working on getting some more of the functionality working
>> for
>> PersonServiceDb and ActivityServiceDb, and I'm planning to submit a
>> patch
>> later on today. I was going to attach this to the jira SHINDIG-594*
>> *task,
>> but I see you have now closed this, so perhaps I'll just send the
>> patch to
>> the mailing list?
>>
>> Cheers,
>> Chico
>>
>> 2008/12/12 Ian Boston <ie...@tfd.co.uk>
>>
>> Thanks,
>>> will look into it... looking at the code in samples there are more
>>> unfinished things that I had intended (indicated by constants ==
>>> null )... I
>>> will try and do something about that asap.
>>> Ian
>>>
>>>
>>> On 12 Dec 2008, at 02:24, chico charlesworth wrote:
>>>
>>> As requested, I've created a jira issue for this bug -
>>>> https://issues.apache.org/jira/browse/SHINDIG-778.
>>>>
>>>> Cheers
>>>> Chico
>>>>
>>>> 2008/12/10 Ian Boston <ie...@tfd.co.uk>
>>>>
>>>> yes, it should be 1 as per the count param, please raise a JIRA.
>>>> I am
>>>>> going
>>>>> to try and get time to look at your patches today (with luck)
>>>>> Ian
>>>>>
>>>>>
>>>>> On 10 Dec 2008, at 15:10, chico charlesworth wrote:
>>>>>
>>>>> testGetPeoplePagination() in RestfulJsonPeopleTest sets the
>>>>> count param
>>>>> to
>>>>>
>>>>>> 1
>>>>>> (i.e extraParams.put("count", "1");), yet the assertion for
>>>>>> totalResults
>>>>>> expects 3.
>>>>>>
>>>>>> Surely, totalResults should be 1 as specified by the count param?
>>>>>> If we can all agree on this, then i'll create a jira issue.
>>>>>>
>>>>>> Cheers
>>>>>> Chico
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>
>>
Re: Parameter count and totalResults discrepancy in RestfulJsonPeopleTest.testGetPeoplePagination()
Posted by chico charlesworth <ch...@googlemail.com>.
I've gone ahead and created two new jira issues 785 and 782, which I've
attached some patches to firstly fix some of the issues in PeopleServiceDb
and ActivityServiceDb, and secondly a unit test that tests some of the
functionality in PeopleServiceDb (it brings the code coverage up to 50%).
Next, I will look into creating a unit test for ActivityServiceDb.
Cheers,
Chico
2008/12/12 chico charlesworth <ch...@googlemail.com>
> Ian, I'm working on getting some more of the functionality working for
> PersonServiceDb and ActivityServiceDb, and I'm planning to submit a patch
> later on today. I was going to attach this to the jira SHINDIG-594* *task,
> but I see you have now closed this, so perhaps I'll just send the patch to
> the mailing list?
>
> Cheers,
> Chico
>
> 2008/12/12 Ian Boston <ie...@tfd.co.uk>
>
> Thanks,
>> will look into it... looking at the code in samples there are more
>> unfinished things that I had intended (indicated by constants == null )... I
>> will try and do something about that asap.
>> Ian
>>
>>
>> On 12 Dec 2008, at 02:24, chico charlesworth wrote:
>>
>> As requested, I've created a jira issue for this bug -
>>> https://issues.apache.org/jira/browse/SHINDIG-778.
>>>
>>> Cheers
>>> Chico
>>>
>>> 2008/12/10 Ian Boston <ie...@tfd.co.uk>
>>>
>>> yes, it should be 1 as per the count param, please raise a JIRA. I am
>>>> going
>>>> to try and get time to look at your patches today (with luck)
>>>> Ian
>>>>
>>>>
>>>> On 10 Dec 2008, at 15:10, chico charlesworth wrote:
>>>>
>>>> testGetPeoplePagination() in RestfulJsonPeopleTest sets the count param
>>>> to
>>>>
>>>>> 1
>>>>> (i.e extraParams.put("count", "1");), yet the assertion for
>>>>> totalResults
>>>>> expects 3.
>>>>>
>>>>> Surely, totalResults should be 1 as specified by the count param?
>>>>> If we can all agree on this, then i'll create a jira issue.
>>>>>
>>>>> Cheers
>>>>> Chico
>>>>>
>>>>>
>>>>
>>>>
>>
>
Re: Parameter count and totalResults discrepancy in RestfulJsonPeopleTest.testGetPeoplePagination()
Posted by chico charlesworth <ch...@googlemail.com>.
Ian, I'm working on getting some more of the functionality working for
PersonServiceDb and ActivityServiceDb, and I'm planning to submit a patch
later on today. I was going to attach this to the jira SHINDIG-594* *task,
but I see you have now closed this, so perhaps I'll just send the patch to
the mailing list?
Cheers,
Chico
2008/12/12 Ian Boston <ie...@tfd.co.uk>
> Thanks,
> will look into it... looking at the code in samples there are more
> unfinished things that I had intended (indicated by constants == null )... I
> will try and do something about that asap.
> Ian
>
>
> On 12 Dec 2008, at 02:24, chico charlesworth wrote:
>
> As requested, I've created a jira issue for this bug -
>> https://issues.apache.org/jira/browse/SHINDIG-778.
>>
>> Cheers
>> Chico
>>
>> 2008/12/10 Ian Boston <ie...@tfd.co.uk>
>>
>> yes, it should be 1 as per the count param, please raise a JIRA. I am
>>> going
>>> to try and get time to look at your patches today (with luck)
>>> Ian
>>>
>>>
>>> On 10 Dec 2008, at 15:10, chico charlesworth wrote:
>>>
>>> testGetPeoplePagination() in RestfulJsonPeopleTest sets the count param
>>> to
>>>
>>>> 1
>>>> (i.e extraParams.put("count", "1");), yet the assertion for totalResults
>>>> expects 3.
>>>>
>>>> Surely, totalResults should be 1 as specified by the count param?
>>>> If we can all agree on this, then i'll create a jira issue.
>>>>
>>>> Cheers
>>>> Chico
>>>>
>>>>
>>>
>>>
>
Re: Parameter count and totalResults discrepancy in RestfulJsonPeopleTest.testGetPeoplePagination()
Posted by Ian Boston <ie...@tfd.co.uk>.
Thanks,
will look into it... looking at the code in samples there are more
unfinished things that I had intended (indicated by constants ==
null )... I will try and do something about that asap.
Ian
On 12 Dec 2008, at 02:24, chico charlesworth wrote:
> As requested, I've created a jira issue for this bug -
> https://issues.apache.org/jira/browse/SHINDIG-778.
>
> Cheers
> Chico
>
> 2008/12/10 Ian Boston <ie...@tfd.co.uk>
>
>> yes, it should be 1 as per the count param, please raise a JIRA. I
>> am going
>> to try and get time to look at your patches today (with luck)
>> Ian
>>
>>
>> On 10 Dec 2008, at 15:10, chico charlesworth wrote:
>>
>> testGetPeoplePagination() in RestfulJsonPeopleTest sets the count
>> param to
>>> 1
>>> (i.e extraParams.put("count", "1");), yet the assertion for
>>> totalResults
>>> expects 3.
>>>
>>> Surely, totalResults should be 1 as specified by the count param?
>>> If we can all agree on this, then i'll create a jira issue.
>>>
>>> Cheers
>>> Chico
>>>
>>
>>
Re: Parameter count and totalResults discrepancy in RestfulJsonPeopleTest.testGetPeoplePagination()
Posted by chico charlesworth <ch...@googlemail.com>.
As requested, I've created a jira issue for this bug -
https://issues.apache.org/jira/browse/SHINDIG-778.
Cheers
Chico
2008/12/10 Ian Boston <ie...@tfd.co.uk>
> yes, it should be 1 as per the count param, please raise a JIRA. I am going
> to try and get time to look at your patches today (with luck)
> Ian
>
>
> On 10 Dec 2008, at 15:10, chico charlesworth wrote:
>
> testGetPeoplePagination() in RestfulJsonPeopleTest sets the count param to
>> 1
>> (i.e extraParams.put("count", "1");), yet the assertion for totalResults
>> expects 3.
>>
>> Surely, totalResults should be 1 as specified by the count param?
>> If we can all agree on this, then i'll create a jira issue.
>>
>> Cheers
>> Chico
>>
>
>
Re: Parameter count and totalResults discrepancy in RestfulJsonPeopleTest.testGetPeoplePagination()
Posted by Ian Boston <ie...@tfd.co.uk>.
yes, it should be 1 as per the count param, please raise a JIRA. I am
going to try and get time to look at your patches today (with luck)
Ian
On 10 Dec 2008, at 15:10, chico charlesworth wrote:
> testGetPeoplePagination() in RestfulJsonPeopleTest sets the count
> param to 1
> (i.e extraParams.put("count", "1");), yet the assertion for
> totalResults
> expects 3.
>
> Surely, totalResults should be 1 as specified by the count param?
> If we can all agree on this, then i'll create a jira issue.
>
> Cheers
> Chico