You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "yoavcloud (via GitHub)" <gi...@apache.org> on 2025/07/14 05:47:46 UTC
[PR] Snowflake: Improve support for reserved keywords for table factor [datafusion-sqlparser-rs]
yoavcloud opened a new pull request, #1942:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1942
Aligned logic in the `Dialect` trait to other similar flows (`is_column_alias`, `is_table_alias`, etc) and added a list of reserved keywords in Snowflake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Improve support for reserved keywords for table factor [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio commented on code in PR #1942:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1942#discussion_r2231345244
##########
src/dialect/snowflake.rs:
##########
@@ -427,6 +503,21 @@ impl Dialect for SnowflakeDialect {
}
}
+ fn is_table_factor(&self, kw: &Keyword, parser: &mut Parser) -> bool {
+ match kw {
+ Keyword::LIMIT
+ if matches!(
+ parser.peek_token().token,
+ Token::Number(_, _) | Token::Placeholder(_)
+ ) =>
Review Comment:
would it make sense to use the [peek_for_limit_options](https://github.com/apache/datafusion-sqlparser-rs/blob/main/src/dialect/snowflake.rs#L483C4-L491) helper method here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Snowflake: Improve support for reserved keywords for table factor [datafusion-sqlparser-rs]
Posted by "iffyio (via GitHub)" <gi...@apache.org>.
iffyio merged PR #1942:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org