You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/27 08:29:15 UTC

[GitHub] [camel-kafka-connector] fvaleri commented on a change in pull request #336: Add CORE protocol support to SJMS2 connector

fvaleri commented on a change in pull request #336:
URL: https://github.com/apache/camel-kafka-connector/pull/336#discussion_r460728165



##########
File path: connectors/camel-sjms2-kafka-connector/pom.xml
##########
@@ -48,7 +48,10 @@
     <dependency>
       <groupId>org.apache.activemq</groupId>
       <artifactId>activemq-client</artifactId>
-      <scope>compile</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.apache.activemq</groupId>
+      <artifactId>artemis-jms-client</artifactId>

Review comment:
       Nope, unfortunately only Artemis CORE. To support OpenWire, AMQP and CORE we need three distinct dependencies. Defaulting to OpenWire (activemq-client) is good because the connector works with both ActiveMQ and Artemis. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org