[GitHub] [spark] HyukjinKwon commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #27439: [SPARK-29108][SQL][TESTS][FOLLOWUP] Comment out no use and insert into statement of window.sql (Part 2)
URL: https://github.com/apache/spark/pull/27439#discussion_r375590662
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/window_part2.sql.out
 ##########
 @@ -72,17 +59,6 @@ struct<sum(unique1) OVER (PARTITION BY four ORDER BY unique1 ASC NULLS FIRST RAN
 8	6	2
 
 
--- !query
-select last(salary) over(order by salary range between 1000 preceding and 1000 following),
-lag(salary) over(order by salary range between 1000 preceding and 1000 following),
-salary from empsalary
--- !query schema
-struct<>
--- !query output
-org.apache.spark.sql.AnalysisException
-Window Frame specifiedwindowframe(RangeFrame, -1000, 1000) must match the required frame specifiedwindowframe(RowFrame, -1, -1);
 
 Review comment:
   This query works fine in PostgreSQL. Sorry I missed some contexts in PostgreSQL test porting but shouldn't we match the results and queries?
   
   The purpose of PostgreSQL in this query is positive but I wonder if it's right to change it to negative test case for this one alone.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org